From: Hans Verkuil <hansverk@cisco.com>
To: Felipe Balbi <balbi@ti.com>, Tony Lindgren <tony@atomide.com>
Cc: Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
Linux ARM Kernel Mailing List
<linux-arm-kernel@lists.infradead.org>,
Sebastian Reichel <sre@kernel.org>,
Hans Verkuil <hans.verkuil@cisco.com>,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Subject: Re: [PATCH] arm: omap2: rx51-peripherals: fix build warning
Date: Thu, 27 Nov 2014 08:41:59 +0100 [thread overview]
Message-ID: <5476D5C7.7030400@cisco.com> (raw)
In-Reply-To: <1417033655-32332-1-git-send-email-balbi@ti.com>
On 11/26/2014 09:27 PM, Felipe Balbi wrote:
> commit 68a3c04 ([media] ARM: OMAP2: RX-51: update
> si4713 platform data) updated board-rx51-peripherals.c
> so that si4713 could be easily used on DT boot, but
> it ended up introducing a build warning whenever
> si4713 isn't enabled.
>
> This patches fixes that warning:
>
> arch/arm/mach-omap2/board-rx51-peripherals.c:1000:36: warning: \
> ‘rx51_si4713_platform_data’ defined but not used [-Wunused-variable]
> static struct si4713_platform_data rx51_si4713_platform_data = {
>
> Cc: Sebastian Reichel <sre@kernel.org>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Hans Verkuil <hans.verkuil@cisco.com>
> Cc: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
> Signed-off-by: Felipe Balbi <balbi@ti.com>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
> ---
> arch/arm/mach-omap2/board-rx51-peripherals.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/mach-omap2/board-rx51-peripherals.c b/arch/arm/mach-omap2/board-rx51-peripherals.c
> index d18a5cf..bda20c5 100644
> --- a/arch/arm/mach-omap2/board-rx51-peripherals.c
> +++ b/arch/arm/mach-omap2/board-rx51-peripherals.c
> @@ -997,9 +997,11 @@ static struct aic3x_pdata rx51_aic3x_data2 = {
> .gpio_reset = 60,
> };
>
> +#if IS_ENABLED(CONFIG_I2C_SI4713) && IS_ENABLED(CONFIG_PLATFORM_SI4713)
> static struct si4713_platform_data rx51_si4713_platform_data = {
> .is_platform_device = true
> };
> +#endif
>
> static struct i2c_board_info __initdata rx51_peripherals_i2c_board_info_2[] = {
> #if IS_ENABLED(CONFIG_I2C_SI4713) && IS_ENABLED(CONFIG_PLATFORM_SI4713)
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: hansverk@cisco.com (Hans Verkuil)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: omap2: rx51-peripherals: fix build warning
Date: Thu, 27 Nov 2014 08:41:59 +0100 [thread overview]
Message-ID: <5476D5C7.7030400@cisco.com> (raw)
In-Reply-To: <1417033655-32332-1-git-send-email-balbi@ti.com>
On 11/26/2014 09:27 PM, Felipe Balbi wrote:
> commit 68a3c04 ([media] ARM: OMAP2: RX-51: update
> si4713 platform data) updated board-rx51-peripherals.c
> so that si4713 could be easily used on DT boot, but
> it ended up introducing a build warning whenever
> si4713 isn't enabled.
>
> This patches fixes that warning:
>
> arch/arm/mach-omap2/board-rx51-peripherals.c:1000:36: warning: \
> ?rx51_si4713_platform_data? defined but not used [-Wunused-variable]
> static struct si4713_platform_data rx51_si4713_platform_data = {
>
> Cc: Sebastian Reichel <sre@kernel.org>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Hans Verkuil <hans.verkuil@cisco.com>
> Cc: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
> Signed-off-by: Felipe Balbi <balbi@ti.com>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
> ---
> arch/arm/mach-omap2/board-rx51-peripherals.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/mach-omap2/board-rx51-peripherals.c b/arch/arm/mach-omap2/board-rx51-peripherals.c
> index d18a5cf..bda20c5 100644
> --- a/arch/arm/mach-omap2/board-rx51-peripherals.c
> +++ b/arch/arm/mach-omap2/board-rx51-peripherals.c
> @@ -997,9 +997,11 @@ static struct aic3x_pdata rx51_aic3x_data2 = {
> .gpio_reset = 60,
> };
>
> +#if IS_ENABLED(CONFIG_I2C_SI4713) && IS_ENABLED(CONFIG_PLATFORM_SI4713)
> static struct si4713_platform_data rx51_si4713_platform_data = {
> .is_platform_device = true
> };
> +#endif
>
> static struct i2c_board_info __initdata rx51_peripherals_i2c_board_info_2[] = {
> #if IS_ENABLED(CONFIG_I2C_SI4713) && IS_ENABLED(CONFIG_PLATFORM_SI4713)
>
next prev parent reply other threads:[~2014-11-27 7:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-26 20:27 [PATCH] arm: omap2: rx51-peripherals: fix build warning Felipe Balbi
2014-11-26 20:27 ` Felipe Balbi
2014-11-26 20:27 ` Felipe Balbi
2014-11-26 21:56 ` Sebastian Reichel
2014-11-26 21:56 ` Sebastian Reichel
2014-11-27 7:41 ` Hans Verkuil [this message]
2014-11-27 7:41 ` Hans Verkuil
2014-12-04 15:24 ` Felipe Balbi
2014-12-04 15:24 ` Felipe Balbi
2014-12-04 15:41 ` Arnd Bergmann
2014-12-04 15:41 ` Arnd Bergmann
2014-12-04 15:48 ` Felipe Balbi
2014-12-04 15:48 ` Felipe Balbi
2014-12-04 16:39 ` Tony Lindgren
2014-12-04 16:39 ` Tony Lindgren
2014-12-04 17:00 ` Mauro Carvalho Chehab
2014-12-04 17:00 ` Mauro Carvalho Chehab
2014-12-04 17:03 ` Felipe Balbi
2014-12-04 17:03 ` Felipe Balbi
2014-12-04 17:12 ` Mauro Carvalho Chehab
2014-12-04 17:12 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5476D5C7.7030400@cisco.com \
--to=hansverk@cisco.com \
--cc=balbi@ti.com \
--cc=hans.verkuil@cisco.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.