Re: [PATCH] iio: inkern: add iio_write_channel_raw

[Lars-Peter Clausen <lars@metafoo.de>]

On 11/26/2014 11:42 PM, Dmitry Eremin-Solenikov wrote:
> Introduce API for easy in-kernel setting of DAC values.
>
> Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>

Looks good...

> ---
>   drivers/iio/inkern.c         | 29 +++++++++++++++++++++++++++++
>   include/linux/iio/consumer.h | 11 +++++++++++
>   2 files changed, 40 insertions(+)
>
> diff --git a/drivers/iio/inkern.c b/drivers/iio/inkern.c
> index f084610..5b03e69 100644
> --- a/drivers/iio/inkern.c
> +++ b/drivers/iio/inkern.c
> @@ -608,3 +608,32 @@ err_unlock:
>   	return ret;
>   }
>   EXPORT_SYMBOL_GPL(iio_get_channel_type);
> +
> +static int iio_channel_write(struct iio_channel *chan, int val, int val2,
> +	enum iio_chan_info_enum info)
> +{
> +	int ret;
> +
> +	ret = chan->indio_dev->info->write_raw(chan->indio_dev,
> +			chan->channel, val, val2, info);
> +
> +	return ret;


... but this is something the kbuild bot tester will complain about. There 
is no need for the ret variable.

> +}