From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olivier MATZ <olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH 0/3] i40e VXLAN TX checksum rework
Date: Thu, 27 Nov 2014 11:12:41 +0100
Message-ID: <5476F919.9030906@6wind.com>
References: <1417076319-629-1-git-send-email-jijiang.liu@intel.com>
 <5476F28F.7010802@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
To: Jijiang Liu <jijiang.liu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>, dev-VfR2kkLFssw@public.gmane.org
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <5476F28F.7010802-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>


>> We have got some feedback about backward compatibility of VXLAN TX
>> checksum offload API with 1G/10G NIC after the i40e VXLAN TX checksum
>> codes were applied, so we have to rework the APIs on i40e, including
>> the changes of mbuf, i40e PMD and csum engine.
>>
>> The main changes in mbuf are as follows,
>> In place of removing PKT_TX_VXLAN_CKSUM, we introducing 2 new flags:
>> PKT_TX_OUT_IP_CKSUM, PKT_TX_UDP_TUNNEL_PKT, and a new field: l4_tun_len.
>
> What about PKT_TX_OUT_UDP_CKSUM instead of PKT_TX_UDP_TUNNEL_PKT? It's
> maybe more coherent with the other names.

oh I just realized that the flag is not for asking to the hardware
to calculate the outer UDP checksum.
So why does the hardware need this information?