From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42881) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtwGn-0008P9-6l for qemu-devel@nongnu.org; Thu, 27 Nov 2014 05:25:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XtwGf-000581-8p for qemu-devel@nongnu.org; Thu, 27 Nov 2014 05:25:53 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42982) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtwGf-00057u-0R for qemu-devel@nongnu.org; Thu, 27 Nov 2014 05:25:45 -0500 Message-ID: <5476FC1F.9020405@redhat.com> Date: Thu, 27 Nov 2014 11:25:35 +0100 From: Max Reitz MIME-Version: 1.0 References: <1417023715-18210-1-git-send-email-jsnow@redhat.com> <1417023715-18210-9-git-send-email-jsnow@redhat.com> In-Reply-To: <1417023715-18210-9-git-send-email-jsnow@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v8 08/10] qapi: Add transaction support to block-dirty-bitmap-{add, enable, disable} List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-devel@nongnu.org Cc: kwolf@redhat.com, Fam Zheng , armbru@redhat.com, vsementsov@parallels.com, stefanha@redhat.com, pbonzini@redhat.com On 2014-11-26 at 18:41, John Snow wrote: > From: Fam Zheng > > This adds three qmp commands to transactions. > > Users can stop a dirty bitmap, start backup of it, and start another > dirty bitmap atomically, so that the dirty bitmap is tracked > incrementally and we don't miss any write. > > Signed-off-by: Fam Zheng > Signed-off-by: John Snow > --- > blockdev.c | 85 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > qapi-schema.json | 5 +++- > 2 files changed, 89 insertions(+), 1 deletion(-) [snip] > diff --git a/blockdev.c b/blockdev.c > index 1a56959..275eb43 100644 > --- a/blockdev.c > +++ b/blockdev.c > @@ -1564,6 +1634,21 @@ static const BdrvActionOps actions[] = { > .prepare = internal_snapshot_prepare, > .abort = internal_snapshot_abort, > }, I probably missed that in my review for v7 because I based that on my/Kevin's block-next branch instead of Stefan's (which I'm doing now): This conflicts with Stefan's AioContext series. Now there's a .clean, so it should read: .abort = internal_snapshot_abort, .clean = internal_snapshot_clean, }, (Hopefully nbsps will keep Thunderbird from breaking the indentation...) With that fixed: Reviewed-by: Max Reitz