From: mpeg.blue@free.fr (Mason)
To: linux-arm-kernel@lists.infradead.org
Subject: Code generation involving __raw_readl and __raw_writel
Date: Thu, 27 Nov 2014 11:40:34 +0100 [thread overview]
Message-ID: <5476FFA2.8010403@free.fr> (raw)
Hello everyone,
Consider the following code (preprocessor output):
static int tangox_target(struct cpufreq_policy *policy, unsigned int index)
{
while (__raw_readl((volatile void *)(0xf0000000 +(0x10024))) >> 31);
__raw_writel(0, (volatile void *)(0xf0000000 +(0x10024)));
return 0;
}
gcc generates the following code:
(version and command-line in sig below)
00000014 <tangox_target>:
14: e3a03000 mov r3, #0
18: e34f3001 movt r3, #61441 ; 0xf001
1c: e3a02000 mov r2, #0
20: e34f2001 movt r2, #61441 ; 0xf001
24: e5931024 ldr r1, [r3, #36] ; 0x24
28: e3510000 cmp r1, #0
2c: bafffffa blt 1c <tangox_target+0x8>
30: e3a00000 mov r0, #0
34: e5820024 str r0, [r2, #36] ; 0x24
38: e12fff1e bx lr
Do you know why gcc duplicates the address in r2 and r3?
And keeps putting the address in r2 over and over in the loop?
I was expecting something more along these lines:
00000014 <tangox_target>:
14: e3a03000 mov r3, #0
18: e34f3001 movt r3, #61441 ; 0xf001
1c: e5931024 ldr r1, [r3, #36] ; 0x24
20: e3510000 cmp r1, #0
24: bafffffa blt 1c <tangox_target+0x8>
28: e3a00000 mov r0, #0
2c: e5820024 str r0, [r3, #36] ; 0x24
30: e12fff1e bx lr
Regards.
--
gcc version 4.6.3 (Sourcery CodeBench Lite 2012.03-57)
arm-none-linux-gnueabi-gcc -Wp,-MD,arch/arm/mach-tangox/.cpufreq.o.d -nostdinc -isystem /utils/release/sets/6_1_3_8756/sigma-buildroot_2012.02-22/output/host/opt/ext-toolchain/bin/../lib/gcc/arm-none-linux-gnueabi/4.6.3/include -I/home/maze/linux/arch/arm/include -Iarch/arm/include/generated -Iinclude -I/home/maze/linux/arch/arm/include/uapi -Iarch/arm/include/generated/uapi -I/home/maze/linux/include/uapi -Iinclude/generated/uapi -include /home/maze/linux/include/linux/kconfig.h -D__KERNEL__ -mlittle-endian -Iarch/arm/mach-tangox/include -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs -fno-strict-aliasing -fno-common -Werror-implicit-function-declaration -Wno-format-security -fno-delete-null-pointer-checks -O2 -fno-dwarf2-cfi-asm -mabi=aapcs-linux -mno-thumb-interwork -mfpu=vfp -funwind-tables -marm -D__LINUX_ARM_ARCH__=7 -march=armv7-a -msoft-float -Uarm -Wframe-larger-than=1024 -fno-stack-protector -Wno-unused-but-set-variable -fomit-frame-pointer -fno-var-tracking-assignments
-
g -Wdeclaration-after-statement -Wno-pointer-sign -fno-strict-overflow -fconserve-stack -Werror=implicit-int -Werror=strict-prototypes -D"KBUILD_STR(s)=#s" -D"KBUILD_BASENAME=KBUILD_STR(cpufreq)" -D"KBUILD_MODNAME=KBUILD_STR(cpufreq)" -c -o arch/arm/mach-tangox/cpufreq.o arch/arm/mach-tangox/cpufreq.c
next reply other threads:[~2014-11-27 10:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-27 10:40 Mason [this message]
2014-11-27 10:48 ` Code generation involving __raw_readl and __raw_writel Russell King - ARM Linux
2014-11-27 11:09 ` Willy Tarreau
2014-11-27 11:23 ` Arnd Bergmann
2014-11-27 13:01 ` Mason
2014-11-27 13:12 ` Arnd Bergmann
2014-11-27 14:51 ` Mason
2014-11-27 15:00 ` Arnd Bergmann
2014-11-27 15:36 ` Måns Rullgård
2014-11-27 15:55 ` Mason
2014-11-27 16:18 ` Måns Rullgård
2014-11-27 16:51 ` Arnd Bergmann
2014-11-27 21:26 ` Mason
2014-11-27 21:49 ` Arnd Bergmann
2014-11-27 21:53 ` Måns Rullgård
2014-11-27 15:46 ` Mason
2014-11-27 15:59 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5476FFA2.8010403@free.fr \
--to=mpeg.blue@free.fr \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.