From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id A4112E008EC; Thu, 27 Nov 2014 02:44:03 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -0.0 SPF_HELO_PASS SPF: HELO matches SPF record * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Received: from ptmx.org (ptmx.org [178.63.28.110]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 30BE6E0082F for ; Thu, 27 Nov 2014 02:43:55 -0800 (PST) Received: from [192.168.178.14] (chello062178118086.5.14.vie.surfer.at [62.178.118.86]) by ptmx.org (Postfix) with ESMTPSA id 5713328B87 for ; Thu, 27 Nov 2014 11:43:50 +0100 (CET) Message-ID: <54770066.3060906@pseudoterminal.org> Date: Thu, 27 Nov 2014 11:43:50 +0100 From: Carlos Rafael Giani User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: meta-freescale@yoctoproject.org References: <20141113185314.GA8921@notk.org> In-Reply-To: <20141113185314.GA8921@notk.org> Subject: Re: [meta-fsl-arm-extra][PATCH] broadcom-nvram-config: add cubox-i X-BeenThere: meta-freescale@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Usage and development list for the meta-fsl-* layers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Nov 2014 10:44:03 -0000 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Since I am not knowledgeable about the Broadcom hardware, I asked around. As a conclusion, it looks fine, except for two things: * ccode=CN should use =ALL instead. This is the parameter that specifies which frequency spectrum to scan. The spectrum in EU and US are different than in CN. Perhaps this should be configurable. * MACHINE_FIRMWARE_append_mx6 = " linux-firmware-ath6k" should be changed as well. Something like "linux-firmware-brcmfmac" would make more sense, if such a package exists. On 2014-11-13 19:53, Benjamin Cohen wrote: > - add bcm4330 nvram config for cubox-i > - add bcm4330-nvram-config to MACHINE_EXTRA_RRECOMMENDS for cubox-i > > Signed-off-by: Benjamin Cohen > --- > conf/machine/cubox-i.conf | 4 ++ > .../broadcom-nvram-config/bcm4330-nvram-config.bb | 2 +- > .../files/cubox-i/brcmfmac4330-sdio.txt | 40 ++++++++++++++++++++ > 3 files changed, 45 insertions(+), 1 deletion(-) > create mode 100644 recipes-bsp/broadcom-nvram-config/files/cubox-i/brcmfmac4330-sdio.txt > > diff --git a/conf/machine/cubox-i.conf b/conf/machine/cubox-i.conf > index 6c67c19..fa90d7c 100644 > --- a/conf/machine/cubox-i.conf > +++ b/conf/machine/cubox-i.conf > @@ -33,4 +33,8 @@ KERNEL_DEVICETREE = "imx6dl-cubox-i.dtb imx6q-cubox-i.dtb imx6dl-hummingboard.dt > MACHINE_FEATURES += "pci wifi bluetooth alsa bluetooth irda serial usbhost wifi" > MACHINE_FIRMWARE_append_mx6 = " linux-firmware-ath6k" > > +MACHINE_EXTRA_RRECOMMENDS += " \ > + bcm4330-nvram-config \ > +" > + > SERIAL_CONSOLE = "115200 ttymxc0" > diff --git a/recipes-bsp/broadcom-nvram-config/bcm4330-nvram-config.bb b/recipes-bsp/broadcom-nvram-config/bcm4330-nvram-config.bb > index 592cfc9..d5e7ebb 100644 > --- a/recipes-bsp/broadcom-nvram-config/bcm4330-nvram-config.bb > +++ b/recipes-bsp/broadcom-nvram-config/bcm4330-nvram-config.bb > @@ -5,4 +5,4 @@ include broadcom-nvram-config.inc > > CHIP_MODEL = "4330" > > -COMPATIBLE_MACHINE = "(nitrogen6x-lite|wandboard-dual|wandboard-quad)" > +COMPATIBLE_MACHINE = "(nitrogen6x-lite|wandboard-dual|wandboard-quad|cubox-i)" > diff --git a/recipes-bsp/broadcom-nvram-config/files/cubox-i/brcmfmac4330-sdio.txt b/recipes-bsp/broadcom-nvram-config/files/cubox-i/brcmfmac4330-sdio.txt > new file mode 100644 > index 0000000..9546246 > --- /dev/null > +++ b/recipes-bsp/broadcom-nvram-config/files/cubox-i/brcmfmac4330-sdio.txt > @@ -0,0 +1,40 @@ > +# bcm94330wlsdgb.txt > +manfid=0x2d0 > +prodid=0x0552 > +vendid=0x14e4 > +devid=0x4360 > +boardtype=0x0552 > +boardrev=0x11 > +# this design has 2.4GHz SP3T switch > +boardflags=0x00080200 > +nocrc=1 > +xtalfreq=37400 > +boardnum=22 > +macaddr=00:90:4c:c5:12:38 > +ag0=255 > +aa2g=1 > +ccode=CN > +pa0b0=0x14d0 > +pa0b1=0xfd98 > +pa0b2=0xff78 > +rssismf2g=0xa > +rssismc2g=0x3 > +rssisav2g=0x7 > +maxp2ga0=0x50 > +sromrev=3 > +il0macaddr=00:90:4c:c5:12:38 > +wl0id=0x431b > +cckPwrOffset=5 > +ofdm2gpo=0x66666666 > +mcs2gpo0=0x6666 > +mcs2gpo1=0x6666 > +swctrlmap_2g=0x04040404,0x02020202,0x02020404,0x10202,0x1ff > +swctrlmap_5g=0x00100010,0x00280020,0x00200010,0x14202,0x2f8 > +rfreg033=0x19 > +rfreg033_cck=0x1f > +dacrate2g=160 > +txalpfbyp2g=1 > +bphyscale=17 > +cckPwrIdxCorr=-15 > +pacalidx2g=45 > +txgaintbl=1