From: Jamal Hadi Salim <jhs@mojatatu.com>
To: Jiri Pirko <jiri@resnulli.us>, netdev@vger.kernel.org
Cc: davem@davemloft.net, nhorman@tuxdriver.com, andy@greyhouse.net,
tgraf@suug.ch, dborkman@redhat.com, ogerlitz@mellanox.com,
jesse@nicira.com, pshelar@nicira.com, azhou@nicira.com,
ben@decadent.org.uk, stephen@networkplumber.org,
jeffrey.t.kirsher@intel.com, vyasevic@redhat.com,
xiyou.wangcong@gmail.com, john.r.fastabend@intel.com,
edumazet@google.com, sfeldma@gmail.com, f.fainelli@gmail.com,
roopa@cumulusnetworks.com, linville@tuxdriver.com,
jasowang@redhat.com, ebiederm@xmission.com,
nicolas.dichtel@6wind.com, ryazanov.s.a@gmail.com,
buytenh@wantstofly.org, aviadr@mellanox.com, nbd@openwrt.org,
alexei.starovoitov@gmail.com, Neil.Jerram@metaswitch.com,
ronye@mellanox.com, simon.horman@netronome.com,
alexander.h.duyck@redhat.com, john.ronciak@intel.com,
mleitner@redhat.com, shrijeet@gmail.com,
gospo@cumulusnetworks.com, bcrl@kvack.org, hemal@broadcom.com
Subject: Re: [patch net-next v4 14/21] bridge: add brport flags to dflt bridge_getlink
Date: Thu, 27 Nov 2014 08:25:30 -0500 [thread overview]
Message-ID: <5477264A.6060904@mojatatu.com> (raw)
In-Reply-To: <5477244C.2030507@mojatatu.com>
On 11/27/14 08:17, Jamal Hadi Salim wrote:
> On 11/27/14 05:40, Jiri Pirko wrote:
>> From: Scott Feldman <sfeldma@gmail.com>
>>
>> To allow brport device to return current brport flags set on port. Add
>> returned flags to nested IFLA_PROTINFO netlink msg built in dflt getlink.
>> With this change, netlink msg returned for bridge_getlink contains the
>> port's
>> offloaded flag settings (the port's SELF settings).
>
> Am i missing something or we already have this stuff showing up in user
> space today?
>
Sorry, in events it does but for some reason not in the GETs
even though trying to trace the code ndo_bridge_getlink()
i couldnt tell off hand why it is not showing up.
look at: br_port_fill_attrs() and its callers.
cheers,
jamal
next prev parent reply other threads:[~2014-11-27 13:25 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-27 10:40 [patch net-next v4 00/21] introduce rocker switch driver with hardware accelerated datapath api - phase 1: bridge fdb offload Jiri Pirko
2014-11-27 10:40 ` [patch net-next v4 01/21] bridge: rename fdb_*_hw to fdb_*_hw_addr to avoid confusion Jiri Pirko
2014-11-27 10:40 ` [patch net-next v4 02/21] neigh: sort Neighbor Cache Entry Flags Jiri Pirko
2014-11-27 10:40 ` [patch net-next v4 03/21] bridge: convert flags in fbd entry into bitfields Jiri Pirko
2014-11-27 10:40 ` [patch net-next v4 04/21] net: make vid as a parameter for ndo_fdb_add/ndo_fdb_del Jiri Pirko
2014-11-27 10:40 ` [patch net-next v4 05/21] net: rename netdev_phys_port_id to more generic name Jiri Pirko
2014-11-27 10:40 ` [patch net-next v4 06/21] net: introduce generic switch devices support Jiri Pirko
2014-11-27 10:40 ` [patch net-next v4 07/21] rtnl: expose physical switch id for particular device Jiri Pirko
2014-11-27 10:40 ` [patch net-next v4 08/21] net-sysfs: " Jiri Pirko
2014-11-27 10:40 ` [patch net-next v4 09/21] bridge: call netdev_sw_port_stp_update when bridge port STP status changes Jiri Pirko
2014-11-27 13:14 ` Jamal Hadi Salim
2014-11-27 13:43 ` Jiri Pirko
2014-11-27 10:40 ` [patch net-next v4 10/21] bridge: add API to notify bridge driver of learned FBD on offloaded device Jiri Pirko
2014-11-27 10:40 ` [patch net-next v4 11/21] bridge: move private brport flags to if_bridge.h so port drivers can use flags Jiri Pirko
2014-11-27 10:40 ` [patch net-next v4 12/21] bridge: add new brport flag LEARNING_SYNC Jiri Pirko
2014-11-27 10:40 ` [patch net-next v4 13/21] bridge: add new hwmode swdev Jiri Pirko
2014-11-27 13:31 ` Sergei Shtylyov
2014-11-27 10:40 ` [patch net-next v4 14/21] bridge: add brport flags to dflt bridge_getlink Jiri Pirko
2014-11-27 13:17 ` Jamal Hadi Salim
2014-11-27 13:25 ` Jamal Hadi Salim [this message]
2014-11-27 20:46 ` Scott Feldman
2014-11-28 13:07 ` Jamal Hadi Salim
2014-11-27 10:40 ` [patch net-next v4 15/21] rocker: introduce rocker switch driver Jiri Pirko
2014-11-27 13:31 ` Jamal Hadi Salim
2014-11-27 10:40 ` [patch net-next v4 16/21] rocker: implement rocker ofdpa flow table manipulation Jiri Pirko
2014-11-27 10:40 ` [patch net-next v4 17/21] rocker: implement L2 bridge offloading Jiri Pirko
2014-11-27 10:40 ` [patch net-next v4 18/21] rocker: implement ndo_fdb_dump Jiri Pirko
2014-11-27 10:40 ` [patch net-next v4 19/21] rocker: add ndo_bridge_setlink/getlink support for learning policy Jiri Pirko
2014-11-27 10:40 ` [patch net-next v4 20/21] rocker: Add proper validation of Netlink attributes Jiri Pirko
2014-11-27 21:04 ` Scott Feldman
2014-11-27 10:40 ` [patch net-next v4 21/21] rocker: Use logical operators on booleans Jiri Pirko
2014-11-27 21:04 ` Scott Feldman
2014-11-28 11:59 ` [patch net-next v4 00/21] introduce rocker switch driver with hardware accelerated datapath api - phase 1: bridge fdb offload Scott Feldman
2014-11-28 12:07 ` Jiri Pirko
2014-11-28 16:52 ` Roopa Prabhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5477264A.6060904@mojatatu.com \
--to=jhs@mojatatu.com \
--cc=Neil.Jerram@metaswitch.com \
--cc=alexander.h.duyck@redhat.com \
--cc=alexei.starovoitov@gmail.com \
--cc=andy@greyhouse.net \
--cc=aviadr@mellanox.com \
--cc=azhou@nicira.com \
--cc=bcrl@kvack.org \
--cc=ben@decadent.org.uk \
--cc=buytenh@wantstofly.org \
--cc=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=ebiederm@xmission.com \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=gospo@cumulusnetworks.com \
--cc=hemal@broadcom.com \
--cc=jasowang@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse@nicira.com \
--cc=jiri@resnulli.us \
--cc=john.r.fastabend@intel.com \
--cc=john.ronciak@intel.com \
--cc=linville@tuxdriver.com \
--cc=mleitner@redhat.com \
--cc=nbd@openwrt.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=nicolas.dichtel@6wind.com \
--cc=ogerlitz@mellanox.com \
--cc=pshelar@nicira.com \
--cc=ronye@mellanox.com \
--cc=roopa@cumulusnetworks.com \
--cc=ryazanov.s.a@gmail.com \
--cc=sfeldma@gmail.com \
--cc=shrijeet@gmail.com \
--cc=simon.horman@netronome.com \
--cc=stephen@networkplumber.org \
--cc=tgraf@suug.ch \
--cc=vyasevic@redhat.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.