From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?windows-1252?Q?Roger_Pau_Monn=E9?= Subject: Re: [PATCH for-4.6] libxl, hotplug/Linux: default to phy backend for raw format file Date: Thu, 27 Nov 2014 16:00:40 +0100 Message-ID: <54773C98.8010002@citrix.com> References: <1417020935-2934-1-git-send-email-wei.liu2@citrix.com> <54760EA5.1030407@citrix.com> <20141126174421.GA14481@zion.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20141126174421.GA14481@zion.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: Stefano Stabellini , Ian Jackson , Ian Campbell , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org El 26/11/14 a les 18.44, Wei Liu ha escrit: > On Wed, Nov 26, 2014 at 06:32:21PM +0100, Roger Pau Monn=E9 wrote: >> El 26/11/14 a les 17.55, Wei Liu ha escrit: >>> Modify libxl and hotplug script to allow raw format file to use phy >>> backend. >>> >>> The block script now tests the path and determine the actual type of >>> file (block device or regular file) then use the actual type to >>> determine which branch to run. >>> >>> With these changes, plus the current ordering of backend preference (phy >>>> qdisk > tap), we will use phy backend for raw format file by default. >> >> Maybe it's a stupid question, but I remember that last time this changed >> was attempted it caused problems with local migration. Has this been fix= ed? >> >> I'm asking because there's no comment of this in the commit message, and >> the code doesn't seem to differ from the first try in 11a63a. >> > = > Yes, it's fixed. > = > Actually I think the regression last time was not local migration but > another problem. > = > This patch is different from the last one, libxl won't write > "physical-device" if the file is regular file. I think last time the > hotplug script was not run correctly due to that problem. IMHO it would be good to add that to the commit message. Acked-by: Roger Pau Monn=E9