From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org, qemu-ppc@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] ppc: do not use get_clock_realtime()
Date: Thu, 27 Nov 2014 18:00:38 +0100 [thread overview]
Message-ID: <547758B6.3010301@redhat.com> (raw)
In-Reply-To: <20141127005140.GF17494@thor.bakeyournoodle.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 27/11/2014 01:51, Tony Breeds wrote:
> On Wed, Nov 26, 2014 at 03:01:01PM +0100, Paolo Bonzini wrote:
>> Use the external qemu-timer API instead.
>
> Perhaps it's obvious but is it reasonable to expand on why you're
> doign this in the commit message?
You're right. It's just that the API should be private to
qemu-timer.c, it is not meant for external usage---and it is messy
because get_clock_realtime() is for QEMU_CLOCK_HOST.
In addition, all uses of QEMU_CLOCK_HOST should probably use rtc_clock
instead, and this patch makes it easier to track those places for a
follow-up switch to rtc_clock.
Paolo
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQEcBAEBAgAGBQJUd1izAAoJEL/70l94x66D8ncH/jwc6oVfUjHvBau3GJy0Vi/I
S5kMndpPKgepMlAWWSK67uoMZQWAyRwG4Bwyat3g8RnpevQTN1pLZG276c2f5t5o
piB9nGmT7BPhxkEiWGGtxeX5ob1Ab8hhTm4Ai78fH8OnQexBT1B06Oz3zcYZKoGD
ckbCzEeiAb8Jxm4wop/s+WApqcnWAsfriCJ0XWUQxtxIbt3esmfMzW+n2fxvhHI1
ookJgqn1ssHpZBYu5lnsPxY+kVTrf0dQaeiPApGSmHUJknmnAEXUGKl1jsdjLCE2
8h5sasf3a7xL+GmZrYjzyZbLYm6BqmjNSsBYCFHYVYVFl857b/S1azoxPC5EZc0=
=4+yL
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2014-11-27 17:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-26 14:01 [Qemu-devel] [PATCH] ppc: do not use get_clock_realtime() Paolo Bonzini
2014-11-27 0:51 ` Tony Breeds
2014-11-27 17:00 ` Paolo Bonzini [this message]
2014-12-05 6:14 ` Tony Breeds
2014-12-17 12:00 ` [Qemu-devel] [Qemu-ppc] " Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547758B6.3010301@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.