From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41230) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xu39c-0000zw-EH for qemu-devel@nongnu.org; Thu, 27 Nov 2014 12:47:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xu39W-0001uo-9t for qemu-devel@nongnu.org; Thu, 27 Nov 2014 12:46:56 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51623) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xu39W-0001uj-3B for qemu-devel@nongnu.org; Thu, 27 Nov 2014 12:46:50 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sARHknOB008078 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 27 Nov 2014 12:46:49 -0500 Message-ID: <54776384.4040507@redhat.com> Date: Thu, 27 Nov 2014 18:46:44 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1417010463-3527-2-git-send-email-pbonzini@redhat.com> <873895knke.fsf@blackfin.pond.sub.org> <5477534C.5050905@redhat.com> <87y4qwa66f.fsf@blackfin.pond.sub.org> In-Reply-To: <87y4qwa66f.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] block: do not use get_clock() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com On 27/11/2014 18:45, Markus Armbruster wrote: >> > >> > Because no one else calls it directly, it is an internal function. I >> > want to keep it confined to qemu-timer.c (and possibly cpus.c in the >> > icount implementation, but maybe not even that is necessary). > That's a perfectly sensible reason. Please add it to the commit > message, so we have a more permanent record. > > Of course, the best permanent record would be a static keyword :) That's on the todo list. :) I'll send v2 as a toplevel patch if I don't hear from Kevin or Stefan in a few days. This is 2.3 work so there's time. Paolo