From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37536)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1Xu5Nu-0005bQ-U7
	for Qemu-devel@nongnu.org; Thu, 27 Nov 2014 15:09:56 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1Xu5Np-0007ly-Jg
	for Qemu-devel@nongnu.org; Thu, 27 Nov 2014 15:09:50 -0500
Received: from mail-r83.rz.uni-mannheim.de ([134.155.96.83]:44523)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1Xu5Np-0007lT-D1
	for Qemu-devel@nongnu.org; Thu, 27 Nov 2014 15:09:45 -0500
Message-ID: <54778506.5060200@weilnetz.de>
Date: Thu, 27 Nov 2014 21:09:42 +0100
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <93259ECD-066A-413E-B647-2BB240DBF7EC@livius.net>	<CAFEAcA8cNDCyv1EqvhKAxaG=7E4Ou=eSL6=aY+eu2tz87m61cQ@mail.gmail.com>	<2E7B730D-C409-4800-9BEC-8E302812C7E8@livius.net>	<CAFEAcA_JU77673ao2gvjjWhD849QLAgN5foEzdCjcxuyAAVDNw@mail.gmail.com>
	<CAC8255E-CD79-4CBB-A09F-21CCD6DA6813@livius.net>
In-Reply-To: <CAC8255E-CD79-4CBB-A09F-21CCD6DA6813@livius.net>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] MinGW build
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Liviu Ionescu <ilg@livius.net>
Cc: Peter Maydell <peter.maydell@linaro.org>, QEMU Developers <Qemu-devel@nongnu.org>

Am 27.11.2014 um 20:57 schrieb Liviu Ionescu:
>=20
> On 27 Nov 2014, at 21:34, Peter Maydell <peter.maydell@linaro.org> wrot=
e:
>=20
>> On 27 November 2014 at 16:43, Liviu Ionescu <ilg@livius.net> wrote:
>>> in qemu-common.h:
>>>
>>> #ifdef _WIN32
>>> #include "sysemu/os-win32.h"
>>> #endif
>>>
>>> #ifdef __MINGW32__
>>> #include "sysemu/os-win32.h"
>>> #endif
>>
>> Wait, so your mingw toolchain doesn't define _WIN32 ??
>> That seems likely to break a lot of other code that does
>> ifdef checks on _WIN32.
>=20
> good point!=20
>=20
> I removed the second #ifdef, and the build passed.
>=20
> but the countless warnings are still there :-(
>=20
>=20
> regards,
>=20
> Liviu


The countless warnings are "normal" because you use MinGW which is
unmaintained since several years.

There is a better alternative: use Mingw-w64. It compiles QEMU (*nearly)
without warnings, solves the ffs problem and has the additional benefit
that it supports both 32 bit and 64 bit builds.

Maybe we should drop MinGW support completely...

Cheers
Stefan

*nearly means that there are still warnings for format strings in C++
code. You won't see them if you don't install a C++ compiler, but as you
are interested in ARM and the C++ code is needed for the ARM
disassembler, you might want it.