From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37487)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1XuFl3-0004rg-As
	for Qemu-devel@nongnu.org; Fri, 28 Nov 2014 02:14:31 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1XuFkx-0006VI-8K
	for Qemu-devel@nongnu.org; Fri, 28 Nov 2014 02:14:25 -0500
Received: from mail-r83.rz.uni-mannheim.de ([134.155.96.83]:56428)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1XuFkx-0006Uy-1O
	for Qemu-devel@nongnu.org; Fri, 28 Nov 2014 02:14:19 -0500
Message-ID: <547820C8.3060805@weilnetz.de>
Date: Fri, 28 Nov 2014 08:14:16 +0100
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <93259ECD-066A-413E-B647-2BB240DBF7EC@livius.net>
	<CAFEAcA8cNDCyv1EqvhKAxaG=7E4Ou=eSL6=aY+eu2tz87m61cQ@mail.gmail.com>
	<2E7B730D-C409-4800-9BEC-8E302812C7E8@livius.net>
	<CAFEAcA_JU77673ao2gvjjWhD849QLAgN5foEzdCjcxuyAAVDNw@mail.gmail.com>
	<CAC8255E-CD79-4CBB-A09F-21CCD6DA6813@livius.net>
	<54778506.5060200@weilnetz.de>
	<CAFEAcA-y9oTZW2YnQGDH=W3VCW6_hfHy7W0B41jLSo+DyJE1Dw@mail.gmail.com>
In-Reply-To: <CAFEAcA-y9oTZW2YnQGDH=W3VCW6_hfHy7W0B41jLSo+DyJE1Dw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] MinGW build
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Liviu Ionescu <ilg@livius.net>, QEMU Developers <Qemu-devel@nongnu.org>

Am 27.11.2014 um 21:18 schrieb Peter Maydell:
> On 27 November 2014 at 20:09, Stefan Weil <sw@weilnetz.de> wrote:
>> *nearly means that there are still warnings for format strings in C++
>> code.
>=20
> Hmm, do we still have these with the libvixl version we have
> now? If so, could you forward me a copy of them and I'll see
> if I can persuade upstream to fix them...
>=20
> thanks
> -- PMM
>=20


The libvixl code is correct, but the C++ compiler would need to be
fixed. Here are some examples:

disas/libvixl/a64/disasm-a64.cc:1340:57: warning: unknown conversion
type character =E2=80=98l=E2=80=99 in format [-Wformat]
disas/libvixl/a64/disasm-a64.cc:1340:57: warning: too many arguments for
format [-Wformat-extra-args]
disas/libvixl/a64/disasm-a64.cc:1492:42: warning: unknown conversion
type character =E2=80=98l=E2=80=99 in format [-Wformat]

That code uses PRIx64, so the format specifier is %llx which is correct.
Obviously the C++ compiler ignores that QEMU uses ANSI format specifiers
(compiler option -D__USE_MINGW_ANSI_STDIO=3D1) instead of the MS specific
ones.

A simple workaround for QEMU would just suppress -Wformat and
-Wformat-extra-args for C++ code.

Regards
Stefan