From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Yan Subject: Re: [PATCH v13 08/12] drm: bridge/dw_hdmi: add mode_valid support Date: Fri, 28 Nov 2014 17:47:06 +0800 Message-ID: <5478449A.40307@rock-chips.com> References: <1417008157-31861-1-git-send-email-andy.yan@rock-chips.com> <1417008811-32308-1-git-send-email-andy.yan@rock-chips.com> <1417018985.3177.8.camel@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1417018985.3177.8.camel@pengutronix.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Philipp Zabel Cc: Mark Rutland , heiko@sntech.de, airlied@linux.ie, dri-devel@lists.freedesktop.org, ykk@rock-chips.com, devel@driverdev.osuosl.org, Pawel Moll , linux-rockchip@lists.infradead.org, Grant Likely , Dave Airlie , jay.xu@rock-chips.com, devicetree@vger.kernel.org, Zubair.Kakakhel@imgtec.com, Arnd Bergmann , Ian Campbell , Inki Dae , Rob Herring , Sean Paul , rmk+kernel@arm.linux.org.uk, mark.yao@rock-chips.com, fabio.estevam@freescale.com, Josh Boyer , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, djkurtz@google.com, Kumar Gala , Shawn Guo , Lucas Stach List-Id: devicetree@vger.kernel.org SGkgUGhpbGlwcDoKCk9uIDIwMTTlubQxMeaciDI35pelIDAwOjIzLCBQaGlsaXBwIFphYmVsIHdy b3RlOgo+IEFtIE1pdHR3b2NoLCBkZW4gMjYuMTEuMjAxNCwgMjE6MzMgKzA4MDAgc2NocmllYiBB bmR5IFlhbjoKPj4gc29tZSBwbGF0Zm9ybSBtYXkgbm90IHN1cHBvcnQgYWxsIHRoZSBkaXNwbGF5 IG1vZGUsCj4+IGFkZCBtb2RlX3ZhbGlkIGludGVyZmFjZSBjaGVjayBpdAo+Pgo+PiBhbHNvIGFk ZCBkcm1fY29ubmVjdG9yX3JlZ2lzdGVyIHdoaWNoIGFkZCBhIGRlYnVnZnMKPj4gaW50ZXJmYWNl IGZvciBkdW1wIGRpc3BsYXkgbW9kZXMgYW5kIGVkaWQgaW5mb3JtYXRpb24KPj4KPj4gU2lnbmVk LW9mZi1ieTogQW5keSBZYW4gPGFuZHkueWFuQHJvY2stY2hpcHMuY29tPgo+PiAtLS0KPj4KPj4g Q2hhbmdlcyBpbiB2MTM6IE5vbmUKPj4gQ2hhbmdlcyBpbiB2MTI6IE5vbmUKPj4gQ2hhbmdlcyBp biB2MTE6IE5vbmUKPj4gQ2hhbmdlcyBpbiB2MTA6IE5vbmUKPj4gQ2hhbmdlcyBpbiB2OTogTm9u ZQo+PiBDaGFuZ2VzIGluIHY4OiBOb25lCj4+IENoYW5nZXMgaW4gdjc6IE5vbmUKPj4gQ2hhbmdl cyBpbiB2NjogTm9uZQo+PiBDaGFuZ2VzIGluIHY1OiBOb25lCj4+IENoYW5nZXMgaW4gdjQ6IE5v bmUKPj4gQ2hhbmdlcyBpbiB2MzogTm9uZQo+Pgo+PiAgIGRyaXZlcnMvZ3B1L2RybS9icmlkZ2Uv ZHdfaGRtaS5jIHwgMTcgKysrKysrKysrKysrKysrKysKPj4gICBpbmNsdWRlL2RybS9icmlkZ2Uv ZHdfaGRtaS5oICAgICB8ICAyICsrCj4+ICAgMiBmaWxlcyBjaGFuZ2VkLCAxOSBpbnNlcnRpb25z KCspCj4+Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL2R3X2hkbWkuYyBi L2RyaXZlcnMvZ3B1L2RybS9icmlkZ2UvZHdfaGRtaS5jCj4+IGluZGV4IDVlODhjOGQuLmIxM2U3 ODIgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2UvZHdfaGRtaS5jCj4+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2UvZHdfaGRtaS5jCj4+IEBAIC0xNDA2LDYgKzE0MDYs MjAgQEAgc3RhdGljIGludCBkd19oZG1pX2Nvbm5lY3Rvcl9nZXRfbW9kZXMoc3RydWN0IGRybV9j b25uZWN0b3IgKmNvbm5lY3RvcikKPj4gICAJcmV0dXJuIDA7Cj4+ICAgfQo+PiAgIAo+PiArc3Rh dGljIGVudW0gZHJtX21vZGVfc3RhdHVzCj4+ICtkd19oZG1pX2Nvbm5lY3Rvcl9tb2RlX3ZhbGlk KHN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IsCj4+ICsJCQkgICAgIHN0cnVjdCBkcm1f ZGlzcGxheV9tb2RlICptb2RlKQo+PiArewo+PiArCXN0cnVjdCBkd19oZG1pICpoZG1pID0gY29u dGFpbmVyX29mKGNvbm5lY3RvciwKPj4gKwkJCQkJICAgc3RydWN0IGR3X2hkbWksIGNvbm5lY3Rv cik7Cj4+ICsJZW51bSBkcm1fbW9kZV9zdGF0dXMgbW9kZV9zdGF0dXMgPSBNT0RFX09LOwo+PiAr Cj4+ICsJaWYgKGhkbWktPnBsYXRfZGF0YS0+bW9kZV92YWxpZCkKPj4gKwkJbW9kZV9zdGF0dXMg PSBoZG1pLT5wbGF0X2RhdGEtPm1vZGVfdmFsaWQoY29ubmVjdG9yLCBtb2RlKTsKPj4gKwo+PiAr CXJldHVybiBtb2RlX3N0YXR1czsKPj4gK30KPj4gKwo+PiAgIHN0YXRpYyBzdHJ1Y3QgZHJtX2Vu Y29kZXIgKmR3X2hkbWlfY29ubmVjdG9yX2Jlc3RfZW5jb2RlcihzdHJ1Y3QgZHJtX2Nvbm5lY3Rv cgo+PiAgIAkJCQkJCQkgICAqY29ubmVjdG9yKQo+PiAgIHsKPj4gQEAgLTE0MzAsNiArMTQ0NCw3 IEBAIHN0YXRpYyBzdHJ1Y3QgZHJtX2Nvbm5lY3Rvcl9mdW5jcyBkd19oZG1pX2Nvbm5lY3Rvcl9m dW5jcyA9IHsKPj4gICAKPj4gICBzdGF0aWMgc3RydWN0IGRybV9jb25uZWN0b3JfaGVscGVyX2Z1 bmNzIGR3X2hkbWlfY29ubmVjdG9yX2hlbHBlcl9mdW5jcyA9IHsKPj4gICAJLmdldF9tb2RlcyA9 IGR3X2hkbWlfY29ubmVjdG9yX2dldF9tb2RlcywKPj4gKwkubW9kZV92YWxpZCA9IGR3X2hkbWlf Y29ubmVjdG9yX21vZGVfdmFsaWQsCj4+ICAgCS5iZXN0X2VuY29kZXIgPSBkd19oZG1pX2Nvbm5l Y3Rvcl9iZXN0X2VuY29kZXIsCj4+ICAgfTsKPj4gICAKPj4gQEAgLTE2MzEsNiArMTY0Niw4IEBA IGludCBkd19oZG1pX2JpbmQoc3RydWN0IGRldmljZSAqZGV2LCBzdHJ1Y3QgZGV2aWNlICptYXN0 ZXIsCj4+ICAgCj4+ICAgCWRldl9zZXRfZHJ2ZGF0YShkZXYsIGhkbWkpOwo+PiAgIAo+PiArCWRy bV9jb25uZWN0b3JfcmVnaXN0ZXIoJmhkbWktPmNvbm5lY3Rvcik7Cj4+ICsKPiBUaGlzIGlzIG5v dCByaWdodCwgdGhlIGNvbm5lY3RvciBpcyByZWdpc3RlcmVkIGJ5IHRoZSBpbXgtZHJtIGNvcmUg aW4KPiB0aGUgZHJtX2RyaXZlciAubG9hZCBjYWxsYmFjay4KICAgICBTb3JyeSwgSSBkaWRuJ3Qg Zm91bmQgaW14LWRybSBjb3JlIGhhcyBkaWQgdGhhdCBiZWZvcmUuQW5kIEkgZm91bmQgbWFueQpj b25uZWN0b3IgZHJpdmVycyByZWdpc3RlciBpdCBieSBpdHNlbGYuCiAgICBUaGlzIHdpbGwgYmUg cmVtb3ZlZCBpbiBuZXh0IHBhdGNoLgo+IHJlZ2FyZHMKPiBQaGlsaXBwCj4KPgo+Cj4KCgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkZXZlbCBtYWlsaW5n IGxpc3QKZGV2ZWxAbGludXhkcml2ZXJwcm9qZWN0Lm9yZwpodHRwOi8vZHJpdmVyZGV2LmxpbnV4 ZHJpdmVycHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcml2ZXJkZXYtZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751586AbaK1JrS (ORCPT ); Fri, 28 Nov 2014 04:47:18 -0500 Received: from lucky1.263xmail.com ([211.157.147.132]:56904 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751053AbaK1JrQ (ORCPT ); Fri, 28 Nov 2014 04:47:16 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: andy.yan@rock-chips.com X-FST-TO: galak@codeaurora.org X-SENDER-IP: 121.15.173.1 X-LOGIN-NAME: andy.yan@rock-chips.com X-UNIQUE-TAG: <2c53092dee6373ad6b64b5c5bf7167ae> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <5478449A.40307@rock-chips.com> Date: Fri, 28 Nov 2014 17:47:06 +0800 From: Andy Yan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Philipp Zabel CC: airlied@linux.ie, heiko@sntech.de, fabio.estevam@freescale.com, rmk+kernel@arm.linux.org.uk, Greg Kroah-Hartman , Grant Likely , Rob Herring , Shawn Guo , Josh Boyer , Sean Paul , Inki Dae , Dave Airlie , Arnd Bergmann , Lucas Stach , Zubair.Kakakhel@imgtec.com, djkurtz@google.com, ykk@rock-chips.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, devel@driverdev.osuosl.org, devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org, jay.xu@rock-chips.com, Pawel Moll , mark.yao@rock-chips.com, Mark Rutland , Ian Campbell , Kumar Gala Subject: Re: [PATCH v13 08/12] drm: bridge/dw_hdmi: add mode_valid support References: <1417008157-31861-1-git-send-email-andy.yan@rock-chips.com> <1417008811-32308-1-git-send-email-andy.yan@rock-chips.com> <1417018985.3177.8.camel@pengutronix.de> In-Reply-To: <1417018985.3177.8.camel@pengutronix.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Philipp: On 2014年11月27日 00:23, Philipp Zabel wrote: > Am Mittwoch, den 26.11.2014, 21:33 +0800 schrieb Andy Yan: >> some platform may not support all the display mode, >> add mode_valid interface check it >> >> also add drm_connector_register which add a debugfs >> interface for dump display modes and edid information >> >> Signed-off-by: Andy Yan >> --- >> >> Changes in v13: None >> Changes in v12: None >> Changes in v11: None >> Changes in v10: None >> Changes in v9: None >> Changes in v8: None >> Changes in v7: None >> Changes in v6: None >> Changes in v5: None >> Changes in v4: None >> Changes in v3: None >> >> drivers/gpu/drm/bridge/dw_hdmi.c | 17 +++++++++++++++++ >> include/drm/bridge/dw_hdmi.h | 2 ++ >> 2 files changed, 19 insertions(+) >> >> diff --git a/drivers/gpu/drm/bridge/dw_hdmi.c b/drivers/gpu/drm/bridge/dw_hdmi.c >> index 5e88c8d..b13e782 100644 >> --- a/drivers/gpu/drm/bridge/dw_hdmi.c >> +++ b/drivers/gpu/drm/bridge/dw_hdmi.c >> @@ -1406,6 +1406,20 @@ static int dw_hdmi_connector_get_modes(struct drm_connector *connector) >> return 0; >> } >> >> +static enum drm_mode_status >> +dw_hdmi_connector_mode_valid(struct drm_connector *connector, >> + struct drm_display_mode *mode) >> +{ >> + struct dw_hdmi *hdmi = container_of(connector, >> + struct dw_hdmi, connector); >> + enum drm_mode_status mode_status = MODE_OK; >> + >> + if (hdmi->plat_data->mode_valid) >> + mode_status = hdmi->plat_data->mode_valid(connector, mode); >> + >> + return mode_status; >> +} >> + >> static struct drm_encoder *dw_hdmi_connector_best_encoder(struct drm_connector >> *connector) >> { >> @@ -1430,6 +1444,7 @@ static struct drm_connector_funcs dw_hdmi_connector_funcs = { >> >> static struct drm_connector_helper_funcs dw_hdmi_connector_helper_funcs = { >> .get_modes = dw_hdmi_connector_get_modes, >> + .mode_valid = dw_hdmi_connector_mode_valid, >> .best_encoder = dw_hdmi_connector_best_encoder, >> }; >> >> @@ -1631,6 +1646,8 @@ int dw_hdmi_bind(struct device *dev, struct device *master, >> >> dev_set_drvdata(dev, hdmi); >> >> + drm_connector_register(&hdmi->connector); >> + > This is not right, the connector is registered by the imx-drm core in > the drm_driver .load callback. Sorry, I didn't found imx-drm core has did that before.And I found many connector drivers register it by itself. This will be removed in next patch. > regards > Philipp > > > >