From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH] xsave: export get_xsave_addr Date: Fri, 28 Nov 2014 11:29:53 +0100 Message-ID: <54784EA1.7080106@redhat.com> References: <1417166928-6281-1-git-send-email-tiejun.chen@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Tiejun Chen Return-path: Received: from mx1.redhat.com ([209.132.183.28]:46996 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750981AbaK1K37 (ORCPT ); Fri, 28 Nov 2014 05:29:59 -0500 In-Reply-To: <1417166928-6281-1-git-send-email-tiejun.chen@intel.com> Sender: kvm-owner@vger.kernel.org List-ID: On 28/11/2014 10:28, Tiejun Chen wrote: > After commit, 1d7fe1d1, "KVM: x86: support XSAVES usage in the host", > is introduced, > > ... > Building modules, stage 2. > MODPOST 20 modules > ERROR: "get_xsave_addr" [arch/x86/kvm/kvm.ko] undefined! > make[1]: *** [__modpost] Error 1 > make: *** [modules] Error 2 > > so we need to export get_xsave_addr() while using KVM as > a module. > > Signed-off-by: Tiejun Chen > --- > > I'm not sure if this is already fixed so just post in advance. Yes, it is fixed---Stephen Rothwell's linux-next testing caught it immediately. Pushing the XSAVES patch was unintended, since it hadn't been tested nor reviewed. Paolo > > arch/x86/kernel/xsave.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/x86/kernel/xsave.c b/arch/x86/kernel/xsave.c > index 4c540c4..0de1fae 100644 > --- a/arch/x86/kernel/xsave.c > +++ b/arch/x86/kernel/xsave.c > @@ -738,3 +738,4 @@ void *get_xsave_addr(struct xsave_struct *xsave, int xstate) > > return (void *)xsave + xstate_comp_offsets[feature]; > } > +EXPORT_SYMBOL_GPL(get_xsave_addr); >