From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Date: Fri, 28 Nov 2014 11:09:02 +0000 Subject: Re: [PATCH] ARM: shmobile: dts: koelsch: Fix flash partition label and size Message-Id: <547857CE.1090408@cogentembedded.com> List-Id: References: <1416960805-15185-1-git-send-email-horms+renesas@verge.net.au> <5475CCA5.2020300@cogentembedded.com> <20141128002718.GF30850@verge.net.au> In-Reply-To: <20141128002718.GF30850@verge.net.au> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org Hello. On 11/28/2014 3:27 AM, Simon Horman wrote: >>> Update the size and names of flash partitions to match the >>> expectations of the loader which are as follows: >>> "loader"---0x0000_0000-0x0008_0000 [loader program (readonly)] >>> "user" ---0x0008_0000-0x0060_0000 [U-Boot + bootargs + dt + uImage (readonly)] >>> "flash" ---0x0060_0000-0x0400_0000 [filesystem and free (read/write)] >>> ["user"'s assumed breakdown] >>> U-boot+ bootargs(0x0008_0000-0x0010_0000) 512KB >>> Device tree (0x0010_0000-0x0014_0000) 256KB >>> uImage (0x0014_0000-0x0060_0000) 4.75MB >>> Signed-off-by: Simon Horman >>> --- >>> This replaces a patch that I previously posted, "shmobile: koelsch: Fix >>> flash partition label and size in device tree", which has the same aim but >>> does so for an older version of the loader which to my knowledge is not >>> found in the wild. >>> I plan to post a similar patch for Lager if this one goes well. >>> I have been informed that the flash layout should also be the same >>> for Alt (which currently does not have flash in its dts file in mainline). >>> Based on the renesas-devel-20141125-v3.18-rc6 tag of my renesas tree. >>> --- >>> arch/arm/boot/dts/r8a7791-koelsch.dts | 12 ++++++------ >>> 1 file changed, 6 insertions(+), 6 deletions(-) >>> diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts b/arch/arm/boot/dts/r8a7791-koelsch.dts >>> index 990af16..9a4e714 100644 >>> --- a/arch/arm/boot/dts/r8a7791-koelsch.dts >>> +++ b/arch/arm/boot/dts/r8a7791-koelsch.dts >>> @@ -451,14 +451,14 @@ >>> reg = <0x00000000 0x00080000>; >>> read-only; >>> }; >>> - partition@80000 { >>> - label = "bootenv"; >>> - reg = <0x00080000 0x00080000>; >>> + partition@40000 { >>> + label = "user"; >>> + reg = <0x00080000 0x00580000>; >> The "reg" prop doesn't match the pat of the name. > Are you suggesting this? > reg = <0x00080000 0x00600000>; No, I'm suggesting to change the part of the node name to match the offset in the "reg" property (given it's correct). [...] WBR, Sergei From mboxrd@z Thu Jan 1 00:00:00 1970 From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov) Date: Fri, 28 Nov 2014 14:09:02 +0300 Subject: [PATCH] ARM: shmobile: dts: koelsch: Fix flash partition label and size In-Reply-To: <20141128002718.GF30850@verge.net.au> References: <1416960805-15185-1-git-send-email-horms+renesas@verge.net.au> <5475CCA5.2020300@cogentembedded.com> <20141128002718.GF30850@verge.net.au> Message-ID: <547857CE.1090408@cogentembedded.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello. On 11/28/2014 3:27 AM, Simon Horman wrote: >>> Update the size and names of flash partitions to match the >>> expectations of the loader which are as follows: >>> "loader"---0x0000_0000-0x0008_0000 [loader program (readonly)] >>> "user" ---0x0008_0000-0x0060_0000 [U-Boot + bootargs + dt + uImage (readonly)] >>> "flash" ---0x0060_0000-0x0400_0000 [filesystem and free (read/write)] >>> ["user"'s assumed breakdown] >>> U-boot+ bootargs(0x0008_0000-0x0010_0000) 512KB >>> Device tree (0x0010_0000-0x0014_0000) 256KB >>> uImage (0x0014_0000-0x0060_0000) 4.75MB >>> Signed-off-by: Simon Horman >>> --- >>> This replaces a patch that I previously posted, "shmobile: koelsch: Fix >>> flash partition label and size in device tree", which has the same aim but >>> does so for an older version of the loader which to my knowledge is not >>> found in the wild. >>> I plan to post a similar patch for Lager if this one goes well. >>> I have been informed that the flash layout should also be the same >>> for Alt (which currently does not have flash in its dts file in mainline). >>> Based on the renesas-devel-20141125-v3.18-rc6 tag of my renesas tree. >>> --- >>> arch/arm/boot/dts/r8a7791-koelsch.dts | 12 ++++++------ >>> 1 file changed, 6 insertions(+), 6 deletions(-) >>> diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts b/arch/arm/boot/dts/r8a7791-koelsch.dts >>> index 990af16..9a4e714 100644 >>> --- a/arch/arm/boot/dts/r8a7791-koelsch.dts >>> +++ b/arch/arm/boot/dts/r8a7791-koelsch.dts >>> @@ -451,14 +451,14 @@ >>> reg = <0x00000000 0x00080000>; >>> read-only; >>> }; >>> - partition at 80000 { >>> - label = "bootenv"; >>> - reg = <0x00080000 0x00080000>; >>> + partition at 40000 { >>> + label = "user"; >>> + reg = <0x00080000 0x00580000>; >> The "reg" prop doesn't match the pat of the name. > Are you suggesting this? > reg = <0x00080000 0x00600000>; No, I'm suggesting to change the part of the node name to match the offset in the "reg" property (given it's correct). [...] WBR, Sergei