From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40758) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XuKvw-0005DJ-NZ for qemu-devel@nongnu.org; Fri, 28 Nov 2014 07:46:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XuKvn-0007c3-Kh for qemu-devel@nongnu.org; Fri, 28 Nov 2014 07:46:00 -0500 Received: from mx-v6.kamp.de ([2a02:248:0:51::16]:59732 helo=mx01.kamp.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XuKvn-0007bV-A8 for qemu-devel@nongnu.org; Fri, 28 Nov 2014 07:45:51 -0500 Message-ID: <54786E7A.4040105@kamp.de> Date: Fri, 28 Nov 2014 13:45:46 +0100 From: Peter Lieven MIME-Version: 1.0 References: <1417084026-12307-1-git-send-email-pl@kamp.de> <1417084026-12307-2-git-send-email-pl@kamp.de> <20141128124209.GI13631@stefanha-thinkpad.redhat.com> In-Reply-To: <20141128124209.GI13631@stefanha-thinkpad.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH 1/3] Revert "coroutine: make pool size dynamic" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: kwolf@redhat.com, famz@redhat.com, benoit@irqsave.net, ming.lei@canonical.com, armbru@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, pbonzini@redhat.com, mreitz@redhat.com Am 28.11.2014 um 13:42 schrieb Stefan Hajnoczi: > On Thu, Nov 27, 2014 at 11:27:04AM +0100, Peter Lieven wrote: >> This reverts commit ac2662a913ee5854b1269256adbdc14e57ba480a. > Justification? > > Won't we hit the same problem as the global pool: either pool size is > too large or too small. If you exceed the pool size performance drops > dramatically. Each thread has its own pool. But you can ignore this series I think. The idea Paolo came up with seems to be better. With my last improvement it seems to have equal performance without the drawback of different threads creating and destroying the coroutines. Peter