From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH for-4.5] xen/arm: Fix virtual timer on ARMv8 Model Date: Fri, 28 Nov 2014 12:48:46 +0000 Message-ID: <54786F2E.5070501@linaro.org> References: <1416937469-8162-1-git-send-email-julien.grall@linaro.org> <5477671C.4010500@linaro.org> <1417175252.23604.15.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XuKyi-0006E6-RX for xen-devel@lists.xenproject.org; Fri, 28 Nov 2014 12:48:52 +0000 Received: by mail-wi0-f179.google.com with SMTP id ex7so11128507wid.6 for ; Fri, 28 Nov 2014 04:48:51 -0800 (PST) In-Reply-To: <1417175252.23604.15.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, tim@xen.org, stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org Hi Ian, On 28/11/14 11:47, Ian Campbell wrote: > On Thu, 2014-11-27 at 18:02 +0000, Julien Grall wrote: >> state at the GIC level. This would also avoid masking the output signal >> and requires specific handling in the guest OS. > > "which requires"? > > It doesn't seem quite right to me otherwise, since context switching the > virq state *removes* the need to have the guest do anything other than > what it would do on native. I though the "avoid" would apply for both "masking" and "requires". > Assuming this is what you meant I propose (fixing some grammar etc as I > go): Thanks for the correction, I will use this version. Shall I put your signed-off-by? Regards, -- Julien Grall