From: Michal Marek <mmarek@suse.cz>
To: Eddie Kovsky <ewk@edkovsky.org>
Cc: "Yann E. MORIN" <yann.morin.1998@free.fr>,
linux-kbuild@vger.kernel.org, trivial@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kconfig: Fix compiler warning
Date: Fri, 28 Nov 2014 14:19:16 +0100 [thread overview]
Message-ID: <54787654.7020304@suse.cz> (raw)
In-Reply-To: <20141120054437.GA30162@athena>
On 2014-11-20 06:44, Eddie Kovsky wrote:
> diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c
> index a26cc5d2a9b0..a728d23949e7 100644
> --- a/scripts/kconfig/menu.c
> +++ b/scripts/kconfig/menu.c
> @@ -559,8 +559,8 @@ static void get_prompt_str(struct gstr *r, struct property *prop,
> if (location == NULL && accessible)
> location = menu;
> }
> + jump = xmalloc(sizeof(*jump));
> if (head && location) {
> - jump = xmalloc(sizeof(struct jump_key));
This creates a memory leak, because 'jump' is allocated, but not added
to the list, if the following condition is not met.
Michal
next prev parent reply other threads:[~2014-11-28 13:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-20 5:44 [PATCH] kconfig: Fix compiler warning Eddie Kovsky
2014-11-28 13:19 ` Michal Marek [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-06-26 6:13 Sascha Hauer
2014-06-26 9:02 ` Alexander Aring
2014-06-30 6:03 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54787654.7020304@suse.cz \
--to=mmarek@suse.cz \
--cc=ewk@edkovsky.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@kernel.org \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.