From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mailout4.w1.samsung.com ([210.118.77.14]:38571 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751162AbaK1N3v (ORCPT ); Fri, 28 Nov 2014 08:29:51 -0500 Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout4.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0NFR00FG14AAM7B0@mailout4.w1.samsung.com> for linux-media@vger.kernel.org; Fri, 28 Nov 2014 13:32:34 +0000 (GMT) Message-id: <547878CA.2040502@samsung.com> Date: Fri, 28 Nov 2014 14:29:46 +0100 From: Jacek Anaszewski MIME-version: 1.0 To: Sakari Ailus Cc: linux-media@vger.kernel.org, m.chehab@samsung.com, gjasny@googlemail.com, hdegoede@redhat.com, hans.verkuil@cisco.com, b.zolnierkie@samsung.com, kyungmin.park@samsung.com, sakari.ailus@linux.intel.com, laurent.pinchart@ideasonboard.com Subject: Re: [PATCH/RFC v4 11/11] Add a libv4l plugin for Exynos4 camera References: <1416586480-19982-1-git-send-email-j.anaszewski@samsung.com> <1416586480-19982-12-git-send-email-j.anaszewski@samsung.com> <20141127084129.GM8907@valkosipuli.retiisi.org.uk> In-reply-to: <20141127084129.GM8907@valkosipuli.retiisi.org.uk> Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Hi Sakari, Thanks for the review. On 11/27/2014 09:41 AM, Sakari Ailus wrote: > Hi Jacek, > > On Fri, Nov 21, 2014 at 05:14:40PM +0100, Jacek Anaszewski wrote: >> The plugin provides support for the media device on Exynos4 SoC. >> It performs single plane <-> multi plane API conversion, >> video pipeline linking and takes care of automatic data format >> negotiation for the whole pipeline, after intercepting >> VIDIOC_S_FMT or VIDIOC_TRY_FMT ioctls. >> >> Signed-off-by: Jacek Anaszewski >> Acked-by: Kyungmin Park >> --- >> configure.ac | 1 + >> lib/Makefile.am | 7 +- >> lib/libv4l-exynos4-camera/Makefile.am | 7 + >> lib/libv4l-exynos4-camera/libv4l-exynos4-camera.c | 595 +++++++++++++++++++++ >> 4 files changed, 609 insertions(+), 1 deletion(-) >> create mode 100644 lib/libv4l-exynos4-camera/Makefile.am >> create mode 100644 lib/libv4l-exynos4-camera/libv4l-exynos4-camera.c >> >> diff --git a/configure.ac b/configure.ac >> index c9b0524..ae653b9 100644 >> --- a/configure.ac >> +++ b/configure.ac >> @@ -17,6 +17,7 @@ AC_CONFIG_FILES([Makefile >> lib/libdvbv5/Makefile >> lib/libv4l2rds/Makefile >> lib/libv4l-mplane/Makefile >> + lib/libv4l-exynos4-camera/Makefile >> >> utils/Makefile >> utils/libv4l2util/Makefile >> diff --git a/lib/Makefile.am b/lib/Makefile.am >> index 3a0e19c..56b3a9f 100644 >> --- a/lib/Makefile.am >> +++ b/lib/Makefile.am >> @@ -5,7 +5,12 @@ SUBDIRS = \ >> libv4l2rds \ >> libv4l-mplane >> >> +if WITH_V4LUTILS >> +SUBDIRS += \ >> + libv4l-exynos4-camera >> +endif >> + >> if LINUX_OS >> SUBDIRS += \ >> libdvbv5 >> -endif >> \ No newline at end of file >> +endif >> diff --git a/lib/libv4l-exynos4-camera/Makefile.am b/lib/libv4l-exynos4-camera/Makefile.am >> new file mode 100644 >> index 0000000..23c60c6 >> --- /dev/null >> +++ b/lib/libv4l-exynos4-camera/Makefile.am >> @@ -0,0 +1,7 @@ >> +if WITH_V4L_PLUGINS >> +libv4l2plugin_LTLIBRARIES = libv4l-exynos4-camera.la >> +endif >> + >> +libv4l_exynos4_camera_la_SOURCES = libv4l-exynos4-camera.c ../../utils/media-ctl/libmediactl.c ../../utils/media-ctl/libv4l2subdev.c ../../utils/media-ctl/libv4l2media_ioctl.c ../../utils/media-ctl/mediatext.c >> +libv4l_exynos4_camera_la_CFLAGS = -fvisibility=hidden -std=gnu99 >> +libv4l_exynos4_camera_la_LDFLAGS = -avoid-version -module -shared -export-dynamic -lpthread >> diff --git a/lib/libv4l-exynos4-camera/libv4l-exynos4-camera.c b/lib/libv4l-exynos4-camera/libv4l-exynos4-camera.c >> new file mode 100644 >> index 0000000..119c75c >> --- /dev/null >> +++ b/lib/libv4l-exynos4-camera/libv4l-exynos4-camera.c >> @@ -0,0 +1,595 @@ >> +/* >> + * Copyright (c) 2014 Samsung Electronics Co., Ltd. >> + * http://www.samsung.com >> + * >> + * Author: Jacek Anaszewski >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU Lesser General Public License as published by >> + * the Free Software Foundation; either version 2.1 of the License, or >> + * (at your option) any later version. >> + * >> + * This program is distributed in the hope that it will be useful, >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU >> + * Lesser General Public License for more details. >> + */ >> + >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> + >> +#include >> +#include >> + >> +#include "../../utils/media-ctl/libv4l2media_ioctl.h" >> +#include "../../utils/media-ctl/mediactl.h" >> +#include "../../utils/media-ctl/mediatext.h" >> +#include "../../utils/media-ctl/v4l2subdev.h" >> +#include "libv4l-plugin.h" >> + >> +struct media_device; >> +struct media_entity; >> + >> +/* >> + * struct exynos4_camera_plugin - libv4l exynos4 camera plugin >> + * @media: media device comprising the vid_fd related video device >> + */ >> +struct exynos4_camera_plugin { >> + struct media_device *media; >> +}; >> + >> +#ifdef DEBUG >> +#define V4L2_EXYNOS4_DBG(format, ARG...)\ >> + printf("[%s:%d] [%s] " format " \n", __FILE__, __LINE__, __func__, ##ARG) >> +#else >> +#define V4L2_EXYNOS4_DBG(format, ARG...) >> +#endif >> + >> +#define V4L2_EXYNOS4_ERR(format, ARG...)\ >> + fprintf(stderr, "Libv4l Exynos4 camera plugin: "format "\n", ##ARG) >> + >> +#define V4L2_EXYNOS4_LOG(format, ARG...)\ >> + fprintf(stdout, "Libv4l Exynos4 camera plugin: "format "\n", ##ARG) >> + >> +#if HAVE_VISIBILITY >> +#define PLUGIN_PUBLIC __attribute__ ((visibility("default"))) >> +#else >> +#define PLUGIN_PUBLIC >> +#endif >> + >> +#define SYS_IOCTL(fd, cmd, arg) \ >> + syscall(SYS_ioctl, (int)(fd), (unsigned long)(cmd), (void *)(arg)) >> +#define SIMPLE_CONVERT_IOCTL(fd, cmd, arg, __struc) ({ \ >> + int __ret; \ >> + struct __struc *req = arg; \ >> + uint32_t type = req->type; \ >> + req->type = convert_type(type); \ >> + __ret = SYS_IOCTL(fd, cmd, arg); \ >> + req->type = type; \ >> + __ret; \ >> + }) >> + >> +#define EXYNOS4_FIMC_DRV "exynos4-fimc" >> +#define EXYNOS4_FIMC_LITE_DRV "exynos-fimc-lit" >> +#define EXYNOS4_FIMC_IS_ISP_DRV "exynos4-fimc-is" >> +#define ENTITY_CAPTURE_SEGMENT "capture" >> +#define EXYNOS4_CAPTURE_CONF "/var/lib/libv4l/exynos4_capture_conf" > > If you have a different sensor, such as one using the smiapp driver, would > you still have the same configuration file? Just wondering whether this > should be under /etc or not. But this is a minor detail in any case. Sensor entity name is used for ctrl-to-subdev-conf in case a v4l2 control related ioctls are to be redirected to it. In such a case the entity name would have to be changed. >> +#define EXYNOS4_FIMC_IS_ISP "FIMC-IS-ISP" >> +#define EXYNOS4_FIMC_PREFIX "FIMC." >> +#define MAX_FMT_NEGO_NUM 50 >> + >> + >> +static int __capture_entity(const char *name) >> +{ >> + int cap_segment_pos; >> + >> + if (name == NULL) >> + return 0; >> + >> + cap_segment_pos = strlen(name) - strlen(ENTITY_CAPTURE_SEGMENT); >> + >> + if (strcmp(name + cap_segment_pos, ENTITY_CAPTURE_SEGMENT) == 0) >> + return 1; >> + >> + return 0; >> +} >> + >> +static int __adjust_format_to_fimc_is_isp(struct v4l2_mbus_framefmt *mbus_fmt) >> +{ >> + if (mbus_fmt == NULL) >> + return -EINVAL; >> + >> + mbus_fmt->width += 16; >> + mbus_fmt->height += 12; >> + >> + return 0; >> +} >> + >> +static int negotiate_pipeline_fmt(struct media_entity *pipeline, >> + struct v4l2_format *dev_fmt) >> +{ >> + struct media_entity *entity = pipeline; >> + struct v4l2_subdev_format subdev_fmt = { 0 }; >> + struct v4l2_mbus_framefmt mbus_fmt = { 0 }, common_fmt; >> + int repeat_negotiation, cnt_negotiation = 0, ret, pad_id; >> + >> + if (pipeline == NULL || dev_fmt == NULL) >> + return -EINVAL; >> + >> + mbus_fmt.width = dev_fmt->fmt.pix_mp.width; >> + mbus_fmt.height = dev_fmt->fmt.pix_mp.height; >> + mbus_fmt.field = dev_fmt->fmt.pix_mp.field; >> + mbus_fmt.colorspace = dev_fmt->fmt.pix_mp.colorspace; >> + >> + if (media_has_pipeline_entity(entity, EXYNOS4_FIMC_IS_ISP)) { >> + ret = __adjust_format_to_fimc_is_isp(&mbus_fmt); >> + if (ret < 0) >> + return ret; >> + } >> + >> + V4L2_EXYNOS4_DBG("Begin pipeline format negotiation..."); >> + >> + for (;;) { >> + repeat_negotiation = 0; >> + entity = pipeline; >> + >> + pad_id = media_entity_get_src_pad_index(entity); >> + >> + V4L2_EXYNOS4_DBG("Setting format on entity %s, pad: %d", >> + media_entity_get_name(entity), pad_id); >> + >> + ret = v4l2_subdev_set_format(entity, &mbus_fmt, >> + pad_id, V4L2_SUBDEV_FORMAT_TRY); >> + if (ret < 0) >> + return ret; >> + >> + common_fmt = mbus_fmt; >> + >> + entity = media_entity_get_next(entity); >> + >> + while (entity) { >> + pad_id = media_entity_get_sink_pad_index(entity); >> + >> + /* Set format on the entity src pad */ >> + V4L2_EXYNOS4_DBG("Setting format on the entity pad %s:%d: mbus_code: %s, width: %d, height: %d", >> + media_entity_get_name(entity), pad_id, >> + v4l2_subdev_pixelcode_to_string(mbus_fmt.code), >> + mbus_fmt.width, mbus_fmt.height); >> + >> + ret = v4l2_subdev_set_format(entity, &mbus_fmt, pad_id, >> + V4L2_SUBDEV_FORMAT_TRY); >> + if (ret < 0) >> + return ret; >> + >> + if (!v4l2_subdev_format_compare(&mbus_fmt, &common_fmt)) { >> + repeat_negotiation = 1; >> + break; >> + } >> + >> + /* >> + * Do not check format on FIMC.[n] source pad >> + * and stop negotiation. >> + */ >> + if (!strncmp(media_entity_get_name(entity), >> + EXYNOS4_FIMC_PREFIX, >> + strlen(EXYNOS4_FIMC_PREFIX))) >> + break; >> + >> + pad_id = media_entity_get_src_pad_index(entity); >> + >> + /* Get format on the entity sink pad */ >> + ret = v4l2_subdev_get_format(entity, &mbus_fmt, pad_id, >> + V4L2_SUBDEV_FORMAT_TRY); >> + if (ret < 0) >> + return -EINVAL; >> + >> + V4L2_EXYNOS4_DBG("Format propagated to the entity pad %s:%d: mbus_code: %s, width: %d, height: %d", >> + media_entity_get_name(entity), pad_id, >> + v4l2_subdev_pixelcode_to_string(mbus_fmt.code), >> + mbus_fmt.width, mbus_fmt.height); >> + >> + if (!strcmp(media_entity_get_name(entity), >> + EXYNOS4_FIMC_IS_ISP)) { >> + common_fmt.code = subdev_fmt.format.code; >> + common_fmt.colorspace = >> + subdev_fmt.format.colorspace; >> + common_fmt.width -= 16; >> + common_fmt.height -= 12; >> + } >> + >> + if (!v4l2_subdev_format_compare(&mbus_fmt, &common_fmt)) { >> + repeat_negotiation = 1; >> + break; >> + } >> + >> + entity = media_entity_get_next(entity); >> + >> + /* >> + * Stop if this is last element in the >> + * pipeline as it is not a sub-device. >> + */ >> + if (media_entity_get_next(entity) == NULL) >> + break; >> + } >> + >> + if (!repeat_negotiation) { >> + break; >> + } else if (++cnt_negotiation > MAX_FMT_NEGO_NUM) { >> + V4L2_EXYNOS4_DBG("Pipeline format negotiation failed!"); >> + return -EINVAL; >> + } >> + } >> + >> + dev_fmt->fmt.pix_mp.width = mbus_fmt.width; >> + dev_fmt->fmt.pix_mp.height = mbus_fmt.height; >> + dev_fmt->fmt.pix_mp.field = mbus_fmt.field; >> + dev_fmt->fmt.pix_mp.colorspace = mbus_fmt.colorspace; >> + >> + V4L2_EXYNOS4_DBG("Pipeline format successfuly negotiated"); >> + >> + return 0; >> +} >> + >> +static int convert_type(int type) > > How about __u32 instead? OK. >> +{ >> + switch (type) { >> + case V4L2_BUF_TYPE_VIDEO_CAPTURE: >> + return V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE; >> + default: >> + return type; >> + } >> +} >> + >> +static int set_fmt_ioctl(struct media_device *media, >> + unsigned long int cmd, >> + struct v4l2_format *arg, >> + enum v4l2_subdev_format_whence set_mode) >> +{ >> + struct v4l2_format fmt = { 0 }; >> + struct v4l2_format *org = arg; > > You never change org, why a new local variable? I do change it in the last condition in the function. I followed a convention from the libv4l-mplane.c >> + int ret; >> + >> + fmt.type = convert_type(arg->type); >> + if (fmt.type != arg->type) { >> + fmt.fmt.pix_mp.width = org->fmt.pix.width; >> + fmt.fmt.pix_mp.height = org->fmt.pix.height; >> + fmt.fmt.pix_mp.pixelformat = org->fmt.pix.pixelformat; >> + fmt.fmt.pix_mp.field = org->fmt.pix.field; >> + fmt.fmt.pix_mp.colorspace = org->fmt.pix.colorspace; >> + fmt.fmt.pix_mp.num_planes = 1; >> + fmt.fmt.pix_mp.flags = org->fmt.pix.flags; >> + fmt.fmt.pix_mp.plane_fmt[0].bytesperline = org->fmt.pix.bytesperline; >> + fmt.fmt.pix_mp.plane_fmt[0].sizeimage = org->fmt.pix.sizeimage; >> + } else { >> + fmt = *org; >> + } >> + >> + ret = negotiate_pipeline_fmt(media_get_pipeline(media), &fmt); >> + if (ret < 0) >> + return ret; >> + >> + if (set_mode == V4L2_SUBDEV_FORMAT_ACTIVE) { >> + ret = v4l2_subdev_apply_pipeline_fmt(media, &fmt); >> + if (ret < 0) >> + return ret; >> + } >> + >> + if (fmt.type != arg->type) { >> + org->fmt.pix.width = fmt.fmt.pix_mp.width; >> + org->fmt.pix.height = fmt.fmt.pix_mp.height; >> + org->fmt.pix.pixelformat = fmt.fmt.pix_mp.pixelformat; >> + org->fmt.pix.field = fmt.fmt.pix_mp.field; >> + org->fmt.pix.colorspace = fmt.fmt.pix_mp.colorspace; >> + org->fmt.pix.bytesperline = fmt.fmt.pix_mp.plane_fmt[0].bytesperline; >> + org->fmt.pix.sizeimage = fmt.fmt.pix_mp.plane_fmt[0].sizeimage; >> + org->fmt.pix.flags = fmt.fmt.pix_mp.flags; >> + } else { >> + *org = fmt; >> + } >> + >> + return 0; >> +} >> + >> +static int get_fmt_ioctl(int fd, >> + unsigned long int cmd, >> + struct v4l2_format *arg) >> +{ >> + struct v4l2_format fmt = { 0 }; >> + struct v4l2_format *org = arg; >> + int ret; >> + >> + fmt.type = convert_type(arg->type); >> + >> + if (fmt.type == arg->type) >> + return SYS_IOCTL(fd, cmd, arg); >> + >> + ret = SYS_IOCTL(fd, cmd, &fmt); >> + if (ret < 0) >> + return ret; >> + >> + memset(&org->fmt.pix, 0, sizeof(org->fmt.pix)); >> + org->fmt.pix.width = fmt.fmt.pix_mp.width; >> + org->fmt.pix.height = fmt.fmt.pix_mp.height; >> + org->fmt.pix.pixelformat = fmt.fmt.pix_mp.pixelformat; >> + org->fmt.pix.field = fmt.fmt.pix_mp.field; >> + org->fmt.pix.colorspace = fmt.fmt.pix_mp.colorspace; >> + org->fmt.pix.bytesperline = fmt.fmt.pix_mp.plane_fmt[0].bytesperline; >> + org->fmt.pix.sizeimage = fmt.fmt.pix_mp.plane_fmt[0].sizeimage; >> + org->fmt.pix.priv = V4L2_PIX_FMT_PRIV_MAGIC; > > What's this is for? Hmm, I copied this part of code from libv4l-mplane.c and forgot :-/ The last line is to be removed. >> + org->fmt.pix.flags = fmt.fmt.pix_mp.flags; >> + >> + /* >> + * If the device doesn't support just one plane, there's >> + * nothing we can do, except return an error condition. >> + */ >> + if (fmt.fmt.pix_mp.num_planes > 1) { > > Wouldn't you notice this right after the IOCTL? > > What's the reason btw. to support only single-plane formats? I copied it too, but it doesn't fit for this plugin. Thanks for spotting this. >> + errno = EINVAL; >> + return -1; >> + } >> + >> + >> + return ret; >> +} >> + >> +static int buf_ioctl(int fd, >> + unsigned long int cmd, >> + struct v4l2_buffer *arg) >> +{ >> + struct v4l2_buffer buf = *arg; >> + struct v4l2_plane plane = { 0 }; >> + int ret; >> + >> + buf.type = convert_type(arg->type); >> + >> + if (buf.type == arg->type) >> + return SYS_IOCTL(fd, cmd, arg); >> + >> + memcpy(&plane.m, &arg->m, sizeof(plane.m)); >> + plane.length = arg->length; >> + plane.bytesused = arg->bytesused; >> + >> + buf.m.planes = &plane; >> + buf.length = 1; >> + >> + ret = SYS_IOCTL(fd, cmd, &buf); >> + >> + arg->index = buf.index; >> + arg->memory = buf.memory; >> + arg->flags = buf.flags; >> + arg->field = buf.field; >> + arg->timestamp = buf.timestamp; >> + arg->timecode = buf.timecode; >> + arg->sequence = buf.sequence; >> + >> + arg->length = plane.length; >> + arg->bytesused = plane.bytesused; >> + memcpy(&arg->m, &plane.m, sizeof(arg->m)); >> + >> + return ret; >> +} >> + >> +static int querycap_ioctl(int fd, struct v4l2_capability *arg) >> +{ >> + int ret; >> + >> + ret = SYS_IOCTL(fd, VIDIOC_QUERYCAP, arg); >> + if (ret < 0) >> + return ret; >> + >> + arg->device_caps |= V4L2_CAP_VIDEO_CAPTURE; >> + arg->capabilities |= V4L2_CAP_VIDEO_CAPTURE; >> + >> + return ret; >> +} >> + >> +static void *plugin_init(int fd) >> +{ >> + struct v4l2_capability cap; >> + struct exynos4_camera_plugin *plugin = NULL; >> + const char *sink_entity_name; >> + struct media_device *media; >> + struct media_entity *sink_entity; >> + char video_devname[32]; >> + int ret; >> + >> + V4L2_EXYNOS4_ERR("fd: %d\n", fd); >> + >> + memset(&plugin, 0, sizeof(plugin)); > > This is an interesting way to set a pointer's value to NULL. But I think > it's redundant. You're right. This is a stray code - it made sense in the older versions when the plugin variable was static. >> + memset(&cap, 0, sizeof(cap)); > > You could use cap = { 0 } in declaration. OK. >> + ret = SYS_IOCTL(fd, VIDIOC_QUERYCAP, &cap); >> + if (ret < 0) { >> + V4L2_EXYNOS4_ERR("Failed to query video capabilities."); >> + return NULL; >> + } >> + >> + /* Check if this is Exynos4 media device */ >> + if (strcmp((char *) cap.driver, EXYNOS4_FIMC_DRV) && >> + strcmp((char *) cap.driver, EXYNOS4_FIMC_LITE_DRV) && >> + strcmp((char *) cap.driver, EXYNOS4_FIMC_IS_ISP_DRV)) { >> + V4L2_EXYNOS4_ERR("Not an Exynos4 media device."); >> + return NULL; >> + } >> + >> + /* Obtain the node name of the opened device */ >> + ret = media_get_devname_by_fd(fd, video_devname); >> + if (ret < 0) { >> + V4L2_EXYNOS4_ERR("Failed to get video device node name."); >> + return NULL; >> + } >> + >> + /* >> + * Create the representation of a media device >> + * containing the opened video device. >> + */ >> + media = media_device_new_by_entity_devname(video_devname); >> + if (media == NULL) { >> + V4L2_EXYNOS4_ERR("Failed to create media device."); >> + return NULL; >> + } >> + >> +#ifdef DEBUG >> + media_debug_set_handler(media, (void (*)(void *, ...))fprintf, stdout); >> +#endif >> + >> + /* Get the entity representing the opened video device node */ >> + sink_entity = media_get_entity_by_devname(media, video_devname, strlen(video_devname)); > > Could you use the fd directly instead of translating that to the device > node? fstat(2) gives you directly inode / device major + minor which you can > then use to find the MC device. OK. >> + if (sink_entity == NULL) { >> + V4L2_EXYNOS4_ERR("Failed to get sinkd entity name."); >> + goto err_get_sink_entity; >> + } >> + >> + /* The last entity in the pipeline represents video device node */ >> + media_entity_set_fd(sink_entity, fd); >> + >> + sink_entity_name = media_entity_get_name(sink_entity); >> + >> + /* Check if video entity is of capture type, not m2m */ >> + if (!__capture_entity(sink_entity_name)) { >> + V4L2_EXYNOS4_ERR("Device not of capture type."); >> + goto err_get_sink_entity; >> + } >> + >> + /* Parse media configuration file and apply its settings */ >> + ret = mediatext_parse_setup_config(media, EXYNOS4_CAPTURE_CONF); >> + if (ret < 0) { >> + V4L2_EXYNOS4_ERR("Media config parser error."); >> + goto err_get_sink_entity; >> + } >> + >> + /* >> + * Discover the pipeline of sub-devices from a camera sensor >> + * to the opened video device. >> + */ >> + ret = media_discover_pipeline_by_entity(media, sink_entity); >> + if (ret < 0) { >> + V4L2_EXYNOS4_ERR("Error discovering video pipeline."); >> + goto err_get_sink_entity; >> + } >> + >> + /* Open all sub-devices in the discovered pipeline */ >> + ret = media_open_pipeline_subdevs(media); >> + if (ret < 0) { >> + V4L2_EXYNOS4_ERR("Error opening video pipeline."); >> + goto err_get_sink_entity; >> + } >> + >> + /* Allocate private data */ >> + plugin = calloc(1, sizeof(*plugin)); >> + if (!plugin) >> + goto err_validate_controls; >> + >> + plugin->media = media; >> + >> + V4L2_EXYNOS4_LOG("Initialized exynos4-camera plugin."); >> + >> + return plugin; >> + >> +err_validate_controls: >> + media_close_pipeline_subdevs(media); >> +err_get_sink_entity: >> + if (media) >> + media_device_unref(media); >> + return NULL; >> +} >> + >> +static void plugin_close(void *dev_ops_priv) >> +{ >> + struct exynos4_camera_plugin *plugin; >> + struct media_device *media; >> + >> + if (dev_ops_priv == NULL) >> + return; >> + >> + plugin = (struct exynos4_camera_plugin *) dev_ops_priv; > > You don't need to cast a void pointer to another pointer. You could also > make the assignment in variable declaration. Good point, thanks. Best Regards, Jacek Anaszewski