From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751500AbaK1X3C (ORCPT ); Fri, 28 Nov 2014 18:29:02 -0500 Received: from mail-oi0-f47.google.com ([209.85.218.47]:41427 "EHLO mail-oi0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751256AbaK1X3A (ORCPT ); Fri, 28 Nov 2014 18:29:00 -0500 Message-ID: <54790537.809@gmail.com> Date: Fri, 28 Nov 2014 15:28:55 -0800 From: Florian Fainelli User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Sudip Mukherjee , Hisashi T Fujinaka CC: Jeff Kirsher , Jesse Brandeburg , Bruce Allan , Carolyn Wyborny , Don Skidmore , Greg Rose , Matthew Vick , John Ronciak , Mitch Williams , Linux NICS , e1000-devel@lists.sourceforge.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] e1000: remove unused variables References: <1417065728-5592-1-git-send-email-sudipm.mukherjee@gmail.com> <20141127130725.GA12406@sudip-PC> In-Reply-To: <20141127130725.GA12406@sudip-PC> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 27/11/2014 05:07, Sudip Mukherjee a écrit : > On Wed, Nov 26, 2014 at 09:59:28PM -0800, Hisashi T Fujinaka wrote: >> I'm pretty sure those double reads are there for a reason, so most of >> this I'm going to have to check on Monday. We have a long holiday >> weekend here in the US. > > if the double reads are there for some reason, can you please let me know what that reason might be.. Could be latching, especially in the context of reading from Ethernet PHYs, some registers are latched, so you may have to do a double read to ensure the value you get is consistent. Also, if you do a read that is not stored in any return value, the compiler is now free to remove that actual read, and that may have other side effects for registers which are e.g: read to clear, or any of the like. > >> >> I'm not sure why you're bothering with an old driver like this, but if >> you haven't actually tried this on all the hardware it pertains to, I'm >> going want to NAK this. > > no it has not been tested on hardware. :( > > i am still in the learning process, NAK is also part of learning. > > infact there is another part of the code, which, theoretically, will never get executed. but i didnot dare to send that removal patch without testing on the hardware. > > thanks > sudip > >> >> I should do this from my todd.fujinaka@intel.com account but it's 10PM >> on the first day of a long holiday weekend. >> >> On Thu, 27 Nov 2014, Sudip Mukherjee wrote: >> >>> these variables were only being assigned some values, but were never >>> used. >>> >>> Signed-off-by: Sudip Mukherjee >>> --- >>> drivers/net/ethernet/intel/e1000/e1000_hw.c | 142 ++++++++++++-------------- > >>> case SPEED_100: >>> - txb2b = false; >>> /* maybe add some timeout factor ? */ >>> break; >>> } >>> >> >> -- >> Hisashi T Fujinaka - htodd@twofifty.com >> BSEE + BSChem + BAEnglish + MSCS + $2.50 = coffee > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH] e1000: remove unused variables Date: Fri, 28 Nov 2014 15:28:55 -0800 Message-ID: <54790537.809@gmail.com> References: <1417065728-5592-1-git-send-email-sudipm.mukherjee@gmail.com> <20141127130725.GA12406@sudip-PC> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: Linux NICS , e1000-devel@lists.sourceforge.net, Bruce Allan , Jesse Brandeburg , linux-kernel@vger.kernel.org, John Ronciak , netdev@vger.kernel.org To: Sudip Mukherjee , Hisashi T Fujinaka Return-path: In-Reply-To: <20141127130725.GA12406@sudip-PC> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: e1000-devel-bounces@lists.sourceforge.net List-Id: netdev.vger.kernel.org TGUgMjcvMTEvMjAxNCAwNTowNywgU3VkaXAgTXVraGVyamVlIGEgw6ljcml0IDoKPiBPbiBXZWQs IE5vdiAyNiwgMjAxNCBhdCAwOTo1OToyOFBNIC0wODAwLCBIaXNhc2hpIFQgRnVqaW5ha2Egd3Jv dGU6Cj4+IEknbSBwcmV0dHkgc3VyZSB0aG9zZSBkb3VibGUgcmVhZHMgYXJlIHRoZXJlIGZvciBh IHJlYXNvbiwgc28gbW9zdCBvZgo+PiB0aGlzIEknbSBnb2luZyB0byBoYXZlIHRvIGNoZWNrIG9u IE1vbmRheS4gV2UgaGF2ZSBhIGxvbmcgaG9saWRheQo+PiB3ZWVrZW5kIGhlcmUgaW4gdGhlIFVT Lgo+IAo+IGlmIHRoZSBkb3VibGUgcmVhZHMgYXJlIHRoZXJlIGZvciBzb21lIHJlYXNvbiwgY2Fu IHlvdSBwbGVhc2UgbGV0IG1lIGtub3cgd2hhdCB0aGF0IHJlYXNvbiBtaWdodCBiZS4uCgpDb3Vs ZCBiZSBsYXRjaGluZywgZXNwZWNpYWxseSBpbiB0aGUgY29udGV4dCBvZiByZWFkaW5nIGZyb20g RXRoZXJuZXQKUEhZcywgc29tZSByZWdpc3RlcnMgYXJlIGxhdGNoZWQsIHNvIHlvdSBtYXkgaGF2 ZSB0byBkbyBhIGRvdWJsZSByZWFkIHRvCmVuc3VyZSB0aGUgdmFsdWUgeW91IGdldCBpcyBjb25z aXN0ZW50LgoKQWxzbywgaWYgeW91IGRvIGEgcmVhZCB0aGF0IGlzIG5vdCBzdG9yZWQgaW4gYW55 IHJldHVybiB2YWx1ZSwgdGhlCmNvbXBpbGVyIGlzIG5vdyBmcmVlIHRvIHJlbW92ZSB0aGF0IGFj dHVhbCByZWFkLCBhbmQgdGhhdCBtYXkgaGF2ZSBvdGhlcgpzaWRlIGVmZmVjdHMgZm9yIHJlZ2lz dGVycyB3aGljaCBhcmUgZS5nOiByZWFkIHRvIGNsZWFyLCBvciBhbnkgb2YgdGhlIGxpa2UuCgo+ IAo+Pgo+PiBJJ20gbm90IHN1cmUgd2h5IHlvdSdyZSBib3RoZXJpbmcgd2l0aCBhbiBvbGQgZHJp dmVyIGxpa2UgdGhpcywgYnV0IGlmCj4+IHlvdSBoYXZlbid0IGFjdHVhbGx5IHRyaWVkIHRoaXMg b24gYWxsIHRoZSBoYXJkd2FyZSBpdCBwZXJ0YWlucyB0bywgSSdtCj4+IGdvaW5nIHdhbnQgdG8g TkFLIHRoaXMuCj4gCj4gbm8gaXQgaGFzIG5vdCBiZWVuIHRlc3RlZCBvbiBoYXJkd2FyZS4gIDoo Cj4gCj4gaSBhbSBzdGlsbCBpbiB0aGUgbGVhcm5pbmcgcHJvY2VzcywgTkFLIGlzIGFsc28gcGFy dCBvZiBsZWFybmluZy4KPiAKPiBpbmZhY3QgdGhlcmUgaXMgYW5vdGhlciBwYXJ0IG9mIHRoZSBj b2RlLCB3aGljaCwgdGhlb3JldGljYWxseSwgd2lsbCBuZXZlciBnZXQgZXhlY3V0ZWQuIGJ1dCBp IGRpZG5vdCBkYXJlIHRvIHNlbmQgdGhhdCByZW1vdmFsIHBhdGNoIHdpdGhvdXQgdGVzdGluZyBv biB0aGUgaGFyZHdhcmUuCj4gCj4gdGhhbmtzCj4gc3VkaXAKPiAKPj4KPj4gSSBzaG91bGQgZG8g dGhpcyBmcm9tIG15IHRvZGQuZnVqaW5ha2FAaW50ZWwuY29tIGFjY291bnQgYnV0IGl0J3MgMTBQ TQo+PiBvbiB0aGUgZmlyc3QgZGF5IG9mIGEgbG9uZyBob2xpZGF5IHdlZWtlbmQuCj4+Cj4+IE9u IFRodSwgMjcgTm92IDIwMTQsIFN1ZGlwIE11a2hlcmplZSB3cm90ZToKPj4KPj4+IHRoZXNlIHZh cmlhYmxlcyB3ZXJlIG9ubHkgYmVpbmcgYXNzaWduZWQgc29tZSB2YWx1ZXMsIGJ1dCB3ZXJlIG5l dmVyCj4+PiB1c2VkLgo+Pj4KPj4+IFNpZ25lZC1vZmYtYnk6IFN1ZGlwIE11a2hlcmplZSA8c3Vk aXBAdmVjdG9yaW5kaWEub3JnPgo+Pj4gLS0tCj4+PiBkcml2ZXJzL25ldC9ldGhlcm5ldC9pbnRl bC9lMTAwMC9lMTAwMF9ody5jICAgfCAxNDIgKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0KPiA8 c25pcD4KPj4+IAkJCWNhc2UgU1BFRURfMTAwOgo+Pj4gLQkJCQl0eGIyYiA9IGZhbHNlOwo+Pj4g CQkJCS8qIG1heWJlIGFkZCBzb21lIHRpbWVvdXQgZmFjdG9yID8gKi8KPj4+IAkJCQlicmVhazsK Pj4+IAkJCX0KPj4+Cj4+Cj4+IC0tIAo+PiBIaXNhc2hpIFQgRnVqaW5ha2EgLSBodG9kZEB0d29m aWZ0eS5jb20KPj4gQlNFRSArIEJTQ2hlbSArIEJBRW5nbGlzaCArIE1TQ1MgKyAkMi41MCA9IGNv ZmZlZQo+IC0tCj4gVG8gdW5zdWJzY3JpYmUgZnJvbSB0aGlzIGxpc3Q6IHNlbmQgdGhlIGxpbmUg InVuc3Vic2NyaWJlIG5ldGRldiIgaW4KPiB0aGUgYm9keSBvZiBhIG1lc3NhZ2UgdG8gbWFqb3Jk b21vQHZnZXIua2VybmVsLm9yZwo+IE1vcmUgbWFqb3Jkb21vIGluZm8gYXQgIGh0dHA6Ly92Z2Vy Lmtlcm5lbC5vcmcvbWFqb3Jkb21vLWluZm8uaHRtbAo+IAoKCi0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LQpEb3dubG9hZCBCSVJUIGlIdWIgRi1UeXBlIC0gVGhlIEZyZWUgRW50ZXJwcmlzZS1HcmFkZSBC SVJUIFNlcnZlcgpmcm9tIEFjdHVhdGUhIEluc3RhbnRseSBTdXBlcmNoYXJnZSBZb3VyIEJ1c2lu ZXNzIFJlcG9ydHMgYW5kIERhc2hib2FyZHMKd2l0aCBJbnRlcmFjdGl2aXR5LCBTaGFyaW5nLCBO YXRpdmUgRXhjZWwgRXhwb3J0cywgQXBwIEludGVncmF0aW9uICYgbW9yZQpHZXQgdGVjaG5vbG9n eSBwcmV2aW91c2x5IHJlc2VydmVkIGZvciBiaWxsaW9uLWRvbGxhciBjb3Jwb3JhdGlvbnMsIEZS RUUKaHR0cDovL3B1YmFkcy5nLmRvdWJsZWNsaWNrLm5ldC9nYW1wYWQvY2xrP2lkPTE1NzAwNTc1 MSZpdT0vNDE0MC9vc3RnLmNsa3RyawpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpFMTAwMC1kZXZlbCBtYWlsaW5nIGxpc3QKRTEwMDAtZGV2ZWxAbGlzdHMu c291cmNlZm9yZ2UubmV0Cmh0dHBzOi8vbGlzdHMuc291cmNlZm9yZ2UubmV0L2xpc3RzL2xpc3Rp bmZvL2UxMDAwLWRldmVsClRvIGxlYXJuIG1vcmUgYWJvdXQgSW50ZWwmIzE3NDsgRXRoZXJuZXQs IHZpc2l0IGh0dHA6Ly9jb21tdW5pdGllcy5pbnRlbC5jb20vY29tbXVuaXR5L3dpcmVkCg==