All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hayes Wang <hayeswang@realtek.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: syzbot <syzbot+95afd23673f5dd295c57@syzkaller.appspotmail.com>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"kuba@kernel.org" <kuba@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"syzkaller-bugs@googlegroups.com"
	<syzkaller-bugs@googlegroups.com>,
	nic_swsd <nic_swsd@realtek.com>
Subject: RE: [syzbot] WARNING in rtl8152_probe
Date: Mon, 17 May 2021 01:01:28 +0000	[thread overview]
Message-ID: <547984d34f58406aa2e37861d7e8a44d@realtek.com> (raw)
In-Reply-To: <20210514153253.GA1007561@rowland.harvard.edu>

Alan Stern <stern@rowland.harvard.edu>
> Sent: Friday, May 14, 2021 11:33 PM
[...]
> The real motivation here, which nobody has mentioned explicitly yet, is
> that the driver needs to be careful enough that it won't crash no matter
> what bizarre, malfunctioning, or malicious device is attached.
> 
> Even if a device isn't malicious, if it is buggy, broken, or
> malfunctioning in some way then it can present input that a normal
> device would never generate.  If the driver isn't prepared to handle
> this unusual input, it may crash.  That is specifically what we want to
> avoid.
> 
> So if a peculiar emulated device created by syzbot is capable of
> crashing the driver, then somewhere there is a bug which needs to be
> fixed.  It's true that fixing all these bugs might not protect against a
> malicious device which deliberately behaves in an apparently reasonable
> manner.  But it does reduce the attack surface.

Thanks for your response.
I will add some checks.

Best Regards,
Hayes


  reply	other threads:[~2021-05-17  1:01 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-12  9:40 [syzbot] WARNING in rtl8152_probe syzbot
2021-05-13  3:13 ` Hayes Wang
2021-05-13 14:25   ` Alan Stern
2021-05-14  2:58     ` Hayes Wang
2021-05-14  6:41       ` Dan Carpenter
2021-05-14  7:49         ` Hayes Wang
2021-05-14  6:48       ` Greg KH
2021-05-14  7:50         ` Hayes Wang
2021-05-14  8:26           ` Greg KH
2021-05-14 10:32             ` Hayes Wang
2021-05-14 15:32           ` Alan Stern
2021-05-17  1:01             ` Hayes Wang [this message]
2021-05-17 10:00               ` Oliver Neukum
2021-05-17 13:47                 ` Alan Stern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=547984d34f58406aa2e37861d7e8a44d@realtek.com \
    --to=hayeswang@realtek.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nic_swsd@realtek.com \
    --cc=stern@rowland.harvard.edu \
    --cc=syzbot+95afd23673f5dd295c57@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.