From: Lino Sanfilippo <LinoSanfilippo@gmx.de>
To: Jiri Pirko <jiri@resnulli.us>, netdev@vger.kernel.org
Cc: davem@davemloft.net, nhorman@tuxdriver.com, andy@greyhouse.net,
tgraf@suug.ch, dborkman@redhat.com, ogerlitz@mellanox.com,
jesse@nicira.com, pshelar@nicira.com, azhou@nicira.com,
ben@decadent.org.uk, stephen@networkplumber.org,
jeffrey.t.kirsher@intel.com, vyasevic@redhat.com,
xiyou.wangcong@gmail.com, john.r.fastabend@intel.com,
edumazet@google.com, jhs@mojatatu.com, sfeldma@gmail.com,
f.fainelli@gmail.com, roopa@cumulusnetworks.com,
linville@tuxdriver.com, jasowang@redhat.com,
ebiederm@xmission.com, nicolas.dichtel@6wind.com,
ryazanov.s.a@gmail.com, buytenh@wantstofly.org,
aviadr@mellanox.com, nbd@openwrt.org,
alexei.starovoitov@gmail.com, Neil.Jerram@metaswitch.com,
ronye@mellanox.com, simon.horman@netronome.com,
alexander.h.duyck@redhat.com, john.ronciak@intel.com,
mleitner@redhat.com, shrijeet@gmail.com,
gospo@cumulusnetworks.com, bcrl@kvack.org, hemal@broadcom.co
Subject: Re: [patch net-next v5 06/21] net: introduce generic switch devices support
Date: Sat, 29 Nov 2014 10:31:39 +0100 [thread overview]
Message-ID: <5479927B.4020807@gmx.de> (raw)
In-Reply-To: <1417181672-11531-7-git-send-email-jiri@resnulli.us>
Hi,
On 28.11.2014 14:34, Jiri Pirko wrote:
> +
> + ndo_switch_parent_id_get - This returns the same ID for two port netdevices
> + of the same physical switch chip. This is
> + mandatory to be implemented by all switch drivers
> + and serves the caller for recognition of a port
> + netdevice.
> + ndo_switch_parent_* - Functions that serve for a manipulation of the switch
> + chip itself (it can be though of as a "parent" of the
> + port, therefore the name). They are not port-specific.
> + Caller might use arbitrary port netdevice of the same
> + switch and it will make no difference.
I doubt that this is a good solution. If you want to access some kind of
parent device why dont you provide a device structure for it along with
register and unregister functions? Also each device should IMHO show up
in sysfs somehow, which should also be part of a register function.
There is already an existing driver (see net/dsa) that addresses the
representation of switch devices. What is wrong with that?
Regards,
Lino
next prev parent reply other threads:[~2014-11-29 9:33 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-28 13:34 [patch net-next v5 00/21] introduce rocker switch driver with hardware accelerated datapath api - phase 1: bridge fdb offload Jiri Pirko
2014-11-28 13:34 ` [patch net-next v5 01/21] bridge: rename fdb_*_hw to fdb_*_hw_addr to avoid confusion Jiri Pirko
2014-11-28 13:34 ` [patch net-next v5 02/21] neigh: sort Neighbor Cache Entry Flags Jiri Pirko
2014-11-28 13:34 ` [patch net-next v5 03/21] bridge: convert flags in fbd entry into bitfields Jiri Pirko
2014-11-28 13:34 ` [patch net-next v5 04/21] net: make vid as a parameter for ndo_fdb_add/ndo_fdb_del Jiri Pirko
2014-11-28 13:34 ` [patch net-next v5 05/21] net: rename netdev_phys_port_id to more generic name Jiri Pirko
2014-11-28 13:34 ` [patch net-next v5 06/21] net: introduce generic switch devices support Jiri Pirko
2014-11-29 9:31 ` Lino Sanfilippo [this message]
2014-11-29 9:59 ` Jiri Pirko
2014-11-29 10:44 ` Lino Sanfilippo
2014-11-28 13:34 ` [patch net-next v5 07/21] rtnl: expose physical switch id for particular device Jiri Pirko
2014-11-28 13:34 ` [patch net-next v5 08/21] net-sysfs: " Jiri Pirko
2014-11-28 13:34 ` [patch net-next v5 09/21] bridge: call netdev_sw_port_stp_update when bridge port STP status changes Jiri Pirko
2014-11-28 13:34 ` [patch net-next v5 10/21] bridge: add API to notify bridge driver of learned FBD on offloaded device Jiri Pirko
2014-11-28 13:34 ` [patch net-next v5 11/21] bridge: move private brport flags to if_bridge.h so port drivers can use flags Jiri Pirko
2014-11-28 13:34 ` [patch net-next v5 12/21] bridge: add new brport flag LEARNING_SYNC Jiri Pirko
2014-11-28 13:34 ` [patch net-next v5 13/21] bridge: add new hwmode swdev Jiri Pirko
2014-11-28 13:34 ` [patch net-next v5 14/21] bridge: add brport flags to dflt bridge_getlink Jiri Pirko
2014-11-28 13:34 ` [patch net-next v5 15/21] rocker: introduce rocker switch driver Jiri Pirko
2014-11-28 13:34 ` [patch net-next v5 16/21] rocker: implement rocker ofdpa flow table manipulation Jiri Pirko
2014-11-28 13:34 ` [patch net-next v5 17/21] rocker: implement L2 bridge offloading Jiri Pirko
2014-11-28 13:34 ` [patch net-next v5 18/21] rocker: implement ndo_fdb_dump Jiri Pirko
2014-11-28 13:34 ` [patch net-next v5 19/21] rocker: add ndo_bridge_setlink/getlink support for learning policy Jiri Pirko
2014-11-28 13:34 ` [patch net-next v5 20/21] rocker: Add proper validation of Netlink attributes Jiri Pirko
2014-11-28 13:34 ` [patch net-next v5 21/21] rocker: Use logical operators on booleans Jiri Pirko
2014-12-03 4:02 ` [patch net-next v5 00/21] introduce rocker switch driver with hardware accelerated datapath api - phase 1: bridge fdb offload David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5479927B.4020807@gmx.de \
--to=linosanfilippo@gmx.de \
--cc=Neil.Jerram@metaswitch.com \
--cc=alexander.h.duyck@redhat.com \
--cc=alexei.starovoitov@gmail.com \
--cc=andy@greyhouse.net \
--cc=aviadr@mellanox.com \
--cc=azhou@nicira.com \
--cc=bcrl@kvack.org \
--cc=ben@decadent.org.uk \
--cc=buytenh@wantstofly.org \
--cc=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=ebiederm@xmission.com \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=gospo@cumulusnetworks.com \
--cc=hemal@broadcom.co \
--cc=jasowang@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse@nicira.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=john.r.fastabend@intel.com \
--cc=john.ronciak@intel.com \
--cc=linville@tuxdriver.com \
--cc=mleitner@redhat.com \
--cc=nbd@openwrt.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=nicolas.dichtel@6wind.com \
--cc=ogerlitz@mellanox.com \
--cc=pshelar@nicira.com \
--cc=ronye@mellanox.com \
--cc=roopa@cumulusnetworks.com \
--cc=ryazanov.s.a@gmail.com \
--cc=sfeldma@gmail.com \
--cc=shrijeet@gmail.com \
--cc=simon.horman@netronome.com \
--cc=stephen@networkplumber.org \
--cc=tgraf@suug.ch \
--cc=vyasevic@redhat.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.