From mboxrd@z Thu Jan 1 00:00:00 1970 From: nick Date: Sat, 29 Nov 2014 13:09:09 -0500 Subject: [PATCH] drivers:net:wireless: Add mutex locking for function, b43_op_beacon_set_time in main.c In-Reply-To: References: <1417213013-19758-1-git-send-email-xerofoify@gmail.com> <20141129002148.1beb21d9@wiggum> <54793E4E.7050602@gmail.com> <20141129095632.69361457@wiggum> Message-ID: <547A0BC5.2080005@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , =?UTF-8?B?TWljaGE=?= =?UTF-8?B?ZWwgQsO8c2No?= Cc: Network Development , "linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Linux Kernel Mailing List , Stefano Brivio , b43-dev Sorry about that, next time I will be more careful. Nick On 2014-11-29 04:04 AM, Rafa? Mi?ecki wrote: > On 29 November 2014 at 09:56, Michael B?sch wrote: >> On Fri, 28 Nov 2014 22:32:30 -0500 >> nick wrote: >> >>> I don't have hardware for this driver on me, so I didn't test it. However this seems to >>> be correct from my reading of the code around this function and other locking related >>> to this driver. >> >> From the current docs: >> >>> * @set_tim: Set TIM bit. mac80211 calls this function when a TIM bit >>> * must be set or cleared for a given STA. Must be atomic. >> >> So it is not allowed to lock a mutex here. > > Nicholas please be more careful with your patches. It seems your patch > is wrong, you didn't check the docs and you didn't even say in the > first place that it wasn't tested. You could at least submit with with > RFT tag or sth. > From mboxrd@z Thu Jan 1 00:00:00 1970 From: nick Subject: Re: [PATCH] drivers:net:wireless: Add mutex locking for function, b43_op_beacon_set_time in main.c Date: Sat, 29 Nov 2014 13:09:09 -0500 Message-ID: <547A0BC5.2080005@gmail.com> References: <1417213013-19758-1-git-send-email-xerofoify@gmail.com> <20141129002148.1beb21d9@wiggum> <54793E4E.7050602@gmail.com> <20141129095632.69361457@wiggum> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: Network Development , "linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Linux Kernel Mailing List , Stefano Brivio , b43-dev To: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , =?UTF-8?B?TWljaGE=?= =?UTF-8?B?ZWwgQsO8c2No?= Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "b43-dev" Errors-To: b43-dev-bounces+gldbd-bcm43xx-dev=gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: netdev.vger.kernel.org U29ycnkgYWJvdXQgdGhhdCwgbmV4dCB0aW1lIEkgd2lsbCBiZSBtb3JlIGNhcmVmdWwuCk5pY2sK Ck9uIDIwMTQtMTEtMjkgMDQ6MDQgQU0sIFJhZmHFgiBNacWCZWNraSB3cm90ZToKPiBPbiAyOSBO b3ZlbWJlciAyMDE0IGF0IDA5OjU2LCBNaWNoYWVsIELDvHNjaCA8bUBidWVzLmNoPiB3cm90ZToK Pj4gT24gRnJpLCAyOCBOb3YgMjAxNCAyMjozMjozMCAtMDUwMAo+PiBuaWNrIDx4ZXJvZm9pZnlA Z21haWwuY29tPiB3cm90ZToKPj4KPj4+IEkgZG9uJ3QgaGF2ZSBoYXJkd2FyZSBmb3IgdGhpcyBk cml2ZXIgb24gbWUsIHNvIEkgZGlkbid0IHRlc3QgaXQuIEhvd2V2ZXIgdGhpcyBzZWVtcyB0bwo+ Pj4gYmUgY29ycmVjdCBmcm9tIG15IHJlYWRpbmcgb2YgdGhlIGNvZGUgYXJvdW5kIHRoaXMgZnVu Y3Rpb24gYW5kIG90aGVyIGxvY2tpbmcgcmVsYXRlZAo+Pj4gdG8gdGhpcyBkcml2ZXIuCj4+Cj4+ IEZyb20gdGhlIGN1cnJlbnQgZG9jczoKPj4KPj4+ICAqIEBzZXRfdGltOiBTZXQgVElNIGJpdC4g bWFjODAyMTEgY2FsbHMgdGhpcyBmdW5jdGlvbiB3aGVuIGEgVElNIGJpdAo+Pj4gICogICAgICBt dXN0IGJlIHNldCBvciBjbGVhcmVkIGZvciBhIGdpdmVuIFNUQS4gTXVzdCBiZSBhdG9taWMuCj4+ Cj4+IFNvIGl0IGlzIG5vdCBhbGxvd2VkIHRvIGxvY2sgYSBtdXRleCBoZXJlLgo+IAo+IE5pY2hv bGFzIHBsZWFzZSBiZSBtb3JlIGNhcmVmdWwgd2l0aCB5b3VyIHBhdGNoZXMuIEl0IHNlZW1zIHlv dXIgcGF0Y2gKPiBpcyB3cm9uZywgeW91IGRpZG4ndCBjaGVjayB0aGUgZG9jcyBhbmQgeW91IGRp ZG4ndCBldmVuIHNheSBpbiB0aGUKPiBmaXJzdCBwbGFjZSB0aGF0IGl0IHdhc24ndCB0ZXN0ZWQu IFlvdSBjb3VsZCBhdCBsZWFzdCBzdWJtaXQgd2l0aCB3aXRoCj4gUkZUIHRhZyBvciBzdGguCj4g CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpiNDMtZGV2 IG1haWxpbmcgbGlzdApiNDMtZGV2QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmlu ZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9iNDMtZGV2Cg==