From: Antonio Quartulli <antonio@meshcoding.com>
To: Markus Pargmann <mpa@pengutronix.de>,
Marek Lindner <mareklindner@neomailbox.ch>,
Simon Wunderlich <sw@simonwunderlich.de>
Cc: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Kconfig, Add missing DEBUG_FS dependency
Date: Sat, 29 Nov 2014 20:41:46 +0100 [thread overview]
Message-ID: <547A217A.9070209@meshcoding.com> (raw)
In-Reply-To: <1417284466-32016-1-git-send-email-mpa@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 905 bytes --]
On 29/11/14 19:07, Markus Pargmann wrote:
> BATMAN_ADV_DEBUG is using debugfs files for the debugging log. So it
> depends on DEBUG_FS which is missing as dependency in the Kconfig file.
>
> Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
> ---
> net/batman-adv/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/batman-adv/Kconfig b/net/batman-adv/Kconfig
> index 11660a3aab5a..c6fc8f756c9a 100644
> --- a/net/batman-adv/Kconfig
> +++ b/net/batman-adv/Kconfig
> @@ -62,6 +62,7 @@ config BATMAN_ADV_MCAST
> config BATMAN_ADV_DEBUG
> bool "B.A.T.M.A.N. debugging"
> depends on BATMAN_ADV
> + depends on DEBUG_FS
What if somebody does not want to bloat the kernel with debug_fs but
still wants to run batman-adv? (i.e. on a very constrained embedded unit)
With this patch this would not be possible anymore..
Cheers,
--
Antonio Quartulli
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-11-29 19:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-29 18:07 [B.A.T.M.A.N.] [PATCH] batman-adv: Kconfig, Add missing DEBUG_FS dependency Markus Pargmann
2014-11-29 19:41 ` Antonio Quartulli [this message]
2014-11-29 19:46 ` Markus Pargmann
2014-11-29 19:48 ` Antonio Quartulli
2015-01-07 21:16 ` Antonio Quartulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547A217A.9070209@meshcoding.com \
--to=antonio@meshcoding.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=mareklindner@neomailbox.ch \
--cc=mpa@pengutronix.de \
--cc=sw@simonwunderlich.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.