From: Jens Axboe <axboe@fb.com>
To: Shaohua Li <shli@kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] blk-mq: move the kdump check to blk_mq_alloc_tag_set
Date: Sun, 30 Nov 2014 18:32:08 -0700 [thread overview]
Message-ID: <547BC518.40806@fb.com> (raw)
In-Reply-To: <8bbd9edbdc0c1e8550af9607d3765a44145be5bd.1417391479.git.shli@kernel.org>
On 11/30/2014 05:00 PM, Shaohua Li wrote:
> We call blk_mq_alloc_tag_set() first then blk_mq_init_queue(). The requests are
> allocated in the former function. So the kdump check should be moved to there
> to really save memory.
Strange, it was even tested, but must have been altered after the fact.
Patch looks good to me, applied.
--
Jens Axboe
prev parent reply other threads:[~2014-12-01 1:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-01 0:00 [PATCH] blk-mq: move the kdump check to blk_mq_alloc_tag_set Shaohua Li
2014-12-01 1:32 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547BC518.40806@fb.com \
--to=axboe@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shli@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.