All of lore.kernel.org
 help / color / mirror / Atom feed
From: Minkyu Kang <mk7.kang@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2 v2] exynos5420: fix compilation without parade video
Date: Mon, 01 Dec 2014 14:24:16 +0900	[thread overview]
Message-ID: <547BFB80.9030704@samsung.com> (raw)
In-Reply-To: <1417100881-1523-3-git-send-email-sjoerd.simons@collabora.co.uk>

Dear Sjoerd Simons,

On 28/11/14 00:08, Sjoerd Simons wrote:
> Not all exynos 5420 based devices with an LCD also have a parade LVDS
> bridge. So make sure compilation doesn't break if CONFIG_LCD is enabled
> and CONFIG_VIDEO_PARADE is not.
> 
> Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
> ---
>  Changes since V1: New patch
> 
>  arch/arm/include/asm/arch-exynos/system.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm/include/asm/arch-exynos/system.h b/arch/arm/include/asm/arch-exynos/system.h
> index 320763f..dd68290 100644
> --- a/arch/arm/include/asm/arch-exynos/system.h
> +++ b/arch/arm/include/asm/arch-exynos/system.h
> @@ -42,6 +42,10 @@ void set_system_display_ctrl(void);
>  int exynos_lcd_early_init(const void *blob);
>  
>  /* Initialize the Parade dP<->LVDS bridge if present */
> +#ifdef CONFIG_VIDEO_PARADE
>  int parade_init(const void *blob);
> +#else
> +static inline int parade_init(const void *blob) { return -1; }
> +#endif

Actually, it does not related with this patch..
and I know that you are not an author.
But.. I'd like ask you, why parade_init function is in exynos header file?
If you are agreed, could you please make new header file? (e.g: include/parade.h)

And I think you missed removing the CONFIG_VIDEO_PARADE at peach-pi.h

Thanks,
Minkyu Kang.

  parent reply	other threads:[~2014-12-01  5:24 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-27 15:07 [U-Boot] [PATCH 0/2 v2] No need for parade bridge on peach-pi Sjoerd Simons
2014-11-27 15:08 ` [U-Boot] [PATCH 1/2 v2] Exynos5800: The Peach-Pi board does not have a Parade video bridge Sjoerd Simons
2014-11-30 18:56   ` Simon Glass
2014-12-01 10:03     ` Sjoerd Simons
2014-12-01 20:09       ` Simon Glass
2014-12-01 20:25         ` Sjoerd Simons
2014-12-01 20:30           ` Simon Glass
2014-12-05 14:24             ` Ajay kumar
2015-01-28  4:02               ` Simon Glass
2014-11-27 15:08 ` [U-Boot] [PATCH 2/2 v2] exynos5420: fix compilation without parade video Sjoerd Simons
2014-11-30 18:58   ` Simon Glass
2014-12-01  5:24   ` Minkyu Kang [this message]
2014-12-01 10:06     ` Sjoerd Simons
2014-12-01 16:25       ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=547BFB80.9030704@samsung.com \
    --to=mk7.kang@samsung.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.