From: Mirko Lindner <mlindner@marvell.com>
To: Lino Sanfilippo <LinoSanfilippo@gmx.de>
Cc: <stephen@networkplumber.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] skge: Unmask interrupts in case of spurious interrupts
Date: Mon, 1 Dec 2014 10:53:31 +0100 [thread overview]
Message-ID: <547C3A9B.4060407@marvell.com> (raw)
In-Reply-To: <1417348291-1302-1-git-send-email-LinoSanfilippo@gmx.de>
On 30/11/14 12:51, Lino Sanfilippo wrote:
> In case of a spurious interrupt dont forget to reenable the interrupts that
> have been masked by reading the interrupt source register.
>
> Signed-off-by: Lino Sanfilippo <LinoSanfilippo@gmx.de>
> ---
> drivers/net/ethernet/marvell/skge.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/marvell/skge.c b/drivers/net/ethernet/marvell/skge.c
> index 264eab7..7173836 100644
> --- a/drivers/net/ethernet/marvell/skge.c
> +++ b/drivers/net/ethernet/marvell/skge.c
> @@ -3433,10 +3433,9 @@ static irqreturn_t skge_intr(int irq, void *dev_id)
>
> if (status & IS_HW_ERR)
> skge_error_irq(hw);
> -
> +out:
> skge_write32(hw, B0_IMSK, hw->intr_mask);
> skge_read32(hw, B0_IMSK);
> -out:
> spin_unlock(&hw->hw_lock);
>
> return IRQ_RETVAL(handled);
>
Looks OK.
Acked-by: Mirko Lindner <mlindner@marvell.com>
next prev parent reply other threads:[~2014-12-01 9:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-30 11:51 [PATCH] skge: Unmask interrupts in case of spurious interrupts Lino Sanfilippo
2014-12-01 9:53 ` Mirko Lindner [this message]
2014-12-06 5:34 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547C3A9B.4060407@marvell.com \
--to=mlindner@marvell.com \
--cc=LinoSanfilippo@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.