From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Yan Subject: Re: [PATCH v14 05/12] drm: imx: imx-hdmi: move imx-hdmi to bridge/dw_hdmi Date: Mon, 01 Dec 2014 19:53:54 +0800 Message-ID: <547C56D2.5030302@rock-chips.com> References: <1417432770-12719-1-git-send-email-andy.yan@rock-chips.com> <1417433086-12964-1-git-send-email-andy.yan@rock-chips.com> <1417434133.4624.9.camel@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1417434133.4624.9.camel@pengutronix.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Philipp Zabel Cc: Mark Rutland , heiko@sntech.de, airlied@linux.ie, dri-devel@lists.freedesktop.org, ykk@rock-chips.com, devel@driverdev.osuosl.org, Arnd Bergmann , linux-rockchip@lists.infradead.org, Grant Likely , rmk+kernel@arm.linux.org.uk, jay.xu@rock-chips.com, devicetree@vger.kernel.org, Zubair.Kakakhel@imgtec.com, Pawel Moll , Ian Campbell , Inki Dae , Rob Herring , Sean Paul , Dave Airlie , mark.yao@rock-chips.com, fabio.estevam@freescale.com, Josh Boyer , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, djkurtz@google.com, Kumar Gala , Shawn Guo , Lucas Stach List-Id: devicetree@vger.kernel.org SGkgUGhpbGlwcDoKCk9uIDIwMTTlubQxMuaciDAx5pelIDE5OjQyLCBQaGlsaXBwIFphYmVsIHdy b3RlOgo+IEhpIEFuZHksCj4KPiBBbSBNb250YWcsIGRlbiAwMS4xMi4yMDE0LCAxOToyNCArMDgw MCBzY2hyaWViIEFuZHkgWWFuOgo+IFsuLi5dCj4+IGRpZmYgLS1naXQgYS9pbmNsdWRlL2RybS9i cmlkZ2UvZHdfaGRtaS5oIGIvaW5jbHVkZS9kcm0vYnJpZGdlL2R3X2hkbWkuaAo+PiBuZXcgZmls ZSBtb2RlIDEwMDY0NAo+PiBpbmRleCAwMDAwMDAwLi4xYmJmM2NhCj4+IC0tLSAvZGV2L251bGwK Pj4gKysrIGIvaW5jbHVkZS9kcm0vYnJpZGdlL2R3X2hkbWkuaAo+PiBAQCAtMCwwICsxLDU3IEBA Cj4+ICsvKgo+PiArICogQ29weXJpZ2h0IChDKSAyMDExIEZyZWVzY2FsZSBTZW1pY29uZHVjdG9y LCBJbmMuCj4+ICsgKgo+PiArICogVGhpcyBwcm9ncmFtIGlzIGZyZWUgc29mdHdhcmU7IHlvdSBj YW4gcmVkaXN0cmlidXRlIGl0IGFuZC9vciBtb2RpZnkKPj4gKyAqIGl0IHVuZGVyIHRoZSB0ZXJt cyBvZiB0aGUgR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2UgYXMgcHVibGlzaGVkIGJ5Cj4+ICsg KiB0aGUgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uOyBlaXRoZXIgdmVyc2lvbiAyIG9mIHRoZSBM aWNlbnNlLCBvcgo+PiArICogKGF0IHlvdXIgb3B0aW9uKSBhbnkgbGF0ZXIgdmVyc2lvbi4KPj4g KyAqLwo+PiArCj4+ICsjaWZuZGVmIF9fRFdfSERNSV9fCj4+ICsjZGVmaW5lIF9fRFdfSERNSV9f Cj4+ICsKPj4gKyNpbmNsdWRlIDxkcm0vZHJtUC5oPgo+PiArCj4+ICtlbnVtIHsKPj4gKwlSRVNf OCwKPj4gKwlSRVNfMTAsCj4+ICsJUkVTXzEyLAo+PiArCVJFU19NQVgsCj4+ICt9Owo+PiArCj4+ ICtlbnVtIGR3X2hkbWlfZGV2dHlwZSB7Cj4+ICsJSU1YNlFfSERNSSwKPj4gKwlJTVg2RExfSERN SSwKPj4gK307Cj4+ICsKPj4gK3N0cnVjdCBtcGxsX2NvbmZpZyB7Cj4+ICsJdW5zaWduZWQgbG9u ZyBtcGl4ZWxjbG9jazsKPj4gKwlzdHJ1Y3Qgewo+PiArCQl1MTYgY3BjZTsKPj4gKwkJdTE2IGdt cDsKPj4gKwl9IHJlc1tSRVNfTUFYXTsKPj4gK307Cj4+ICsKPj4gK3N0cnVjdCBjdXJyX2N0cmwg ewo+PiArCXVuc2lnbmVkIGxvbmcgbXBpeGVsY2xvY2s7Cj4+ICsJdTE2IGN1cnJbUkVTX01BWF07 Cj4+ICt9Owo+PiArCj4+ICtzdHJ1Y3Qgc3ltX3Rlcm0gewo+PiArCXVuc2lnbmVkIGxvbmcgbXBp eGVsY2xvY2s7Cj4+ICsJdTE2IHN5bV9jdHI7ICAgIC8qY2xvY2sgc3ltYm9sIGFuZCB0cmFuc21p dHRlciBjb250cm9sKi8KPj4gKwl1MTYgdGVybTsgICAgICAgLyp0cmFuc21pc3Npb24gdGVybWlu YXRpb24gdmFsdWUqLwo+PiArfTsKPiBzaW5jZSB0aGlzIGlzIGdvaW5nIHRvIGJlIHVzZWQgYnkg bXVsdGlwbGUgZHJpdmVycywgdGhlIGVudW1zIGFuZAo+IHN0cnVjdHMgc2hvdWxkIGFsbCBiZSBw cm9wZXJseSBuYW1lc3BhY2VkLiBIb3cgYWJvdXQgRFdfSERNSV9SRVNfeCwKPiBzdHJ1Y3QgZHdf aGRtaV9tcGxsX2NvbmZpZywgc3RydWN0IGR3X2hkbWlfY3Vycl9jdHJsLCBhbmQgc3RydWN0Cj4g ZHdfaGRtaV9zeW1fdGVybT8KCiAgIFRoYXQgc291bmRzIGdvb2QsIEkgd2lsbCB0YWtlIHlvdXIg YWR2aWNlIGluIFBBVENIIFYxNS4KICAgVGhhbmtzCj4+ICtzdHJ1Y3QgZHdfaGRtaV9wbGF0X2Rh dGEgewo+PiArCWVudW0gZHdfaGRtaV9kZXZ0eXBlIGRldl90eXBlOwo+PiArCWNvbnN0IHN0cnVj dCBtcGxsX2NvbmZpZyAqbXBsbF9jZmc7Cj4+ICsJY29uc3Qgc3RydWN0IGN1cnJfY3RybCAqY3Vy X2N0cjsKPj4gKwljb25zdCBzdHJ1Y3Qgc3ltX3Rlcm0gKnN5bV90ZXJtOwo+PiArfTsKPj4gKwo+ PiArdm9pZCBkd19oZG1pX3VuYmluZChzdHJ1Y3QgZGV2aWNlICpkZXYsIHN0cnVjdCBkZXZpY2Ug Km1hc3Rlciwgdm9pZCAqZGF0YSk7Cj4+ICtpbnQgZHdfaGRtaV9iaW5kKHN0cnVjdCBkZXZpY2Ug KmRldiwgc3RydWN0IGRldmljZSAqbWFzdGVyLAo+PiArCQkgdm9pZCAqZGF0YSwgc3RydWN0IGRy bV9lbmNvZGVyICplbmNvZGVyLAo+PiArCQkgY29uc3Qgc3RydWN0IGR3X2hkbWlfcGxhdF9kYXRh ICpwbGF0X2RhdGEpOwo+PiArI2VuZGlmIC8qIF9fSU1YX0hETUlfSF9fICovCj4gcmVnYXJkcwo+ IFBoaWxpcHAKPgo+Cj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KPiBMaW51eC1yb2NrY2hpcCBtYWlsaW5nIGxpc3QKPiBMaW51eC1yb2NrY2hpcEBsaXN0 cy5pbmZyYWRlYWQub3JnCj4gaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0 aW5mby9saW51eC1yb2NrY2hpcAo+Cj4KPgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmRldmVsIG1haWxpbmcgbGlzdApkZXZlbEBsaW51eGRyaXZlcnBy b2plY3Qub3JnCmh0dHA6Ly9kcml2ZXJkZXYubGludXhkcml2ZXJwcm9qZWN0Lm9yZy9tYWlsbWFu L2xpc3RpbmZvL2RyaXZlcmRldi1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753428AbaLALyG (ORCPT ); Mon, 1 Dec 2014 06:54:06 -0500 Received: from lucky1.263xmail.com ([211.157.147.133]:36008 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753013AbaLALyE (ORCPT ); Mon, 1 Dec 2014 06:54:04 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: andy.yan@rock-chips.com X-FST-TO: l.stach@pengutronix.de X-SENDER-IP: 121.15.173.1 X-LOGIN-NAME: andy.yan@rock-chips.com X-UNIQUE-TAG: <4d9529808b8b167af6f177870c9b4a57> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <547C56D2.5030302@rock-chips.com> Date: Mon, 01 Dec 2014 19:53:54 +0800 From: Andy Yan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Philipp Zabel CC: Mark Rutland , heiko@sntech.de, airlied@linux.ie, dri-devel@lists.freedesktop.org, ykk@rock-chips.com, devel@driverdev.osuosl.org, Pawel Moll , linux-rockchip@lists.infradead.org, Grant Likely , Dave Airlie , jay.xu@rock-chips.com, devicetree@vger.kernel.org, Zubair.Kakakhel@imgtec.com, Arnd Bergmann , Ian Campbell , Inki Dae , Rob Herring , Sean Paul , rmk+kernel@arm.linux.org.uk, mark.yao@rock-chips.com, fabio.estevam@freescale.com, Josh Boyer , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, djkurtz@google.com, Kumar Gala , Shawn Guo , Lucas Stach Subject: Re: [PATCH v14 05/12] drm: imx: imx-hdmi: move imx-hdmi to bridge/dw_hdmi References: <1417432770-12719-1-git-send-email-andy.yan@rock-chips.com> <1417433086-12964-1-git-send-email-andy.yan@rock-chips.com> <1417434133.4624.9.camel@pengutronix.de> In-Reply-To: <1417434133.4624.9.camel@pengutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Philipp: On 2014年12月01日 19:42, Philipp Zabel wrote: > Hi Andy, > > Am Montag, den 01.12.2014, 19:24 +0800 schrieb Andy Yan: > [...] >> diff --git a/include/drm/bridge/dw_hdmi.h b/include/drm/bridge/dw_hdmi.h >> new file mode 100644 >> index 0000000..1bbf3ca >> --- /dev/null >> +++ b/include/drm/bridge/dw_hdmi.h >> @@ -0,0 +1,57 @@ >> +/* >> + * Copyright (C) 2011 Freescale Semiconductor, Inc. >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License as published by >> + * the Free Software Foundation; either version 2 of the License, or >> + * (at your option) any later version. >> + */ >> + >> +#ifndef __DW_HDMI__ >> +#define __DW_HDMI__ >> + >> +#include >> + >> +enum { >> + RES_8, >> + RES_10, >> + RES_12, >> + RES_MAX, >> +}; >> + >> +enum dw_hdmi_devtype { >> + IMX6Q_HDMI, >> + IMX6DL_HDMI, >> +}; >> + >> +struct mpll_config { >> + unsigned long mpixelclock; >> + struct { >> + u16 cpce; >> + u16 gmp; >> + } res[RES_MAX]; >> +}; >> + >> +struct curr_ctrl { >> + unsigned long mpixelclock; >> + u16 curr[RES_MAX]; >> +}; >> + >> +struct sym_term { >> + unsigned long mpixelclock; >> + u16 sym_ctr; /*clock symbol and transmitter control*/ >> + u16 term; /*transmission termination value*/ >> +}; > since this is going to be used by multiple drivers, the enums and > structs should all be properly namespaced. How about DW_HDMI_RES_x, > struct dw_hdmi_mpll_config, struct dw_hdmi_curr_ctrl, and struct > dw_hdmi_sym_term? That sounds good, I will take your advice in PATCH V15. Thanks >> +struct dw_hdmi_plat_data { >> + enum dw_hdmi_devtype dev_type; >> + const struct mpll_config *mpll_cfg; >> + const struct curr_ctrl *cur_ctr; >> + const struct sym_term *sym_term; >> +}; >> + >> +void dw_hdmi_unbind(struct device *dev, struct device *master, void *data); >> +int dw_hdmi_bind(struct device *dev, struct device *master, >> + void *data, struct drm_encoder *encoder, >> + const struct dw_hdmi_plat_data *plat_data); >> +#endif /* __IMX_HDMI_H__ */ > regards > Philipp > > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip > > >