From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pd0-x22c.google.com ([2607:f8b0:400e:c02::22c]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1XvQhJ-0002MI-ST for linux-mtd@lists.infradead.org; Mon, 01 Dec 2014 13:07:26 +0000 Received: by mail-pd0-f172.google.com with SMTP id y13so10959896pdi.3 for ; Mon, 01 Dec 2014 05:07:04 -0800 (PST) Message-ID: <547C67F3.7080807@gmail.com> Date: Mon, 01 Dec 2014 21:06:59 +0800 From: Zhou Wang MIME-Version: 1.0 To: Brian Norris Subject: Re: [PATCH v4 0/2] mtd: hisilicon: add a new driver for NAND controller of hisilicon hip04 Soc References: <1415105221-7732-1-git-send-email-wangzhou.bry@gmail.com> <20141130090853.GG3608@norris-Latitude-E6410> In-Reply-To: <20141130090853.GG3608@norris-Latitude-E6410> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, linux-kernel@vger.kernel.org, haojian.zhuang@gmail.com, wangzhou1@hisilicon.com, robh+dt@kernel.org, linux-mtd@lists.infradead.org, xuwei5@hisilicon.com, galak@codeaurora.org, caizhiyong@huawei.com, David Woodhouse List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 2014年11月30日 17:08, Brian Norris wrote: > On Tue, Nov 04, 2014 at 08:46:59PM +0800, Zhou Wang wrote: >> This patchset adds the support for NAND controller of hisilicon hip04 Soc. >> The NAND controller IP was developed by hisilicon and needs a new driver to >> support it. This patchset is based on v3.18-rc1. I have tested that NAND flash >> controller works fine in Hip04 D01 board. > > Have you tested on the MTD test modules (drivers/mtd/tests/*)? This is > important, as we seem to regularly get UBIFS bug reports from users > whose drivers have not even passed some of the simple tests. > > Also, it might be worth testing out the UBI tests found in the mtd-utils > package. > > Brian > Hi Brian, I have not tested on the MTD test modules, I will do this test and the UBI tests ASAP. Thank you very much for so many helpful comments! Best Regards, Zhou Wang From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zhou Wang Subject: Re: [PATCH v4 0/2] mtd: hisilicon: add a new driver for NAND controller of hisilicon hip04 Soc Date: Mon, 01 Dec 2014 21:06:59 +0800 Message-ID: <547C67F3.7080807@gmail.com> References: <1415105221-7732-1-git-send-email-wangzhou.bry@gmail.com> <20141130090853.GG3608@norris-Latitude-E6410> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20141130090853.GG3608@norris-Latitude-E6410> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Brian Norris Cc: David Woodhouse , linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, caizhiyong-hv44wF8Li93QT0dZR+AlfA@public.gmane.org, haojian.zhuang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, xuwei5-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org, wangzhou1-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On 2014=E5=B9=B411=E6=9C=8830=E6=97=A5 17:08, Brian Norris wrote: > On Tue, Nov 04, 2014 at 08:46:59PM +0800, Zhou Wang wrote: >> This patchset adds the support for NAND controller of hisilicon hip0= 4 Soc. >> The NAND controller IP was developed by hisilicon and needs a new dr= iver to >> support it. This patchset is based on v3.18-rc1. I have tested that = NAND flash >> controller works fine in Hip04 D01 board. > > Have you tested on the MTD test modules (drivers/mtd/tests/*)? This i= s > important, as we seem to regularly get UBIFS bug reports from users > whose drivers have not even passed some of the simple tests. > > Also, it might be worth testing out the UBI tests found in the mtd-ut= ils > package. > > Brian > Hi Brian, I have not tested on the MTD test modules, I will do this test and the UBI tests ASAP. Thank you very much for so many helpful comments! Best Regards, Zhou Wang -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753674AbaLANHH (ORCPT ); Mon, 1 Dec 2014 08:07:07 -0500 Received: from mail-pd0-f178.google.com ([209.85.192.178]:57052 "EHLO mail-pd0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753455AbaLANHE (ORCPT ); Mon, 1 Dec 2014 08:07:04 -0500 Message-ID: <547C67F3.7080807@gmail.com> Date: Mon, 01 Dec 2014 21:06:59 +0800 From: Zhou Wang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130623 Thunderbird/17.0.7 MIME-Version: 1.0 To: Brian Norris CC: David Woodhouse , linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, mark.rutland@arm.com, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, robh+dt@kernel.org, galak@codeaurora.org, caizhiyong@huawei.com, haojian.zhuang@gmail.com, xuwei5@hisilicon.com, wangzhou1@hisilicon.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 0/2] mtd: hisilicon: add a new driver for NAND controller of hisilicon hip04 Soc References: <1415105221-7732-1-git-send-email-wangzhou.bry@gmail.com> <20141130090853.GG3608@norris-Latitude-E6410> In-Reply-To: <20141130090853.GG3608@norris-Latitude-E6410> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2014年11月30日 17:08, Brian Norris wrote: > On Tue, Nov 04, 2014 at 08:46:59PM +0800, Zhou Wang wrote: >> This patchset adds the support for NAND controller of hisilicon hip04 Soc. >> The NAND controller IP was developed by hisilicon and needs a new driver to >> support it. This patchset is based on v3.18-rc1. I have tested that NAND flash >> controller works fine in Hip04 D01 board. > > Have you tested on the MTD test modules (drivers/mtd/tests/*)? This is > important, as we seem to regularly get UBIFS bug reports from users > whose drivers have not even passed some of the simple tests. > > Also, it might be worth testing out the UBI tests found in the mtd-utils > package. > > Brian > Hi Brian, I have not tested on the MTD test modules, I will do this test and the UBI tests ASAP. Thank you very much for so many helpful comments! Best Regards, Zhou Wang