All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Vrabel <david.vrabel@citrix.com>
To: David Miller <davem@davemloft.net>, <seth.forshee@canonical.com>
Cc: <zoltan.kiss@linaro.org>, <eric.dumazet@gmail.com>,
	<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<stefan.bader@canonical.com>, <david.vrabel@citrix.com>,
	<xen-devel@lists.xenproject.org>, <boris.ostrovsky@oracle.com>
Subject: Re: [Xen-devel] [PATCH] xen-netfront: Remove BUGs on paged skb data which crosses a page boundary
Date: Mon, 1 Dec 2014 13:27:32 +0000	[thread overview]
Message-ID: <547C6CC4.9070605@citrix.com> (raw)
In-Reply-To: <20141126.122812.223757363894961994.davem@davemloft.net>

On 26/11/14 17:28, David Miller wrote:
> From: Seth Forshee <seth.forshee@canonical.com>
> Date: Tue, 25 Nov 2014 20:28:24 -0600
> 
>> These BUGs can be erroneously triggered by frags which refer to
>> tail pages within a compound page. The data in these pages may
>> overrun the hardware page while still being contained within the
>> compound page, but since compound_order() evaluates to 0 for tail
>> pages the assertion fails. The code already iterates through
>> subsequent pages correctly in this scenario, so the BUGs are
>> unnecessary and can be removed.
>>
>> Fixes: f36c374782e4 ("xen/netfront: handle compound page fragments on transmit")
>> Cc: <stable@vger.kernel.org> # 3.7+
>> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
> 
> Can I get some Xen developer reviews?

Sorry for the delay, I've been on holiday.

Reviewed-by: David Vrabel <david.vrabel@citrix.com>

Thanks.

David

  parent reply	other threads:[~2014-12-01 13:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-26  2:28 [PATCH] xen-netfront: Remove BUGs on paged skb data which crosses a page boundary Seth Forshee
2014-11-26 17:28 ` David Miller
2014-11-27  3:53   ` Seth Forshee
2014-11-30  4:43     ` David Miller
2014-11-30  4:43     ` David Miller
2014-11-27  3:53   ` Seth Forshee
2014-12-01 13:27   ` David Vrabel [this message]
2014-12-01 13:27   ` David Vrabel
2014-11-26 17:28 ` David Miller
2014-12-03  3:25 ` David Miller
2014-12-03  3:25 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=547C6CC4.9070605@citrix.com \
    --to=david.vrabel@citrix.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=seth.forshee@canonical.com \
    --cc=stefan.bader@canonical.com \
    --cc=xen-devel@lists.xenproject.org \
    --cc=zoltan.kiss@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.