All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Denis Kirjanov <kda@linux-powerpc.org>, netdev@vger.kernel.org
Cc: markos.chandras@imgtec.com
Subject: Re: [PATCH] mips: bpf: Fix broken BPF_MOD
Date: Mon, 01 Dec 2014 16:50:56 +0300	[thread overview]
Message-ID: <547C7240.4010401@cogentembedded.com> (raw)
In-Reply-To: <1417427822-12729-1-git-send-email-kda@linux-powerpc.org>

Hello.

On 12/1/2014 12:57 PM, Denis Kirjanov wrote:

    You should CC the 'linux-mips' ML.

> Remove optimize_div() from BPF_MOD | BPF_K case
> since we don't know the dividend and fix the
> emit_mod() by reading the mod operation result from HI register

    Isn't this 2 unrelated fixes? They should be in 2 patches, not a single 
one in that case.

> Signed-off-by: Denis Kirjanov <kda@linux-powerpc.org>
> ---
>   arch/mips/net/bpf_jit.c |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)

WBR, Sergei

  parent reply	other threads:[~2014-12-01 13:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-01  9:57 [PATCH] mips: bpf: Fix broken BPF_MOD Denis Kirjanov
2014-12-01 10:13 ` Markos Chandras
2014-12-01 10:37   ` Denis Kirjanov
2014-12-01 13:50 ` Sergei Shtylyov [this message]
2014-12-01 13:55   ` Denis Kirjanov
2014-12-09  1:23 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=547C7240.4010401@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=kda@linux-powerpc.org \
    --cc=markos.chandras@imgtec.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.