From: Harald Hoyer <harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Minfei Huang <mhuang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] 40network: Fix the syntax to correct the judgment sentence
Date: Mon, 01 Dec 2014 17:04:23 +0100 [thread overview]
Message-ID: <547C9187.3070209@redhat.com> (raw)
In-Reply-To: <1417408626-28037-1-git-send-email-mhuang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
On 01.12.2014 05:37, Minfei Huang wrote:
> In the judgment sentence, it will print the following warning message,
> becasuse of lacking the blank on the left of ']'.
>
> /lib/net-lib.sh: line 110: [: missing `]'
>
> Signed-off-by: Minfei Huang <mhuang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> ---
> modules.d/40network/net-lib.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/modules.d/40network/net-lib.sh b/modules.d/40network/net-lib.sh
> index 48e7014..d9c5a1d 100755
> --- a/modules.d/40network/net-lib.sh
> +++ b/modules.d/40network/net-lib.sh
> @@ -105,7 +105,7 @@ setup_net() {
> # add static route
> for _p in $(getargs rd.route); do
> route_to_var "$_p" || continue
> - [ -n "$route_dev" ] && [ "$route_dev" != "$netif"] && continue
> + [ -n "$route_dev" ] && [ "$route_dev" != "$netif" ] && continue
> ip route add "$route_mask" ${route_gw:+via "$route_gw"} ${route_dev:+dev "$route_dev"}
> if strstr ":" "$route_mask"; then
> printf -- "%s\n" "$route_mask ${route_gw:+via $route_gw} ${route_dev:+dev $route_dev}" \
>
pushed... Thanks!
prev parent reply other threads:[~2014-12-01 16:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-01 4:37 [PATCH] 40network: Fix the syntax to correct the judgment sentence Minfei Huang
[not found] ` <1417408626-28037-1-git-send-email-mhuang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-12-01 16:04 ` Harald Hoyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547C9187.3070209@redhat.com \
--to=harald-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mhuang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.