All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: arei.gonglei@huawei.com, qemu-devel@nongnu.org
Cc: weidong.huang@huawei.com, kraxel@redhat.com, peter.huangpeng@huawei.com
Subject: Re: [Qemu-devel] [RFC PATCH 0/2] Support to change VNC keyboard layout dynamically
Date: Mon, 01 Dec 2014 09:37:27 -0700	[thread overview]
Message-ID: <547C9947.3060605@redhat.com> (raw)
In-Reply-To: <1417257582-1272-1-git-send-email-arei.gonglei@huawei.com>

[-- Attachment #1: Type: text/plain, Size: 863 bytes --]

On 11/29/2014 03:39 AM, arei.gonglei@huawei.com wrote:
> From: Gonglei <arei.gonglei@huawei.com>
> 
> A bonus of this feature is that supporting different
> people (in different countries) using defferent keyboard

s/defferent/different/

> to connect the same guest but not need to configure
> command line or libivrt xml file then restart guest.
> 
> Using the existing qmp command:
> 
>     -> { "execute": "change",
>                  "arguments": { "device": "vnc", "target": "keymap",
>                                 "arg": "de" } }
>     <- { "return": {} }

Please add a new QMP command.  The existing 'change' command is not
type-safe and therefore difficult to introspect; we should not be adding
more band-aids to it.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]

      parent reply	other threads:[~2014-12-01 16:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-29 10:39 [Qemu-devel] [RFC PATCH 0/2] Support to change VNC keyboard layout dynamically arei.gonglei
2014-11-29 10:39 ` [Qemu-devel] [RFC PATCH 1/2] vnc: introduce vnc_display_kbd_layout function arei.gonglei
2014-11-29 10:39 ` [Qemu-devel] [RFC PATCH 2/2] vnc: add change keyboard layout interface arei.gonglei
2014-12-01 16:40   ` Eric Blake
2014-12-02  1:48     ` Gonglei
2014-12-01 16:37 ` Eric Blake [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=547C9947.3060605@redhat.com \
    --to=eblake@redhat.com \
    --cc=arei.gonglei@huawei.com \
    --cc=kraxel@redhat.com \
    --cc=peter.huangpeng@huawei.com \
    --cc=qemu-devel@nongnu.org \
    --cc=weidong.huang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.