From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christopher Covington Subject: Re: [PATCH 2/4] drm/msm/hdmi: enable regulators before clocks to avoid warnings Date: Mon, 01 Dec 2014 14:08:54 -0500 Message-ID: <547CBCC6.3060805@codeaurora.org> References: <1417032984-11869-1-git-send-email-jilaiw@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1417032984-11869-1-git-send-email-jilaiw@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org To: Jilai Wang Cc: dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, robdclark@gmail.com List-Id: linux-arm-msm@vger.kernel.org Hi Jilai, On 11/26/2014 03:16 PM, Jilai Wang wrote: > HPD regulators need to be enabled before clocks, otherwise clock > driver will report warning. > > Change-Id: Ieca41722ae3b15873e6290649a21bbd13e1a4278 Nit: The upstream preference is to omit Change-Id lines. You should be able to move .git/hooks/commit-msg to an alternate location and amend the patch to remove it. Upstream checkpatch should warn about this--let me know if it's not working properly. Regards, Chris -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project