From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timur Tabi Subject: Re: [alsa-devel] [PATCH] ASoC: fsl_ssi: free irq before irq_dispose_mapping() Date: Mon, 01 Dec 2014 14:42:46 -0600 Message-ID: <547CD2C6.2060107@tabi.org> References: <1417402251-6596-1-git-send-email-jiada_wang@mentor.com> <2547588.Qc4F2IfZke@wuerfel> <547CC89F.1030205@tabi.org> <3401240.VsRpsiV8WN@wuerfel> <547CCB78.5090007@tabi.org> <547CCFF7.2000205@metafoo.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Fabio Estevam , Lars-Peter Clausen Cc: Arnd Bergmann , "alsa-devel@alsa-project.org" , Jiada Wang , Xiubo Li , linux-kernel , Liam Girdwood , Nicolin Chen , Takashi Iwai , Mark Brown , Markus Pargmann , "linuxppc-dev@lists.ozlabs.org" List-Id: alsa-devel@alsa-project.org On 12/01/2014 02:40 PM, Fabio Estevam wrote: >> >Hm... that's new. But it's not really a driver issue anymore if it is done >> >in the core. So I guess for now just use platform_get_irq() and ignore the >> >other issue. > With the suggested changes below, the removal of the driver works fine on a mx6: Would the mapping continue to exist after the driver is unloaded? Can you try multiple loads/unloads and see if interrupts still work? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from muin.pair.com (muin.pair.com [209.68.1.55]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 100EC1A0008 for ; Tue, 2 Dec 2014 07:42:52 +1100 (AEDT) Message-ID: <547CD2C6.2060107@tabi.org> Date: Mon, 01 Dec 2014 14:42:46 -0600 From: Timur Tabi MIME-Version: 1.0 To: Fabio Estevam , Lars-Peter Clausen Subject: Re: [alsa-devel] [PATCH] ASoC: fsl_ssi: free irq before irq_dispose_mapping() References: <1417402251-6596-1-git-send-email-jiada_wang@mentor.com> <2547588.Qc4F2IfZke@wuerfel> <547CC89F.1030205@tabi.org> <3401240.VsRpsiV8WN@wuerfel> <547CCB78.5090007@tabi.org> <547CCFF7.2000205@metafoo.de> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Cc: "alsa-devel@alsa-project.org" , Arnd Bergmann , Jiada Wang , Mark Brown , linux-kernel , Liam Girdwood , Nicolin Chen , Takashi Iwai , Xiubo Li , Markus Pargmann , "linuxppc-dev@lists.ozlabs.org" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 12/01/2014 02:40 PM, Fabio Estevam wrote: >> >Hm... that's new. But it's not really a driver issue anymore if it is done >> >in the core. So I guess for now just use platform_get_irq() and ignore the >> >other issue. > With the suggested changes below, the removal of the driver works fine on a mx6: Would the mapping continue to exist after the driver is unloaded? Can you try multiple loads/unloads and see if interrupts still work?