From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martin Peres Subject: Re: [RESEND PATCH nouveau 2/3] volt: allow non-bios voltage scaling Date: Mon, 01 Dec 2014 23:57:39 +0100 Message-ID: <547CF263.6070900@free.fr> References: <1417173180-21726-1-git-send-email-vinceh@nvidia.com> <1417173180-21726-2-git-send-email-vinceh@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: nouveau-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Nouveau" To: Alexandre Courbot , Vince Hsu Cc: Stephen Warren , "nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" , Peter De Schrijver , Linux Kernel Mailing List , Ben Skeggs , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-tegra@vger.kernel.org T24gMjkvMTEvMjAxNCAwOToyMiwgQWxleGFuZHJlIENvdXJib3Qgd3JvdGU6Cj4gT24gRnJpLCBO b3YgMjgsIDIwMTQgYXQgODoxMiBQTSwgVmluY2UgSHN1IDx2aW5jZWhAbnZpZGlhLmNvbT4gd3Jv dGU6Cj4+IFNpZ25lZC1vZmYtYnk6IFZpbmNlIEhzdSA8dmluY2VoQG52aWRpYS5jb20+Cj4gTWFr ZSBzdXJlIHlvdSBhbHdheXMgd3JpdGUgYSBzaG9ydCBzdW1tYXJ5IGZvciB5b3VyIHBhdGNoZXMs IGV2ZW4gaWYKPiB0aGUgdGl0bGUgc291bmRzIHN1ZmZpY2llbnQuCgpJIGFncmVlLiBTb21ldGhp bmcgbGlrZSAiTW92ZSB0aGUgdmJpb3MgcGFyc2luZyBvdXQgb2YgaW5pdCgpIGFuZApjYWxsIGl0 IGNvbmRpdGlvbmFsbHkgaWYgdGhlIHBsYXRmb3JtIGhhcyBhIHZiaW9zLiBOb24tdmJpb3MgcGxh dGZvcm1zCmNhbiB1c2UgdGhlIGN0b3IoKSB0byBpbml0IHRoZSBkYXRhIHN0cnVjdHVyZXMuIi4K Cj4gQXQgdGhlIHZlcnkgbGVhc3QgdGhpcyBwYXRjaCBtYWtlcyB0aGUgY29kZSBlYXNpZXIgdG8g cmVhZCwgc286Cj4KPiBBY2tlZC1ieTogQWxleGFuZHJlIENvdXJib3QgPGFjb3VyYm90QG52aWRp YS5jb20+CkFja2VkLWJ5OiBNYXJ0aW4gUGVyZXMgPG1hcnRpbi5wZXJlc0BmcmVlLmZyPgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpOb3V2ZWF1IG1haWxp bmcgbGlzdApOb3V2ZWF1QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vbm91dmVhdQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932711AbaLAW55 (ORCPT ); Mon, 1 Dec 2014 17:57:57 -0500 Received: from smtp4-g21.free.fr ([212.27.42.4]:51497 "EHLO smtp4-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932458AbaLAW54 (ORCPT ); Mon, 1 Dec 2014 17:57:56 -0500 Message-ID: <547CF263.6070900@free.fr> Date: Mon, 01 Dec 2014 23:57:39 +0100 From: Martin Peres User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Alexandre Courbot , Vince Hsu CC: Stephen Warren , Thierry Reding , Peter De Schrijver , Ben Skeggs , "nouveau@lists.freedesktop.org" , "linux-tegra@vger.kernel.org" , Linux Kernel Mailing List Subject: Re: [RESEND PATCH nouveau 2/3] volt: allow non-bios voltage scaling References: <1417173180-21726-1-git-send-email-vinceh@nvidia.com> <1417173180-21726-2-git-send-email-vinceh@nvidia.com> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/11/2014 09:22, Alexandre Courbot wrote: > On Fri, Nov 28, 2014 at 8:12 PM, Vince Hsu wrote: >> Signed-off-by: Vince Hsu > Make sure you always write a short summary for your patches, even if > the title sounds sufficient. I agree. Something like "Move the vbios parsing out of init() and call it conditionally if the platform has a vbios. Non-vbios platforms can use the ctor() to init the data structures.". > At the very least this patch makes the code easier to read, so: > > Acked-by: Alexandre Courbot Acked-by: Martin Peres