From: Xinwei Kong <kong.kongxinwei@hisilicon.com>
To: Linus Walleij <linus.walleij@linaro.org>,
Haojian Zhuang <haojian.zhuang@linaro.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>
Cc: liguozhu@hisilicon.com
Subject: Re: [PATCH] gpio: pl061: hook request if gpio-ranges avaiable
Date: Tue, 2 Dec 2014 15:39:58 +0800 [thread overview]
Message-ID: <547D6CCE.90504@hisilicon.com> (raw)
In-Reply-To: <CACRpkdbywe9rsz+-0n6R_pHVRQkqbhoCmSnSBWL1mZiRxF5wHg@mail.gmail.com>
On 2014/12/1 21:59, Linus Walleij wrote:
> On Fri, Nov 28, 2014 at 6:00 PM, Haojian Zhuang
> <haojian.zhuang@linaro.org> wrote:
>
>> It's a bit different.
>>
>> The commit 51e13c2475 is used to fix this scenario. There're 8 gpio
>> pins in GPIO CHIP #19. There're pin muxing on gpio152 -
>> gpio155. And there're _no_ pin muxing on gpio156 - gpio159. When
>> user tries to request gpio159, he'll meet failure since the pinctrl device
>> can't cover gpio159. But the pinctrl device is already register for
>> gpio152. In order to distinguish whether the pinctrl device registered,
>> I added pinctrl_ready_for_gpio_range(gpio).
>>
>> In another scenario, there's no back-end pinctrl device for GPIO
>> CHIP #0. So pinctrl_request_gpio() always returns EPROBE_DEFER.
>> The commit 51e13c2475 can't cover this.
>>
>> I suggest to write code in below.
> This looks much simpler. Anyway: Xinwei whatever you come up
> with, include Haojian on To: and get is ACK on the solution.
>
> Yours,
> Linus Walleij
>
hi Linus:
two patches slove the same problem about GPIO PL061. You can understand our
patches and merge it in the next kernel version while ensuring that others use
the kernal will not meet with our problem. Because this bug spend too much
time to debug our board. I will be glad to reduce the kernel bug and help others.
yours
Xinwei
next prev parent reply other threads:[~2014-12-02 7:40 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-21 6:43 [PATCH] gpio: pl061: hook request if gpio-ranges avaiable Yunlei He
2014-11-28 7:53 ` Alexandre Courbot
2014-11-28 12:26 ` Linus Walleij
2014-11-28 17:00 ` Haojian Zhuang
2014-12-01 13:59 ` Linus Walleij
2014-12-02 7:39 ` Xinwei Kong [this message]
2014-12-02 1:39 ` He YunLei
-- strict thread matches above, loose matches on Subject: below --
2014-10-09 9:42 Haojian Zhuang
2014-10-09 9:42 ` Haojian Zhuang
[not found] ` <543665A4.6000404@hisilicon.com>
2014-10-09 10:56 ` Haojian Zhuang
2014-10-09 10:56 ` Haojian Zhuang
2014-10-09 11:15 ` k00278426
2014-10-09 11:15 ` k00278426
2014-10-09 11:23 ` Haojian Zhuang
2014-10-09 11:23 ` Haojian Zhuang
2014-10-17 9:26 ` Alexandre Courbot
2014-10-17 9:26 ` Alexandre Courbot
2013-10-23 6:36 Haojian Zhuang
2013-10-23 6:36 ` Haojian Zhuang
2013-10-28 22:55 ` Linus Walleij
2013-10-28 22:55 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547D6CCE.90504@hisilicon.com \
--to=kong.kongxinwei@hisilicon.com \
--cc=haojian.zhuang@linaro.org \
--cc=liguozhu@hisilicon.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.