From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33407) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xvkuv-00069l-2Y for qemu-devel@nongnu.org; Tue, 02 Dec 2014 05:42:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xvkuj-0002td-Ce for qemu-devel@nongnu.org; Tue, 02 Dec 2014 05:42:49 -0500 Received: from mailapp01.imgtec.com ([195.59.15.196]:40510) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xvkuj-0002sp-6T for qemu-devel@nongnu.org; Tue, 02 Dec 2014 05:42:37 -0500 Message-ID: <547D9796.6090702@imgtec.com> Date: Tue, 2 Dec 2014 10:42:30 +0000 From: Leon Alrae MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] target-mips: Output CP0.Config2-5 in the register dump List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Maciej W. Rozycki" , qemu-devel@nongnu.org Cc: Aurelien Jarno On 18/11/2014 03:20, Maciej W. Rozycki wrote: > @@ -19276,6 +19276,10 @@ void mips_cpu_dump_state(CPUState *cs, F > env->CP0_Status, env->CP0_Cause, env->CP0_EPC); > cpu_fprintf(f, " Config0 0x%08x Config1 0x%08x LLAddr 0x" TARGET_FMT_lx "\n", > env->CP0_Config0, env->CP0_Config1, env->lladdr); > + cpu_fprintf(f, " Config2 0x%08x Config3 0x%08x\n", > + env->CP0_Config2, env->CP0_Config3); > + cpu_fprintf(f, " Config4 0x%08x Config5 0x%08x\n", > + env->CP0_Config4, env->CP0_Config5); Wouldn't it be better to order these registers for example by CP0 Register and Select number rather than putting them at the end? I think it doesn't matter at the moment as there are just few registers printed out, but once we start adding more then probably we would like to avoid having them placed arbitrarily in the output. Regards, Leon