From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH 0/5] kvm: memslots lookup optimization Date: Tue, 02 Dec 2014 14:24:14 +0100 Message-ID: <547DBD7E.1070402@redhat.com> References: <1417454967-4465-1-git-send-email-imammedo@redhat.com> <547CA79A.10206@redhat.com> <20141202085721.2c328a40@nial.usersys.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Gleb Natapov To: Igor Mammedov Return-path: In-Reply-To: <20141202085721.2c328a40@nial.usersys.redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 02/12/2014 08:57, Igor Mammedov wrote: >> On 01/12/2014 18:29, Igor Mammedov wrote: >>> Series speed-ups GFN to memslot lookup time by: >>> * introducing LRU cache, which improves looukup time for >>> same slot workload (typically boot time of Windows and Linux guest) >>> * switching to binary search for GFN to memslot lookup, >>> improving lookup time with large amount of memory slots >>> >>> Igor Mammedov (5): >>> kvm: update_memslots: drop not needed check for the same number of >>> pages >>> kvm: update_memslots: drop not needed check for the same slot >>> kvm: search_memslots: add simple LRU memslot caching >>> kvm: change memslot sorting rule from size to GFN >>> kvm: optimize GFN to memslot lookup with large slots amount >>> >>> include/linux/kvm_host.h | 28 +++++++++++++++++++++++----- >>> virt/kvm/kvm_main.c | 46 ++++++++++++++++++++++++++-------------------- >>> 2 files changed, 49 insertions(+), 25 deletions(-) >>> >> >> Applied patches 1-3 for now, I'm not in the mood for proving that the >> binary search is correct. :) Looks good, thanks. Gleb, any objections? Paolo