From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH] libxl: Fix building libxlu_cfg_y.y with bison 3.0 Date: Tue, 2 Dec 2014 14:00:55 +0000 Message-ID: <547DC617.8020107@citrix.com> References: <1417325015-22354-1-git-send-email-eswierk@skyportsystems.com> <1417426933.23604.77.camel@citrix.com> <20141201121955.GB19889@zion.uk.xensource.com> <1417528036.24320.32.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Xvo0j-0003nm-CK for xen-devel@lists.xenproject.org; Tue, 02 Dec 2014 14:01:01 +0000 In-Reply-To: <1417528036.24320.32.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , Wei Liu , Konrad Rzeszutek Wilk Cc: xen-devel@lists.xenproject.org, Ed Swierk , Ian Jackson List-Id: xen-devel@lists.xenproject.org On 02/12/14 13:47, Ian Campbell wrote: > On Mon, 2014-12-01 at 12:19 +0000, Wei Liu wrote: >> On Mon, Dec 01, 2014 at 09:42:13AM +0000, Ian Campbell wrote: >>> On Sat, 2014-11-29 at 21:23 -0800, Ed Swierk wrote: >>>> - Use %lex-param instead of obsolete YYLEX_PARAM to override lex scanner >>>> parameter >>>> - Change deprecated %name-prefix= to %name-prefix >>>> >>>> Tested against bison 2.4.1 and 3.0.2. >>>> >>>> Signed-off-by: Ed Swierk >>> Copying Ian J who is the bison guy among the toolstack maintainers. >>> >> FWIW I can confirm that libxlu_cfg_y.y won't build in Debian Jessie >> (bison 3.0.2) as is. And this patch fixes the problem for me. > That would seem like a pretty strong case for 4.5, *except* we ship the > generated files so it should be possible to build anywhere without > requiring any version of bison at all. If Bison is installed then > "./configure BISON=/bin/true" or some such might be needed to stop it > trying to regenerate. > > Konrad, any thoughts. The automatically generating doesn't actually work. Depending on the relative timestamps caused by a SCM checkout, or a tarball extraction, the files will be attempted to be regenerated. These files are regenerated in the XenServer build, simply because of their order in the archived tarball. ~Andrew