From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36771)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <olivier.matz@6wind.com>) id 1XvqVr-00037d-Vo
	for qemu-devel@nongnu.org; Tue, 02 Dec 2014 11:41:26 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <olivier.matz@6wind.com>) id 1XvqVi-0004H2-An
	for qemu-devel@nongnu.org; Tue, 02 Dec 2014 11:41:16 -0500
Received: from mail-wi0-f171.google.com ([209.85.212.171]:41331)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <olivier.matz@6wind.com>) id 1XvqVi-0004GM-5N
	for qemu-devel@nongnu.org; Tue, 02 Dec 2014 11:41:10 -0500
Received: by mail-wi0-f171.google.com with SMTP id bs8so28654625wib.4
	for <qemu-devel@nongnu.org>; Tue, 02 Dec 2014 08:41:08 -0800 (PST)
Message-ID: <547DEB98.4090805@6wind.com>
Date: Tue, 02 Dec 2014 17:40:56 +0100
From: Olivier MATZ <olivier.matz@6wind.com>
MIME-Version: 1.0
References: <EDCDDC5F3D468742B7A0048DF68542612FDF705C@IRSMSX104.ger.corp.intel.com>
	<20141202122403.GA2414@redhat.com>
In-Reply-To: <20141202122403.GA2414@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] Vhost-user - multi queue support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>, "Long, Thomas" <thomas.long@intel.com>
Cc: "Ryan, Brendan" <brendan.ryan@intel.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "n.nikolaev@virtualopensystems.com" <n.nikolaev@virtualopensystems.com>

Hi All,

On 12/02/2014 01:24 PM, Michael S. Tsirkin wrote:
> On Tue, Dec 02, 2014 at 11:42:22AM +0000, Long, Thomas wrote:
>> Hi All,
>>
>> I’m just wondering what the status is with regards to supporting multi-queue in
>> Vhost-user?
>>
>> I see that Nikolaev has developed a patch to support this feature:
>>
>> https://github.com/SnabbCo/qemu/commit/f41eeccf4ab6ea5970e2941ce2de0aae893b10f9
>>
>> Are there any current plans to pull either this patch or a different patch into
>> QEMU ?

I reviewed the patch and it looks good to me. One small comment: if
nc->info_str is set to ("vhost-user%d to %s", i, chr->label), it would
make sense to display it when the event callback:

--- a/net/vhost-user.c
+++ b/net/vhost-user.c
@@ -122,36 +122,39 @@ static void net_vhost_user_event(void *opaque, int 
event)
      case CHR_EVENT_OPENED:
          vhost_user_start(s);
          net_vhost_link_down(s, false);
-        error_report("chardev \"%s\" went up\n", s->chr->label);
+        error_report("chardev \"%s\" went up\n", s->nc.info_str);
          break;
      case CHR_EVENT_CLOSED:
          net_vhost_link_down(s, true);
          vhost_user_stop(s);
-        error_report("chardev \"%s\" went down\n", s->chr->label);
+        error_report("chardev \"%s\" went down\n", s->nc.info_str);
          break;
      }
  }


If it helps, I can submit a patch based on Nikolaev's on the list.

Regards,
Olivier