From: Lars-Peter Clausen <lars@metafoo.de>
To: "Babu, Ramesh" <ramesh.babu@intel.com>,
Dan Carpenter <dan.carpenter@oracle.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: Re: ASoC: core: Call mute for cpu dais as well
Date: Tue, 02 Dec 2014 20:26:54 +0100 [thread overview]
Message-ID: <547E127E.6080408@metafoo.de> (raw)
In-Reply-To: <32F4D3A311A1404B92CF923AFF38C3C52E12D4DA@BGSMSX104.gar.corp.intel.com>
On 12/02/2014 06:13 PM, Babu, Ramesh wrote:
>> This is a semi-automatic email about new static checker warnings.
>>
>> The patch ae11601b80b9: "ASoC: core: Call mute for cpu dais as well"
>> from Oct 15, 2014, leads to the following Smatch complaint:
>>
>> sound/soc/soc-pcm.c:777 soc_pcm_prepare()
>> error: we previously assumed 'cpu_dai->driver->ops' could be null
>> (see line 755)
>>
>> sound/soc/soc-pcm.c
>> 754
>> 755 if (cpu_dai->driver->ops && cpu_dai->driver->ops->prepare)
>> {
>> ^^^^^^^^^^^^^^^^^^^^ I don't think this can be NULL. Probably
>> we should remove this check.
> Nope. ops can be NULL.
It can't. If it is the core will update it to point to null_dai_ops.
- Lars
prev parent reply other threads:[~2014-12-02 19:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-27 16:15 ASoC: core: Call mute for cpu dais as well Dan Carpenter
2014-12-02 17:13 ` Babu, Ramesh
2014-12-02 19:26 ` Lars-Peter Clausen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547E127E.6080408@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=dan.carpenter@oracle.com \
--cc=ramesh.babu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.