All of lore.kernel.org
 help / color / mirror / Atom feed
From: Phillip Susi <psusi@ubuntu.com>
To: Francis Moreau <francis.moro@gmail.com>,
	"Dale R. Worley" <worley@alum.mit.edu>,
	util-linux@vger.kernel.org, Karel Zak <kzak@redhat.com>,
	gabeblack@chromium.org, gwendal@chromium.org
Subject: Re: losetup on a image file containing (GPT) partition doesn't create partition devices
Date: Tue, 02 Dec 2014 14:29:59 -0500	[thread overview]
Message-ID: <547E1337.1080702@ubuntu.com> (raw)
In-Reply-To: <20141027201625.GA25833@vapier>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 10/27/2014 4:16 PM, Mike Frysinger wrote:
> we've been tracking the same bug in Chromium OS: 
> http://crbug.com/411693 basically, under load, using `losetup -P`
> randomly fails to create the relevant partition nodes.  atm we have
> hacks in place to call `blockdev --rereadpt` when it looks like the
> kernel has failed us.
> 
> it would be nice if the kernel didn't ignore the result of the
> ioctl thus allowing all errors to go unnoticed.  you can see this
> in drivers/block/loop.c where it calls ioctl_by_bdev multiple times
> and doesn't check the return value.
> 
> since all current kernels are broken though, and might be for the
> foreseeable future, having losetup issue the ioctl itself might be
> a good tradeoff.  i think it'd trigger unnecessary overhead
> (rescanning the device after it already worked), but seems better
> than having losetup try and check other sources (like if arbitrary
> partition nodes were created).

As long as the kernel has a flag that is supposed to cause it to
interpret the partition table, then it should *work* and not silently
fail.  This is a bug in the kernel that should be fixed.

As a workaround though, you might consider just not using losetup -P
in the first place and just run partx when you want to activate
partitions.  This also has the advantage of working even when the loop
module is not loaded with the max_parts argument.





-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (MingW32)

iQEcBAEBAgAGBQJUfhM3AAoJENRVrw2cjl5RvhcH/iaVXICM0zOxyc7YFTeQ4Tkk
5NgLJpZGy8yp4maxJcoPJ8Eryfs6SuQdglVtfjtGLhTOVEvUObe9ALey1/oilfUI
RCzBYyr+j9raD09MMA+yiNsYpeeptvWPRnPZF9TahRKWTMYSiOZoDMGQjvc1Rj3w
uSLDcmcknt/YA0nOSml8xuI84k1EeaV/s9Gt5Q9Rgjw8kvv3C5xROM9JfgC7unY8
4nF3n8F5jfGeGU/NtJAYJn+WnsX69AyAvveeo5e3GdO43NP818rF2K/6d9tyyN0Z
5159ZqRur75m/pC2PqQFMeoJ/3vefbWEMrQ3D73yH22f41ignZobzKHbGcDygD4=
=qPDy
-----END PGP SIGNATURE-----

  reply	other threads:[~2014-12-02 19:30 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-03  9:44 losetup on a image file containing (GPT) partition doesn't create partition devices Francis Moreau
2014-10-03 14:29 ` Dale R. Worley
2014-10-03 19:58   ` Dale R. Worley
2014-10-03 20:26     ` Francis Moreau
2014-10-04 19:35       ` Francis Moreau
2014-10-06 15:47         ` Dale R. Worley
2014-10-06 15:56           ` Francis Moreau
2014-10-27 20:16             ` Mike Frysinger
2014-12-02 19:29               ` Phillip Susi [this message]
2014-12-03  8:36                 ` Karel Zak
2014-12-03 14:49                   ` Phillip Susi
2014-12-03 16:10                     ` Karel Zak
2015-02-16  8:52                 ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=547E1337.1080702@ubuntu.com \
    --to=psusi@ubuntu.com \
    --cc=francis.moro@gmail.com \
    --cc=gabeblack@chromium.org \
    --cc=gwendal@chromium.org \
    --cc=kzak@redhat.com \
    --cc=util-linux@vger.kernel.org \
    --cc=worley@alum.mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.