From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Yan Subject: Re: [PATCH v15 06/12] dt-bindings: add document for dw_hdmi Date: Wed, 03 Dec 2014 08:54:41 +0800 Message-ID: <547E5F51.2090800@rock-chips.com> References: <1417505778-18341-1-git-send-email-andy.yan@rock-chips.com> <1417506124-18626-1-git-send-email-andy.yan@rock-chips.com> <1417544629.3411.15.camel@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1417544629.3411.15.camel@pengutronix.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Philipp Zabel Cc: Mark Rutland , heiko@sntech.de, airlied@linux.ie, dri-devel@lists.freedesktop.org, ykk@rock-chips.com, devel@driverdev.osuosl.org, Arnd Bergmann , linux-rockchip@lists.infradead.org, Grant Likely , rmk+kernel@arm.linux.org.uk, jay.xu@rock-chips.com, devicetree@vger.kernel.org, Zubair.Kakakhel@imgtec.com, Pawel Moll , Ian Campbell , Inki Dae , Rob Herring , Sean Paul , Dave Airlie , mark.yao@rock-chips.com, fabio.estevam@freescale.com, Josh Boyer , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, djkurtz@google.com, Kumar Gala , Shawn Guo , vladimir_zapolskiy@mentor.comLucas Stach List-Id: devicetree@vger.kernel.org SGkgUGhpbGlwcDoKT24gMjAxNOW5tDEy5pyIMDPml6UgMDI6MjMsIFBoaWxpcHAgWmFiZWwgd3Jv dGU6Cj4gSGkgQW5keSwKPgo+IEFtIERpZW5zdGFnLCBkZW4gMDIuMTIuMjAxNCwgMTU6NDIgKzA4 MDAgc2NocmllYiBBbmR5IFlhbjoKPj4gZGlmZiAtLWdpdCBhL0RvY3VtZW50YXRpb24vZGV2aWNl dHJlZS9iaW5kaW5ncy9kcm0vYnJpZGdlL2R3X2hkbWkudHh0IGIvRG9jdW1lbnRhdGlvbi9kZXZp Y2V0cmVlL2JpbmRpbmdzL2RybS9icmlkZ2UvZHdfaGRtaS50eHQKPj4gbmV3IGZpbGUgbW9kZSAx MDA2NDQKPj4gaW5kZXggMDAwMDAwMC4uMTA3YzFjYQo+PiAtLS0gL2Rldi9udWxsCj4+ICsrKyBi L0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9kcm0vYnJpZGdlL2R3X2hkbWkudHh0 Cj4+IEBAIC0wLDAgKzEsNDAgQEAKPj4gK0Rlc2lnbldhcmUgSERNSSBicmlkZ2UgYmluZGluZ3MK Pj4gKwo+PiArUmVxdWlyZWQgcHJvcGVyaXRpZXM6Cj4+ICstIGNvbXBhdGlibGU6IHBsYXRmb3Jt IHNwZWNpZmljIHN1Y2ggYXM6Cj4+ICsgICAqICJmc2wsaW14NnEtaGRtaSIKPj4gKyAgICogImZz bCxpbXg2ZGwtaGRtaSIKPj4gKyAgICogInJvY2tjaGlwLHJrMzI4OC1kdy1oZG1pIgo+IEkgdGhp bmsgd2Ugc2hvdWxkIGFkZCBhIGNvbW1vbiBjb21wYXRpYmxlIHZhbHVlICJzbnBzLGR3LWhkbWkt dHgiIGhlcmU6Cj4KPiAJY29tcGF0aWJsZSA9ICJmc2wsaW14NnEtaGRtaSIsICJzbnBzLGR3LWhk bWktdHgiOwo+CiAgICAgIEhvdyBhYm91dCAic25wcyxkdy1oZG1pIiwgYmVjYXVzZSB0aGUgZHJp dmVyIGlzIG5vdCBvbmx5IGFib3V0CiAgIGhkbWkgdHgsIGJ1dCBhbHNvIGluY2x1ZGUgaGRtaSBw aHkuCiAgICAgICBJZiB3ZSBhZGQgc3VjaCBjb21wYXRpYmxlIHZhbHVlLCBkbyB3ZSBoYXZlIHRv IGltcGxlbWVudCBhbm90aGVyCiAgICBwbGF0Zm9ybSBkcml2ZXIgbGlrZSBkd19oZG1pLXBsdGZt LmMgd2l0aCB0aGUgCmNvbXBhdGlibGU9InNucHMsZHctaGRtaSIgLAogICAgb3IganVzdCBpbmNs dWRlIHRoZSBjb21wYXRpYmxlIHZhbHVlIGluIGR3X2hkbWktaW14LmMgYW5kIApkd19oZG1pLXJv Y2tjaGlwLmM/Cj4+ICstIHJlZzogUGh5c2ljYWwgYmFzZSBhZGRyZXNzIGFuZCBsZW5ndGggb2Yg dGhlIGNvbnRyb2xsZXIncyByZWdpc3RlcnMuCj4+ICstIGRkYy1pMmMtYnVzOiBwaGFuZGxlIG9m IGFuIEkyQyBjb250cm9sbGVyIHVzZWQgZm9yIEREQyBFRElEIHByb2JpbmcKPiBCZXR0ZXIgbWFr ZSBkZGMtaTJjLWJ1cyBvcHRpb25hbCwgc2VlIHRoZSBvdGhlciB0aHJlYWQgYWJvdXQgdGhlIGRk YyBpMmMKPiBtYXN0ZXIuCj4KPj4gKy0gaW50ZXJydXB0czogVGhlIEhETUkgaW50ZXJydXB0IG51 bWJlcgo+PiArCj4+ICtPcHRpb25hbCBwcm9wZXJ0aWVzCj4+ICstIHJlZy1pby13aWR0aDogdGhl IHdpZHRoIG9mIHRoZSByZWc6MSw0LCBkZWZhdWx0IHNldCB0byAxIGlmIG5vdCBwcmVzZW50Cj4+ ICsKPj4gK0V4YW1wbGU6Cj4+ICsJaGRtaTogaGRtaUAwMTIwMDAwIHsKPj4gKwkJY29tcGF0aWJs ZSA9ICJmc2wsaW14NnEtaGRtaSI7Cj4+ICsJCXJlZyA9IDwweDAwMTIwMDAwIDB4OTAwMD47Cj4+ ICsJCWludGVycnVwdHMgPSA8MCAxMTUgMHgwND47Cj4+ICsJCWdwciA9IDwmZ3ByPjsKPj4gKwkJ Y2xvY2tzID0gPCZjbGtzIDEyMz4sIDwmY2xrcyAxMjQ+Owo+PiArCQljbG9jay1uYW1lcyA9ICJp YWhiIiwgImlzZnIiOwo+PiArCQlkZGMtaTJjLWJ1cyA9IDwmaTJjMj47Cj4+ICsKPj4gKwkJcG9y dEAwIHsKPj4gKwkJCXJlZyA9IDwwPjsKPj4gKwo+PiArCQkJaGRtaV9tdXhfMDogZW5kcG9pbnQg ewo+PiArCQkJCXJlbW90ZS1lbmRwb2ludCA9IDwmaXB1MV9kaTBfaGRtaT47Cj4+ICsJCQl9Owo+ PiArCQl9Owo+PiArCj4+ICsJCXBvcnRAMSB7Cj4+ICsJCQlyZWcgPSA8MT47Cj4+ICsKPj4gKwkJ CWhkbWlfbXV4XzE6IGVuZHBvaW50IHsKPj4gKwkJCQlyZW1vdGUtZW5kcG9pbnQgPSA8JmlwdTFf ZGkxX2hkbWk+Owo+PiArCQkJfTsKPj4gKwkJfTsKPj4gKwl9Owo+IHJlZ2FyZHMKPiBQaGlsaXBw Cj4KPgo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4g TGludXgtcm9ja2NoaXAgbWFpbGluZyBsaXN0Cj4gTGludXgtcm9ja2NoaXBAbGlzdHMuaW5mcmFk ZWFkLm9yZwo+IGh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGlu dXgtcm9ja2NoaXAKPgo+Cj4KCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpkZXZlbCBtYWlsaW5nIGxpc3QKZGV2ZWxAbGludXhkcml2ZXJwcm9qZWN0Lm9y ZwpodHRwOi8vZHJpdmVyZGV2LmxpbnV4ZHJpdmVycHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5m by9kcml2ZXJkZXYtZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751433AbaLCAy5 (ORCPT ); Tue, 2 Dec 2014 19:54:57 -0500 Received: from lucky1.263xmail.com ([211.157.147.131]:43183 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751212AbaLCAyz (ORCPT ); Tue, 2 Dec 2014 19:54:55 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: andy.yan@rock-chips.com X-FST-TO: l.stach@pengutronix.de X-SENDER-IP: 121.15.173.1 X-LOGIN-NAME: andy.yan@rock-chips.com X-UNIQUE-TAG: <37326cf44bc97c3057811ec533281784> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <547E5F51.2090800@rock-chips.com> Date: Wed, 03 Dec 2014 08:54:41 +0800 From: Andy Yan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Philipp Zabel CC: Mark Rutland , heiko@sntech.de, airlied@linux.ie, dri-devel@lists.freedesktop.org, ykk@rock-chips.com, devel@driverdev.osuosl.org, Pawel Moll , linux-rockchip@lists.infradead.org, Grant Likely , Dave Airlie , jay.xu@rock-chips.com, devicetree@vger.kernel.org, Zubair.Kakakhel@imgtec.com, Arnd Bergmann , Ian Campbell , Inki Dae , Rob Herring , Sean Paul , rmk+kernel@arm.linux.org.uk, mark.yao@rock-chips.com, fabio.estevam@freescale.com, Josh Boyer , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, djkurtz@google.com, Kumar Gala , Shawn Guo , vladimir_zapolskiy@mentor.com, Lucas Stach Subject: Re: [PATCH v15 06/12] dt-bindings: add document for dw_hdmi References: <1417505778-18341-1-git-send-email-andy.yan@rock-chips.com> <1417506124-18626-1-git-send-email-andy.yan@rock-chips.com> <1417544629.3411.15.camel@pengutronix.de> In-Reply-To: <1417544629.3411.15.camel@pengutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Philipp: On 2014年12月03日 02:23, Philipp Zabel wrote: > Hi Andy, > > Am Dienstag, den 02.12.2014, 15:42 +0800 schrieb Andy Yan: >> diff --git a/Documentation/devicetree/bindings/drm/bridge/dw_hdmi.txt b/Documentation/devicetree/bindings/drm/bridge/dw_hdmi.txt >> new file mode 100644 >> index 0000000..107c1ca >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/drm/bridge/dw_hdmi.txt >> @@ -0,0 +1,40 @@ >> +DesignWare HDMI bridge bindings >> + >> +Required properities: >> +- compatible: platform specific such as: >> + * "fsl,imx6q-hdmi" >> + * "fsl,imx6dl-hdmi" >> + * "rockchip,rk3288-dw-hdmi" > I think we should add a common compatible value "snps,dw-hdmi-tx" here: > > compatible = "fsl,imx6q-hdmi", "snps,dw-hdmi-tx"; > How about "snps,dw-hdmi", because the driver is not only about hdmi tx, but also include hdmi phy. If we add such compatible value, do we have to implement another platform driver like dw_hdmi-pltfm.c with the compatible="snps,dw-hdmi" , or just include the compatible value in dw_hdmi-imx.c and dw_hdmi-rockchip.c? >> +- reg: Physical base address and length of the controller's registers. >> +- ddc-i2c-bus: phandle of an I2C controller used for DDC EDID probing > Better make ddc-i2c-bus optional, see the other thread about the ddc i2c > master. > >> +- interrupts: The HDMI interrupt number >> + >> +Optional properties >> +- reg-io-width: the width of the reg:1,4, default set to 1 if not present >> + >> +Example: >> + hdmi: hdmi@0120000 { >> + compatible = "fsl,imx6q-hdmi"; >> + reg = <0x00120000 0x9000>; >> + interrupts = <0 115 0x04>; >> + gpr = <&gpr>; >> + clocks = <&clks 123>, <&clks 124>; >> + clock-names = "iahb", "isfr"; >> + ddc-i2c-bus = <&i2c2>; >> + >> + port@0 { >> + reg = <0>; >> + >> + hdmi_mux_0: endpoint { >> + remote-endpoint = <&ipu1_di0_hdmi>; >> + }; >> + }; >> + >> + port@1 { >> + reg = <1>; >> + >> + hdmi_mux_1: endpoint { >> + remote-endpoint = <&ipu1_di1_hdmi>; >> + }; >> + }; >> + }; > regards > Philipp > > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip > > >