All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Kim, Milo" <milo.kim@ti.com>
To: Sean Paul <seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Cc: linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
	cooloney-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	"Stéphane Marchesin"
	<marcheu-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
	"Aaron Durbin" <adurbin-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Subject: Re: [PATCH v2 2/2] backlight/lp855x: Add supply regulator to lp855x
Date: Wed, 03 Dec 2014 00:54:52 +0000	[thread overview]
Message-ID: <547E5F5C.40406@ti.com> (raw)
In-Reply-To: <1417468079-4990-1-git-send-email-seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>

On 12/2/2014 6:07 AM, Sean Paul wrote:
> This patch adds a supply regulator to the lp855x platform data to facilitate
> powering on/off the 3V rail attached to the controller.
>
> Cc: Stéphane Marchesin<marcheu@chromium.org>
> Cc: Aaron Durbin<adurbin@chromium.org>
> Signed-off-by: Sean Paul<seanpaul@chromium.org>

Acked-by: Milo Kim <milo.kim@ti.com>

For effective power consumption, regulator could be enabled/disabled 
based on backlight control flow.
For example, when the brightness is 0, then call regulator_disable()
when the brightness is > 0 and regulator is off, then call 
regulator_enable().
However, I'd like to send ACK to this patch.

Sean,
Could you send the patch-set with the first one - 'backlight/lp855x: 
Refactor dt parsing code'? I'll send my ACK as well.
For the backlight maintainers, it would be better to apply them together.

Thanks!

Best regards,
Milo

WARNING: multiple messages have this Message-ID (diff)
From: "Kim, Milo" <milo.kim-l0cyMroinI0@public.gmane.org>
To: Sean Paul <seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Cc: linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
	cooloney-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	"Stéphane Marchesin"
	<marcheu-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
	"Aaron Durbin" <adurbin-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Subject: Re: [PATCH v2 2/2] backlight/lp855x: Add supply regulator to lp855x
Date: Wed, 3 Dec 2014 09:54:52 +0900	[thread overview]
Message-ID: <547E5F5C.40406@ti.com> (raw)
In-Reply-To: <1417468079-4990-1-git-send-email-seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>

On 12/2/2014 6:07 AM, Sean Paul wrote:
> This patch adds a supply regulator to the lp855x platform data to facilitate
> powering on/off the 3V rail attached to the controller.
>
> Cc: Stéphane Marchesin<marcheu-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
> Cc: Aaron Durbin<adurbin-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
> Signed-off-by: Sean Paul<seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>

Acked-by: Milo Kim <milo.kim-l0cyMroinI0@public.gmane.org>

For effective power consumption, regulator could be enabled/disabled 
based on backlight control flow.
For example, when the brightness is 0, then call regulator_disable()
when the brightness is > 0 and regulator is off, then call 
regulator_enable().
However, I'd like to send ACK to this patch.

Sean,
Could you send the patch-set with the first one - 'backlight/lp855x: 
Refactor dt parsing code'? I'll send my ACK as well.
For the backlight maintainers, it would be better to apply them together.

Thanks!

Best regards,
Milo
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2014-12-03  0:54 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-26 19:11 [PATCH 1/2] backlight/lp855x: Refactor dt parsing code Sean Paul
2014-11-26 19:11 ` Sean Paul
     [not found] ` <1417029064-12460-1-git-send-email-seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2014-11-26 19:11   ` [PATCH 2/2] backlight/lp855x: Add supply regulator to lp855x Sean Paul
2014-11-26 19:11     ` Sean Paul
     [not found]     ` <1417029064-12460-2-git-send-email-seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2014-11-27  1:32       ` Kim, Milo
2014-11-27  1:32         ` Kim, Milo
     [not found]         ` <54767F43.2060901-l0cyMroinI0@public.gmane.org>
2014-11-27 12:23           ` Sean Paul
2014-11-27 12:23             ` Sean Paul
2014-12-01 21:07           ` [PATCH v2 " Sean Paul
2014-12-01 21:07             ` Sean Paul
     [not found]             ` <1417468079-4990-1-git-send-email-seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2014-12-03  0:54               ` Kim, Milo [this message]
2014-12-03  0:54                 ` Kim, Milo
     [not found]                 ` <547E5F5C.40406-l0cyMroinI0@public.gmane.org>
2014-12-03  1:01                   ` Sean Paul
2014-12-03  1:01                     ` Sean Paul
     [not found]                     ` <CAOw6vbLB=3An9+Juda=5Yx1vnuCgDsp=ucKNQ3B6AtiLv=FLYg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-12-03  1:15                       ` Kim, Milo
2014-12-03  1:15                         ` Kim, Milo
     [not found]                         ` <547E643A.7070202-l0cyMroinI0@public.gmane.org>
2014-12-03  1:33                           ` Bryan Wu
2014-12-03  1:33                             ` Bryan Wu
2014-11-27  1:32   ` [PATCH 1/2] backlight/lp855x: Refactor dt parsing code Kim, Milo
2014-11-27  1:32     ` Kim, Milo
     [not found]     ` <54767F37.3020006-l0cyMroinI0@public.gmane.org>
2014-11-27 12:22       ` Sean Paul
2014-11-27 12:22         ` Sean Paul
  -- strict thread matches above, loose matches on Subject: below --
2014-12-03  1:39 [PATCH v2 " Sean Paul
     [not found] ` <1417570752-23633-1-git-send-email-seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2014-12-03  1:39   ` [PATCH v2 2/2] backlight/lp855x: Add supply regulator to lp855x Sean Paul
2014-12-03  1:39     ` Sean Paul
     [not found]     ` <1417570752-23633-2-git-send-email-seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2014-12-03  1:57       ` Kim, Milo
2014-12-03  1:57         ` Kim, Milo
2014-12-03  2:06       ` Jingoo Han
2014-12-03  2:06         ` Jingoo Han
2014-12-03  2:13       ` Bryan Wu
2014-12-03  2:13         ` Bryan Wu
2014-12-03 10:15       ` Lee Jones
2014-12-03 10:15         ` Lee Jones
2014-12-03 14:11       ` Arnd Bergmann
2014-12-03 14:11         ` Arnd Bergmann
2014-12-03 17:28         ` Sean Paul
2014-12-03 17:28           ` Sean Paul
2014-12-09  3:03         ` Kim, Milo
2014-12-09  3:03           ` Kim, Milo
     [not found]           ` <54866695.3050307-l0cyMroinI0@public.gmane.org>
2014-12-09  3:46             ` Jingoo Han
2014-12-09  3:46               ` Jingoo Han
     [not found]               ` <000a01d01362$aee684d0$0cb38e70$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-12-09  8:13                 ` Arnd Bergmann
2014-12-09  8:13                   ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=547E5F5C.40406@ti.com \
    --to=milo.kim@ti.com \
    --cc=adurbin-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    --cc=cooloney-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=marcheu-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    --cc=seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.