From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Yan Subject: Re: [PATCH v15 06/12] dt-bindings: add document for dw_hdmi Date: Wed, 03 Dec 2014 17:43:23 +0800 Message-ID: <547EDB3B.9010907@rock-chips.com> References: <1417505778-18341-1-git-send-email-andy.yan@rock-chips.com> <1417506124-18626-1-git-send-email-andy.yan@rock-chips.com> <1417544629.3411.15.camel@pengutronix.de> <547E5F51.2090800@rock-chips.com> <1417598398.5124.2.camel@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1417598398.5124.2.camel@pengutronix.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Philipp Zabel Cc: Mark Rutland , heiko@sntech.de, airlied@linux.ie, dri-devel@lists.freedesktop.org, ykk@rock-chips.com, devel@driverdev.osuosl.org, Pawel Moll , linux-rockchip@lists.infradead.org, Grant Likely , Dave Airlie , jay.xu@rock-chips.com, devicetree@vger.kernel.org, Zubair.Kakakhel@imgtec.com, Arnd Bergmann , Ian Campbell , Inki Dae , Rob Herring , Sean Paul , rmk+kernel@arm.linux.org.uk, mark.yao@rock-chips.com, fabio.estevam@freescale.com, Josh Boyer , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, djkurtz@google.com, Kumar Gala , Shawn Guo , vladimir_zapolskiy@mentor.com List-Id: devicetree@vger.kernel.org SGkgUGhpbGlwcDoKT24gMjAxNOW5tDEy5pyIMDPml6UgMTc6MTksIFBoaWxpcHAgWmFiZWwgd3Jv dGU6Cj4gSGkgQW5keSwKPgo+IEFtIE1pdHR3b2NoLCBkZW4gMDMuMTIuMjAxNCwgMDg6NTQgKzA4 MDAgc2NocmllYiBBbmR5IFlhbjoKPj4+PiArUmVxdWlyZWQgcHJvcGVyaXRpZXM6Cj4+Pj4gKy0g Y29tcGF0aWJsZTogcGxhdGZvcm0gc3BlY2lmaWMgc3VjaCBhczoKPj4+PiArICAgKiAiZnNsLGlt eDZxLWhkbWkiCj4+Pj4gKyAgICogImZzbCxpbXg2ZGwtaGRtaSIKPj4+PiArICAgKiAicm9ja2No aXAscmszMjg4LWR3LWhkbWkiCj4+PiBJIHRoaW5rIHdlIHNob3VsZCBhZGQgYSBjb21tb24gY29t cGF0aWJsZSB2YWx1ZSAic25wcyxkdy1oZG1pLXR4IiBoZXJlOgo+Pj4KPj4+IAljb21wYXRpYmxl ID0gImZzbCxpbXg2cS1oZG1pIiwgInNucHMsZHctaGRtaS10eCI7Cj4+Pgo+PiAgICAgICAgSG93 IGFib3V0ICJzbnBzLGR3LWhkbWkiLCBiZWNhdXNlIHRoZSBkcml2ZXIgaXMgbm90IG9ubHkgYWJv dXQKPj4gICAgIGhkbWkgdHgsIGJ1dCBhbHNvIGluY2x1ZGUgaGRtaSBwaHkuCj4gU3lub3BzeXMg Y2FsbCB0aGUgd2hvbGUgbW9kdWxlCj4gIkRlc2lnbldhcmUgSERNSSBUcmFuc21pdHRlciAoVFgp IElQIFNvbHV0aW9uIjoKPgo+IGh0dHBzOi8vd3d3LnN5bm9wc3lzLmNvbS9kdy9pcGRpci5waHA/ ZHM9ZHdjX2hkbWlfMTRfY3Nkc190eAo+IGh0dHBzOi8vd3d3LnN5bm9wc3lzLmNvbS9kdy9pcGRp ci5waHA/ZHM9ZHdjX2hkbWlfMjBfY3Nkc190eAo+Cj4gVGhhdCBpbmNsdWRlcyB0aGUgUEhZLiBJ J2QgcHJlZmVyIGtlZXBpbmcgdGhlIC10eCBpbiB0aGVyZSB0bwo+IGRpZmZlcmVudGlhdGUgZnJv bSBhIHBvc3NpYmxlIGZ1dHVyZSAic25wcyxkdy1oZG1pLXJ4IjoKPgo+IGh0dHBzOi8vd3d3LnN5 bm9wc3lzLmNvbS9kdy9pcGRpci5waHA/ZHM9ZHdjX2hkbWlfMTRfY3Nkc19yeAo+IGh0dHBzOi8v d3d3LnN5bm9wc3lzLmNvbS9kdy9pcGRpci5waHA/ZHM9ZHdjX2hkbWlfMjBfY3Nkc19yeAoKICAg T2ssIEkgd2lsbCBhZGQgdGhlIGNvbXBhdGlibGUgInNucHMsIGR3LWhkbWktdHgiLAogICAgU28g ZG8gSSBuZWVkIHRvIGFkZCB0aGlzIHZhbHVlIHRvIGlteDZkbC5kdHNpPwo+PiAgICAgICAgIElm IHdlIGFkZCBzdWNoIGNvbXBhdGlibGUgdmFsdWUsIGRvIHdlIGhhdmUgdG8gaW1wbGVtZW50IGFu b3RoZXIKPj4gICAgICBwbGF0Zm9ybSBkcml2ZXIgbGlrZSBkd19oZG1pLXBsdGZtLmMgd2l0aCB0 aGUKPj4gY29tcGF0aWJsZT0ic25wcyxkdy1oZG1pIiAsCj4+ICAgICAgb3IganVzdCBpbmNsdWRl IHRoZSBjb21wYXRpYmxlIHZhbHVlIGluIGR3X2hkbWktaW14LmMgYW5kCj4+IGR3X2hkbWktcm9j a2NoaXAuYz8KPiBUaGF0IGNvbW1vbiBjb21wYXRpYmxlIGRvZXNuJ3QgaGF2ZSB0byBiZSB1c2Vk IGJ5IGFueSBkcml2ZXIuIEl0J3MganVzdAo+IHRoZXJlIHRvIHNob3cgdGhlc2UgYXJlIHRoZSBz YW1lL3NpbWlsYXIgSVAgY29yZS4KPiBJZiBhIGNvbW1vbiBkcml2ZXIgd2l0aG91dCBhbnkgU29D IHNwZWNpZmljIGtub3dsZWRnZSBjb3VsZCBiZSB3cml0dGVuLAo+IHRoYXQgb25lIHdvdWxkIG1h dGNoIGFnYWluc3QgdGhlIGNvbW1vbiBjb21wYXRpYmxlLgo+Cj4gcmVnYXJkcwo+IFBoaWxpcHAK Pgo+Cj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBM aW51eC1yb2NrY2hpcCBtYWlsaW5nIGxpc3QKPiBMaW51eC1yb2NrY2hpcEBsaXN0cy5pbmZyYWRl YWQub3JnCj4gaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51 eC1yb2NrY2hpcAo+Cj4KPgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCmRldmVsIG1haWxpbmcgbGlzdApkZXZlbEBsaW51eGRyaXZlcnByb2plY3Qub3Jn Cmh0dHA6Ly9kcml2ZXJkZXYubGludXhkcml2ZXJwcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZv L2RyaXZlcmRldi1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752362AbaLCJne (ORCPT ); Wed, 3 Dec 2014 04:43:34 -0500 Received: from lucky1.263xmail.com ([211.157.147.131]:40610 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751866AbaLCJnc (ORCPT ); Wed, 3 Dec 2014 04:43:32 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: andy.yan@rock-chips.com X-FST-TO: l.stach@pengutronix.de X-SENDER-IP: 121.15.173.1 X-LOGIN-NAME: andy.yan@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <547EDB3B.9010907@rock-chips.com> Date: Wed, 03 Dec 2014 17:43:23 +0800 From: Andy Yan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Philipp Zabel CC: Mark Rutland , heiko@sntech.de, airlied@linux.ie, dri-devel@lists.freedesktop.org, ykk@rock-chips.com, devel@driverdev.osuosl.org, Arnd Bergmann , linux-rockchip@lists.infradead.org, Grant Likely , rmk+kernel@arm.linux.org.uk, jay.xu@rock-chips.com, devicetree@vger.kernel.org, Zubair.Kakakhel@imgtec.com, Pawel Moll , Ian Campbell , Inki Dae , Rob Herring , Sean Paul , Dave Airlie , mark.yao@rock-chips.com, fabio.estevam@freescale.com, Josh Boyer , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, djkurtz@google.com, Kumar Gala , Shawn Guo , vladimir_zapolskiy@mentor.com, Lucas Stach Subject: Re: [PATCH v15 06/12] dt-bindings: add document for dw_hdmi References: <1417505778-18341-1-git-send-email-andy.yan@rock-chips.com> <1417506124-18626-1-git-send-email-andy.yan@rock-chips.com> <1417544629.3411.15.camel@pengutronix.de> <547E5F51.2090800@rock-chips.com> <1417598398.5124.2.camel@pengutronix.de> In-Reply-To: <1417598398.5124.2.camel@pengutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Philipp: On 2014年12月03日 17:19, Philipp Zabel wrote: > Hi Andy, > > Am Mittwoch, den 03.12.2014, 08:54 +0800 schrieb Andy Yan: >>>> +Required properities: >>>> +- compatible: platform specific such as: >>>> + * "fsl,imx6q-hdmi" >>>> + * "fsl,imx6dl-hdmi" >>>> + * "rockchip,rk3288-dw-hdmi" >>> I think we should add a common compatible value "snps,dw-hdmi-tx" here: >>> >>> compatible = "fsl,imx6q-hdmi", "snps,dw-hdmi-tx"; >>> >> How about "snps,dw-hdmi", because the driver is not only about >> hdmi tx, but also include hdmi phy. > Synopsys call the whole module > "DesignWare HDMI Transmitter (TX) IP Solution": > > https://www.synopsys.com/dw/ipdir.php?ds=dwc_hdmi_14_csds_tx > https://www.synopsys.com/dw/ipdir.php?ds=dwc_hdmi_20_csds_tx > > That includes the PHY. I'd prefer keeping the -tx in there to > differentiate from a possible future "snps,dw-hdmi-rx": > > https://www.synopsys.com/dw/ipdir.php?ds=dwc_hdmi_14_csds_rx > https://www.synopsys.com/dw/ipdir.php?ds=dwc_hdmi_20_csds_rx Ok, I will add the compatible "snps, dw-hdmi-tx", So do I need to add this value to imx6dl.dtsi? >> If we add such compatible value, do we have to implement another >> platform driver like dw_hdmi-pltfm.c with the >> compatible="snps,dw-hdmi" , >> or just include the compatible value in dw_hdmi-imx.c and >> dw_hdmi-rockchip.c? > That common compatible doesn't have to be used by any driver. It's just > there to show these are the same/similar IP core. > If a common driver without any SoC specific knowledge could be written, > that one would match against the common compatible. > > regards > Philipp > > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip > > >