From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Yan Subject: Re: [PATCH v15 06/12] dt-bindings: add document for dw_hdmi Date: Wed, 03 Dec 2014 17:46:22 +0800 Message-ID: <547EDBEE.70700@rock-chips.com> References: <1417505778-18341-1-git-send-email-andy.yan@rock-chips.com> <1417506124-18626-1-git-send-email-andy.yan@rock-chips.com> <1417544629.3411.15.camel@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1417544629.3411.15.camel@pengutronix.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Philipp Zabel Cc: Mark Rutland , heiko@sntech.de, airlied@linux.ie, dri-devel@lists.freedesktop.org, ykk@rock-chips.com, devel@driverdev.osuosl.org, Arnd Bergmann , linux-rockchip@lists.infradead.org, Grant Likely , rmk+kernel@arm.linux.org.uk, jay.xu@rock-chips.com, devicetree@vger.kernel.org, Zubair.Kakakhel@imgtec.com, Pawel Moll , Ian Campbell , Inki Dae , Rob Herring , Sean Paul , Dave Airlie , mark.yao@rock-chips.com, fabio.estevam@freescale.com, Josh Boyer , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, djkurtz@google.com, Kumar Gala , Shawn Guo , vladimir_zapolskiy@mentor.comLucas Stach List-Id: devicetree@vger.kernel.org Ck9uIDIwMTTlubQxMuaciDAz5pelIDAyOjIzLCBQaGlsaXBwIFphYmVsIHdyb3RlOgo+IEhpIEFu ZHksCj4KPiBBbSBEaWVuc3RhZywgZGVuIDAyLjEyLjIwMTQsIDE1OjQyICswODAwIHNjaHJpZWIg QW5keSBZYW46Cj4+IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGlu Z3MvZHJtL2JyaWRnZS9kd19oZG1pLnR4dCBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5k aW5ncy9kcm0vYnJpZGdlL2R3X2hkbWkudHh0Cj4+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0Cj4+IGlu ZGV4IDAwMDAwMDAuLjEwN2MxY2EKPj4gLS0tIC9kZXYvbnVsbAo+PiArKysgYi9Eb2N1bWVudGF0 aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZHJtL2JyaWRnZS9kd19oZG1pLnR4dAo+PiBAQCAtMCww ICsxLDQwIEBACj4+ICtEZXNpZ25XYXJlIEhETUkgYnJpZGdlIGJpbmRpbmdzCj4+ICsKPj4gK1Jl cXVpcmVkIHByb3Blcml0aWVzOgo+PiArLSBjb21wYXRpYmxlOiBwbGF0Zm9ybSBzcGVjaWZpYyBz dWNoIGFzOgo+PiArICAgKiAiZnNsLGlteDZxLWhkbWkiCj4+ICsgICAqICJmc2wsaW14NmRsLWhk bWkiCj4+ICsgICAqICJyb2NrY2hpcCxyazMyODgtZHctaGRtaSIKPiBJIHRoaW5rIHdlIHNob3Vs ZCBhZGQgYSBjb21tb24gY29tcGF0aWJsZSB2YWx1ZSAic25wcyxkdy1oZG1pLXR4IiBoZXJlOgo+ Cj4gCWNvbXBhdGlibGUgPSAiZnNsLGlteDZxLWhkbWkiLCAic25wcyxkdy1oZG1pLXR4IjsKPgo+ PiArLSByZWc6IFBoeXNpY2FsIGJhc2UgYWRkcmVzcyBhbmQgbGVuZ3RoIG9mIHRoZSBjb250cm9s bGVyJ3MgcmVnaXN0ZXJzLgo+PiArLSBkZGMtaTJjLWJ1czogcGhhbmRsZSBvZiBhbiBJMkMgY29u dHJvbGxlciB1c2VkIGZvciBEREMgRURJRCBwcm9iaW5nCj4gQmV0dGVyIG1ha2UgZGRjLWkyYy1i dXMgb3B0aW9uYWwsIHNlZSB0aGUgb3RoZXIgdGhyZWFkIGFib3V0IHRoZSBkZGMgaTJjCj4gbWFz dGVyLgogICAgIEkgaGF2ZSB0aGUgc2FtZSBpZGVhIHRvbywgYnV0IHRoZSBwYXRjaCBhYm91dCBk ZGMgaTJjIG1hc3RlciBoYXMgbm90CiAgbGFuZGVkIHlldCwgIGNhbiB3ZSBjaGFuZ2UgdGhlIGRk Yy1pMmMtYnVzIHRvIG9wdGlvbmFsICBhZnRlciB0aGUgZGRjIAppMmMgbWFzdGVyCiAgcGF0Y2gg bGFuZD8KPj4gKy0gaW50ZXJydXB0czogVGhlIEhETUkgaW50ZXJydXB0IG51bWJlcgo+PiArCj4+ ICtPcHRpb25hbCBwcm9wZXJ0aWVzCj4+ICstIHJlZy1pby13aWR0aDogdGhlIHdpZHRoIG9mIHRo ZSByZWc6MSw0LCBkZWZhdWx0IHNldCB0byAxIGlmIG5vdCBwcmVzZW50Cj4+ICsKPj4gK0V4YW1w bGU6Cj4+ICsJaGRtaTogaGRtaUAwMTIwMDAwIHsKPj4gKwkJY29tcGF0aWJsZSA9ICJmc2wsaW14 NnEtaGRtaSI7Cj4+ICsJCXJlZyA9IDwweDAwMTIwMDAwIDB4OTAwMD47Cj4+ICsJCWludGVycnVw dHMgPSA8MCAxMTUgMHgwND47Cj4+ICsJCWdwciA9IDwmZ3ByPjsKPj4gKwkJY2xvY2tzID0gPCZj bGtzIDEyMz4sIDwmY2xrcyAxMjQ+Owo+PiArCQljbG9jay1uYW1lcyA9ICJpYWhiIiwgImlzZnIi Owo+PiArCQlkZGMtaTJjLWJ1cyA9IDwmaTJjMj47Cj4+ICsKPj4gKwkJcG9ydEAwIHsKPj4gKwkJ CXJlZyA9IDwwPjsKPj4gKwo+PiArCQkJaGRtaV9tdXhfMDogZW5kcG9pbnQgewo+PiArCQkJCXJl bW90ZS1lbmRwb2ludCA9IDwmaXB1MV9kaTBfaGRtaT47Cj4+ICsJCQl9Owo+PiArCQl9Owo+PiAr Cj4+ICsJCXBvcnRAMSB7Cj4+ICsJCQlyZWcgPSA8MT47Cj4+ICsKPj4gKwkJCWhkbWlfbXV4XzE6 IGVuZHBvaW50IHsKPj4gKwkJCQlyZW1vdGUtZW5kcG9pbnQgPSA8JmlwdTFfZGkxX2hkbWk+Owo+ PiArCQkJfTsKPj4gKwkJfTsKPj4gKwl9Owo+IHJlZ2FyZHMKPiBQaGlsaXBwCj4KPgo+IF9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gTGludXgtcm9ja2No aXAgbWFpbGluZyBsaXN0Cj4gTGludXgtcm9ja2NoaXBAbGlzdHMuaW5mcmFkZWFkLm9yZwo+IGh0 dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcm9ja2NoaXAK Pgo+Cj4KCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpk ZXZlbCBtYWlsaW5nIGxpc3QKZGV2ZWxAbGludXhkcml2ZXJwcm9qZWN0Lm9yZwpodHRwOi8vZHJp dmVyZGV2LmxpbnV4ZHJpdmVycHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcml2ZXJkZXYt ZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752311AbaLCJqg (ORCPT ); Wed, 3 Dec 2014 04:46:36 -0500 Received: from lucky1.263xmail.com ([211.157.147.132]:36408 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751736AbaLCJqd (ORCPT ); Wed, 3 Dec 2014 04:46:33 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: andy.yan@rock-chips.com X-FST-TO: l.stach@pengutronix.de X-SENDER-IP: 121.15.173.1 X-LOGIN-NAME: andy.yan@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <547EDBEE.70700@rock-chips.com> Date: Wed, 03 Dec 2014 17:46:22 +0800 From: Andy Yan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Philipp Zabel CC: Mark Rutland , heiko@sntech.de, airlied@linux.ie, dri-devel@lists.freedesktop.org, ykk@rock-chips.com, devel@driverdev.osuosl.org, Pawel Moll , linux-rockchip@lists.infradead.org, Grant Likely , Dave Airlie , jay.xu@rock-chips.com, devicetree@vger.kernel.org, Zubair.Kakakhel@imgtec.com, Arnd Bergmann , Ian Campbell , Inki Dae , Rob Herring , Sean Paul , rmk+kernel@arm.linux.org.uk, mark.yao@rock-chips.com, fabio.estevam@freescale.com, Josh Boyer , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, djkurtz@google.com, Kumar Gala , Shawn Guo , vladimir_zapolskiy@mentor.com, Lucas Stach Subject: Re: [PATCH v15 06/12] dt-bindings: add document for dw_hdmi References: <1417505778-18341-1-git-send-email-andy.yan@rock-chips.com> <1417506124-18626-1-git-send-email-andy.yan@rock-chips.com> <1417544629.3411.15.camel@pengutronix.de> In-Reply-To: <1417544629.3411.15.camel@pengutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2014年12月03日 02:23, Philipp Zabel wrote: > Hi Andy, > > Am Dienstag, den 02.12.2014, 15:42 +0800 schrieb Andy Yan: >> diff --git a/Documentation/devicetree/bindings/drm/bridge/dw_hdmi.txt b/Documentation/devicetree/bindings/drm/bridge/dw_hdmi.txt >> new file mode 100644 >> index 0000000..107c1ca >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/drm/bridge/dw_hdmi.txt >> @@ -0,0 +1,40 @@ >> +DesignWare HDMI bridge bindings >> + >> +Required properities: >> +- compatible: platform specific such as: >> + * "fsl,imx6q-hdmi" >> + * "fsl,imx6dl-hdmi" >> + * "rockchip,rk3288-dw-hdmi" > I think we should add a common compatible value "snps,dw-hdmi-tx" here: > > compatible = "fsl,imx6q-hdmi", "snps,dw-hdmi-tx"; > >> +- reg: Physical base address and length of the controller's registers. >> +- ddc-i2c-bus: phandle of an I2C controller used for DDC EDID probing > Better make ddc-i2c-bus optional, see the other thread about the ddc i2c > master. I have the same idea too, but the patch about ddc i2c master has not landed yet, can we change the ddc-i2c-bus to optional after the ddc i2c master patch land? >> +- interrupts: The HDMI interrupt number >> + >> +Optional properties >> +- reg-io-width: the width of the reg:1,4, default set to 1 if not present >> + >> +Example: >> + hdmi: hdmi@0120000 { >> + compatible = "fsl,imx6q-hdmi"; >> + reg = <0x00120000 0x9000>; >> + interrupts = <0 115 0x04>; >> + gpr = <&gpr>; >> + clocks = <&clks 123>, <&clks 124>; >> + clock-names = "iahb", "isfr"; >> + ddc-i2c-bus = <&i2c2>; >> + >> + port@0 { >> + reg = <0>; >> + >> + hdmi_mux_0: endpoint { >> + remote-endpoint = <&ipu1_di0_hdmi>; >> + }; >> + }; >> + >> + port@1 { >> + reg = <1>; >> + >> + hdmi_mux_1: endpoint { >> + remote-endpoint = <&ipu1_di1_hdmi>; >> + }; >> + }; >> + }; > regards > Philipp > > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip > > >