From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Tom Lendacky <thomas.lendacky@amd.com>, netdev@vger.kernel.org
Cc: David Miller <davem@davemloft.net>
Subject: Re: [PATCH net v1 1/2] amd-xgbe: Do not clear interrupt indicator
Date: Wed, 03 Dec 2014 14:34:35 +0300 [thread overview]
Message-ID: <547EF54B.1050308@cogentembedded.com> (raw)
In-Reply-To: <20141203001648.17582.48766.stgit@tlendack-t1.amdoffice.net>
Hello.
On 12/3/2014 3:16 AM, Tom Lendacky wrote:
> The interrupt value within the xgbe_ring_data structure is used as an
> indicator of which Rx descriptor should have the INTE bit set to
> generate an interrupt when that Rx descriptor is used. This bit was
> mistakenly cleared in the xgbe_unmap_rdata function, effectively
Not xgbe_unmap_skb() (as seems to follow from the patch)?
> nullifying the ethtool rx-frames support.
> Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
> ---
> drivers/net/ethernet/amd/xgbe/xgbe-desc.c | 1 -
> 1 file changed, 1 deletion(-)
> diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-desc.c b/drivers/net/ethernet/amd/xgbe/xgbe-desc.c
> index 6fc5da0..43b7d2e 100644
> --- a/drivers/net/ethernet/amd/xgbe/xgbe-desc.c
> +++ b/drivers/net/ethernet/amd/xgbe/xgbe-desc.c
> @@ -356,7 +356,6 @@ static void xgbe_unmap_skb(struct xgbe_prv_data *pdata,
>
> rdata->tso_header = 0;
> rdata->len = 0;
> - rdata->interrupt = 0;
> rdata->mapped_as_page = 0;
>
> if (rdata->state_saved) {
WBR, Sergei
next prev parent reply other threads:[~2014-12-03 11:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-03 0:16 [PATCH net v1 0/2] amd-xgbe: AMD XGBE driver fixes 2014-12-02 Tom Lendacky
2014-12-03 0:16 ` [PATCH net v1 1/2] amd-xgbe: Do not clear interrupt indicator Tom Lendacky
2014-12-03 11:34 ` Sergei Shtylyov [this message]
2014-12-03 14:27 ` Tom Lendacky
2014-12-03 0:16 ` [PATCH net v1 2/2] amd-xgbe: Associate Tx SKB with proper ring descriptor Tom Lendacky
2014-12-09 18:16 ` [PATCH net v1 0/2] amd-xgbe: AMD XGBE driver fixes 2014-12-02 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547EF54B.1050308@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.