From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Yan Subject: Re: [PATCH v15 06/12] dt-bindings: add document for dw_hdmi Date: Wed, 03 Dec 2014 19:58:30 +0800 Message-ID: <547EFAE6.9050404@rock-chips.com> References: <1417505778-18341-1-git-send-email-andy.yan@rock-chips.com> <1417506124-18626-1-git-send-email-andy.yan@rock-chips.com> <1417544629.3411.15.camel@pengutronix.de> <547EDBEE.70700@rock-chips.com> <1417607520.5124.8.camel@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1417607520.5124.8.camel@pengutronix.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Philipp Zabel Cc: Mark Rutland , heiko@sntech.de, airlied@linux.ie, dri-devel@lists.freedesktop.org, ykk@rock-chips.com, devel@driverdev.osuosl.org, Arnd Bergmann , linux-rockchip@lists.infradead.org, Grant Likely , rmk+kernel@arm.linux.org.uk, jay.xu@rock-chips.com, devicetree@vger.kernel.org, Zubair.Kakakhel@imgtec.com, Pawel Moll , Ian Campbell , Inki Dae , Rob Herring , Sean Paul , Dave Airlie , mark.yao@rock-chips.com, fabio.estevam@freescale.com, Josh Boyer , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, djkurtz@google.com, Kumar Gala , Shawn Guo , vladimir_zapolskiy@mentor.comLucas Stach List-Id: devicetree@vger.kernel.org Ck9uIDIwMTTlubQxMuaciDAz5pelIDE5OjUyLCBQaGlsaXBwIFphYmVsIHdyb3RlOgo+IEFtIE1p dHR3b2NoLCBkZW4gMDMuMTIuMjAxNCwgMTc6NDYgKzA4MDAgc2NocmllYiBBbmR5IFlhbjoKPj4g T24gMjAxNOW5tDEy5pyIMDPml6UgMDI6MjMsIFBoaWxpcHAgWmFiZWwgd3JvdGU6Cj4+PiBIaSBB bmR5LAo+Pj4KPj4+IEFtIERpZW5zdGFnLCBkZW4gMDIuMTIuMjAxNCwgMTU6NDIgKzA4MDAgc2No cmllYiBBbmR5IFlhbjoKPj4+PiBkaWZmIC0tZ2l0IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVl L2JpbmRpbmdzL2RybS9icmlkZ2UvZHdfaGRtaS50eHQgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRy ZWUvYmluZGluZ3MvZHJtL2JyaWRnZS9kd19oZG1pLnR4dAo+Pj4+IG5ldyBmaWxlIG1vZGUgMTAw NjQ0Cj4+Pj4gaW5kZXggMDAwMDAwMC4uMTA3YzFjYQo+Pj4+IC0tLSAvZGV2L251bGwKPj4+PiAr KysgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZHJtL2JyaWRnZS9kd19oZG1p LnR4dAo+Pj4+IEBAIC0wLDAgKzEsNDAgQEAKPj4+PiArRGVzaWduV2FyZSBIRE1JIGJyaWRnZSBi aW5kaW5ncwo+Pj4+ICsKPj4+PiArUmVxdWlyZWQgcHJvcGVyaXRpZXM6Cj4+Pj4gKy0gY29tcGF0 aWJsZTogcGxhdGZvcm0gc3BlY2lmaWMgc3VjaCBhczoKPj4+PiArICAgKiAiZnNsLGlteDZxLWhk bWkiCj4+Pj4gKyAgICogImZzbCxpbXg2ZGwtaGRtaSIKPj4+PiArICAgKiAicm9ja2NoaXAscmsz Mjg4LWR3LWhkbWkiCj4+PiBJIHRoaW5rIHdlIHNob3VsZCBhZGQgYSBjb21tb24gY29tcGF0aWJs ZSB2YWx1ZSAic25wcyxkdy1oZG1pLXR4IiBoZXJlOgo+Pj4KPj4+IAljb21wYXRpYmxlID0gImZz bCxpbXg2cS1oZG1pIiwgInNucHMsZHctaGRtaS10eCI7Cj4+Pgo+Pj4+ICstIHJlZzogUGh5c2lj YWwgYmFzZSBhZGRyZXNzIGFuZCBsZW5ndGggb2YgdGhlIGNvbnRyb2xsZXIncyByZWdpc3RlcnMu Cj4+Pj4gKy0gZGRjLWkyYy1idXM6IHBoYW5kbGUgb2YgYW4gSTJDIGNvbnRyb2xsZXIgdXNlZCBm b3IgRERDIEVESUQgcHJvYmluZwo+Pj4gQmV0dGVyIG1ha2UgZGRjLWkyYy1idXMgb3B0aW9uYWws IHNlZSB0aGUgb3RoZXIgdGhyZWFkIGFib3V0IHRoZSBkZGMgaTJjCj4+PiBtYXN0ZXIuCj4+ICAg ICAgIEkgaGF2ZSB0aGUgc2FtZSBpZGVhIHRvbywgYnV0IHRoZSBwYXRjaCBhYm91dCBkZGMgaTJj IG1hc3RlciBoYXMgbm90Cj4+ICAgIGxhbmRlZCB5ZXQsICBjYW4gd2UgY2hhbmdlIHRoZSBkZGMt aTJjLWJ1cyB0byBvcHRpb25hbCAgYWZ0ZXIgdGhlIGRkYwo+PiBpMmMgbWFzdGVyCj4+ICAgIHBh dGNoIGxhbmQ/Cj4gQ2hlY2sgb3V0IERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9k cm0vaW14L2hkbWkudHh0LCBpdCB3YXMKPiBhbHJlYWR5IG1hcmtlZCBhcyBvcHRpb25hbC4gV2Ug Y2FuJ3QgbWFrZSBpdCByZXF1aXJlZCBub3cuCj4KPiByZWdhcmRzCj4gUGhpbGlwcAo+Cj4KPgog ICBPSywgZ290IGl0LCB0aGFua3MKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmRldmVsIG1haWxpbmcgbGlzdApkZXZlbEBsaW51eGRyaXZlcnByb2plY3Qu b3JnCmh0dHA6Ly9kcml2ZXJkZXYubGludXhkcml2ZXJwcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2RyaXZlcmRldi1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753384AbaLCL7q (ORCPT ); Wed, 3 Dec 2014 06:59:46 -0500 Received: from va-smtp01.263.net ([54.88.144.211]:60391 "EHLO va-smtp01.263.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753063AbaLCL7D (ORCPT ); Wed, 3 Dec 2014 06:59:03 -0500 X-RL-SENDER: andy.yan@rock-chips.com X-FST-TO: l.stach@pengutronix.de X-SENDER-IP: 121.15.173.1 X-LOGIN-NAME: andy.yan@rock-chips.com X-UNIQUE-TAG: <70e0cef6140cdd9add7732c041d9fe82> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <547EFAE6.9050404@rock-chips.com> Date: Wed, 03 Dec 2014 19:58:30 +0800 From: Andy Yan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Philipp Zabel CC: Mark Rutland , heiko@sntech.de, airlied@linux.ie, dri-devel@lists.freedesktop.org, ykk@rock-chips.com, devel@driverdev.osuosl.org, Pawel Moll , linux-rockchip@lists.infradead.org, Grant Likely , Dave Airlie , jay.xu@rock-chips.com, devicetree@vger.kernel.org, Zubair.Kakakhel@imgtec.com, Arnd Bergmann , Ian Campbell , Inki Dae , Rob Herring , Sean Paul , rmk+kernel@arm.linux.org.uk, mark.yao@rock-chips.com, fabio.estevam@freescale.com, Josh Boyer , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, djkurtz@google.com, Kumar Gala , Shawn Guo , vladimir_zapolskiy@mentor.com, Lucas Stach Subject: Re: [PATCH v15 06/12] dt-bindings: add document for dw_hdmi References: <1417505778-18341-1-git-send-email-andy.yan@rock-chips.com> <1417506124-18626-1-git-send-email-andy.yan@rock-chips.com> <1417544629.3411.15.camel@pengutronix.de> <547EDBEE.70700@rock-chips.com> <1417607520.5124.8.camel@pengutronix.de> In-Reply-To: <1417607520.5124.8.camel@pengutronix.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2014年12月03日 19:52, Philipp Zabel wrote: > Am Mittwoch, den 03.12.2014, 17:46 +0800 schrieb Andy Yan: >> On 2014年12月03日 02:23, Philipp Zabel wrote: >>> Hi Andy, >>> >>> Am Dienstag, den 02.12.2014, 15:42 +0800 schrieb Andy Yan: >>>> diff --git a/Documentation/devicetree/bindings/drm/bridge/dw_hdmi.txt b/Documentation/devicetree/bindings/drm/bridge/dw_hdmi.txt >>>> new file mode 100644 >>>> index 0000000..107c1ca >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/drm/bridge/dw_hdmi.txt >>>> @@ -0,0 +1,40 @@ >>>> +DesignWare HDMI bridge bindings >>>> + >>>> +Required properities: >>>> +- compatible: platform specific such as: >>>> + * "fsl,imx6q-hdmi" >>>> + * "fsl,imx6dl-hdmi" >>>> + * "rockchip,rk3288-dw-hdmi" >>> I think we should add a common compatible value "snps,dw-hdmi-tx" here: >>> >>> compatible = "fsl,imx6q-hdmi", "snps,dw-hdmi-tx"; >>> >>>> +- reg: Physical base address and length of the controller's registers. >>>> +- ddc-i2c-bus: phandle of an I2C controller used for DDC EDID probing >>> Better make ddc-i2c-bus optional, see the other thread about the ddc i2c >>> master. >> I have the same idea too, but the patch about ddc i2c master has not >> landed yet, can we change the ddc-i2c-bus to optional after the ddc >> i2c master >> patch land? > Check out Documentation/devicetree/bindings/drm/imx/hdmi.txt, it was > already marked as optional. We can't make it required now. > > regards > Philipp > > > OK, got it, thanks