Re: [PATCH 2/2] Revert "[SCSI] mpt3sas: Remove phys on topology change"

[Tomas Henzl <thenzl@redhat.com>]

On 12/02/2014 04:28 PM, Sreekanth Reddy wrote:
> This reverts commit 963ba22b90a955363644cd397b20226928eab976
> ("mpt3sas: Remove phys on topology change")
>
> Reverting the previous mpt3sas drives patch changes,
> since we will observe below issue
>
> Issue:
> Drives connected Enclosure/Expander will unregister with
> SCSI Transport Layer, if any one remove and add expander
> cable with in DMD (Device Missing Delay) time period or 
> even any one power-off and power-on the Enclosure with in
> the DMD period.

Reviewed-by: Tomas Henzl <thenzl@redhat.com>

>
> Cc: <stable@vger.kernel.org>
> Cc: Tomas Henzl <thenzl@redhat.com>
> Signed-off-by: Sreekanth Reddy <Sreekanth.Reddy@avagotech.com>
> ---
>  drivers/scsi/mpt3sas/mpt3sas_transport.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/scsi/mpt3sas/mpt3sas_transport.c b/drivers/scsi/mpt3sas/mpt3sas_transport.c
> index d4bafaa..3637ae6 100644
> --- a/drivers/scsi/mpt3sas/mpt3sas_transport.c
> +++ b/drivers/scsi/mpt3sas/mpt3sas_transport.c
> @@ -1003,12 +1003,9 @@ mpt3sas_transport_update_links(struct MPT3SAS_ADAPTER *ioc,
>  		    &mpt3sas_phy->remote_identify);
>  		_transport_add_phy_to_an_existing_port(ioc, sas_node,
>  		    mpt3sas_phy, mpt3sas_phy->remote_identify.sas_address);
> -	} else {
> +	} else
>  		memset(&mpt3sas_phy->remote_identify, 0 , sizeof(struct
>  		    sas_identify));
> -		_transport_del_phy_from_an_existing_port(ioc, sas_node,
> -		    mpt3sas_phy);
> -	}
>  
>  	if (mpt3sas_phy->phy)
>  		mpt3sas_phy->phy->negotiated_linkrate =